From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C010CE77198 for ; Tue, 7 Jan 2025 07:33:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D5B26B00B0; Tue, 7 Jan 2025 02:33:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 687766B00BF; Tue, 7 Jan 2025 02:33:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FEFB6B00C0; Tue, 7 Jan 2025 02:33:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 30B2E6B00B0 for ; Tue, 7 Jan 2025 02:33:05 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CCFDFA074C for ; Tue, 7 Jan 2025 07:33:04 +0000 (UTC) X-FDA: 82979839488.30.F8FC598 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf21.hostedemail.com (Postfix) with ESMTP id 671651C0014 for ; Tue, 7 Jan 2025 07:33:02 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=a1iy5UTi; spf=pass (imf21.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736235183; a=rsa-sha256; cv=none; b=NHdgqifOf2PwhLrAw+/GgS2WHyzPxWUU7qdbPmvqHrtoePjsR30QMuMqDZyeWjfAMNP7re 5sffr6NxYq7+BclGvpAtpTNQFwwP9+4tni7VyVEWnWwYYGZSbDnqLhFou/DTozsh4yOfku tUkn45ltDdoo/5Z7FQuOnEIbIOBCwy0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=a1iy5UTi; spf=pass (imf21.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736235183; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oWOPrGULgEDzUljnOv0D7y9Z2oqc2AFjwXl92zvjRa0=; b=hHa9H7FFpAfpBTMTXzCS8S98DWxth2bKsXEASXfrLvHcQb4emh12k4MbUF4hMEfYEy9m1V wdR89j+S+RVV3h6odxi019f/OVfxV8v9Vi2BzbjY/bZcLY7I1SQ2+uBrbmytAY583gBkWn dNRp/Vdzr4o0qTSgJncQAixYEy1yaqE= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 1F57440E0163; Tue, 7 Jan 2025 07:32:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id gp_XynEJRAhn; Tue, 7 Jan 2025 07:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1736235169; bh=oWOPrGULgEDzUljnOv0D7y9Z2oqc2AFjwXl92zvjRa0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a1iy5UTiowwHwLV1fi/sYuVddu5lpqsuRs/YEyqpHiHv3k0ON4Sv3yMWFf3DJF3TP jtki+oxuBKIc/AA4s1FM2bNta348heviDtsXARKRf9xDxlXPeviIeejrNzd4TFYiYm VDtuQrnDfo+zDzpC918ygGN1JwaH3zMYRPEjGOK9CHD8wAsf3Do03hDEWV8ks/fUI0 AkTWL3KWbtd2NZHP0I7Gnyf0WXuyiP1ZD2lSEanNT491YwVgD8Cb8anESLm0f6Ml/E cNvfdVSlVaw/FxbkAUT/HgWjuYLGxvRqMx2avEPCF8fggJnsVkrS7FtbgwqobTEEkm 5xOCFv9oSlCT5vfyvNlHSKnohAeDl6OtvMPyJlQ+hp+Ykk7Q1zJe3G9kTJkLSzOhXJ bdcgamveUkpHh8mNTgZUzbVs7+W+S9dJBxnZ6vAtdQ76yIm4DAdt3oX/HKMbZtBrJY MVDdlP7PsHBZqS1Wb3E1mUbsCQbPM8dSpOcVUssj1ZAfqm20IYdwCiya7SkEfRqtPX yt+JYoTPBDpPFmVr2C0umut7sWa+7LoCP4xekvYGI4IQ7W+oVi31i06dexzY3TmNn6 In4tZ0M6Yj02Aeb8dwQqZAnDtEcASRTiCP4uU4BLiC5RmkxKZC2FsPp53k4mJFEgCT MrPoyx76Fucd0FtQx2Y3UDiw= Received: from zn.tnic (p200300ea971F93e8329c23ffFea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971f:93e8:329c:23ff:fea6:a903]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 80BE340E0266; Tue, 7 Jan 2025 07:32:05 +0000 (UTC) Date: Tue, 7 Jan 2025 08:32:04 +0100 From: Borislav Petkov To: Shiju Jose Cc: "linux-edac@vger.kernel.org" , "linux-cxl@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "tony.luck@intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "dan.j.williams@intel.com" , "dave@stgolabs.net" , Jonathan Cameron , "dave.jiang@intel.com" , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "david@redhat.com" , "Vilas.Sridharan@amd.com" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , "wbs@os.amperecomputing.com" , "nifan.cxl@gmail.com" , tanxiaofei , "Zengtao (B)" , Roberto Sassu , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm Subject: Re: [PATCH v18 02/19] EDAC: Add scrub control feature Message-ID: <20250107073204.GBZ3zYdOtWEbieKXiU@fat_crate.local> References: <20250106121017.1620-1-shiju.jose@huawei.com> <20250106121017.1620-3-shiju.jose@huawei.com> <20250106155733.GAZ3v9bQspKvdi3lZE@fat_crate.local> <36665b7bf4974020a34d08a7ddf6d554@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <36665b7bf4974020a34d08a7ddf6d554@huawei.com> X-Rspamd-Queue-Id: 671651C0014 X-Stat-Signature: sh3i76wyd7mhcu1u8xte4jz41pc1x39c X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736235182-613678 X-HE-Meta: U2FsdGVkX19hgeLGHTbBi0W0vvTZhFSmJIzmR2ZtHV5kNdc7+oYsOxqtTaPQ66U6rQcJNRFqCNc0s1L2F2i4IEn/3Vm+p6nVdlbY4P4zBDP3jdQq9ScdMp5YTX8aiXixS5vCi55OC2lNYAi5zvRhMtQbjvybI9CoNo6fU09J7caAWY3Y3PhQwZqXAP6fqhNdJ2petBC31cril1oANgv1OHzY0xgRjH9x7wvlaccsZQsieOG7ECXTVyRJFF89GlOvlhn5njCZLmpxxvvOcHEV9eP16F8IFlwabK32xyQ2BISf1rABhAkn1Hnu+R/BGjjqmxrhw/XAK+pqUNmubWS2COgwOJAuW8NP438IsAAnSWp7P2Zuw0CfP2FQ/JTVqqEWg7cdHcpuafdWgxMDIxAN/QmQaZMo2VmyCXW8fyocAM1hStehAeEQz7ZfAtN+YJG0YjJrYkfF8KPjpYbvyw06977IAuv9DEgf6bAng7N1kP4NuoZTbKU+0kw5LA9GV6Ccovj03aT8x03wo4M/D/F07ZuPM4mpicPXEc2+iiMQ8Nfe1aJo1WiX3Q3gyTGS39kxHBIz4qtJ3MHm3frKj5itB5acAvZzYcSQdnBs+AMzvBui8J5DauHUkoR55jTOK5ul18oi7FHOyRaAqP8eKMG9v9+mvLbkzyEXpURebMj3mDfTVFT2p/8RZ4GApZm3D1ReAgtL+IJLvuTNikV/YNehLxG7TDc3qovcAndqH/W6VOrJjJUX/HeBhYL12OUq0XXvDN2p/e3cKPN6pLh4ErejCn8NPx6hgXfeF/zFI0lNLI+/YfiRYhM0d8ap8AzBQKhGlb/i9h8KWiTUg0RvEqRTEbriwYcvBRcXNqK1BSZrzZBxWvdIZDrOzC6VXIhsW/OdXW3ZeJtAboPA4M7kb8U2JE6VgU/XOjzgoAEbG8A6baq+roLcrUcuVONOaMsV+cRIRG+fwPIDLl2Z4J81RHy iRsbPUuc XSuUKxClsHwtP3QpuwXMvbfAem/iaoDzKhpOGq4qp0cNbC0a8nA5MlViT6zthow0vmshxbxUWdUiiwre9H1inuAsdHl1NXxMND/lwKyHOrvTG1sScDgScWCE8fDYo4Ziz+9mhj/kNDJJle+wD62p5rWaP4cFw+SspOgxz/30JFLQ7H5xVsftnb9SHe14zRD4y/ltMc8gfuimc6EdHB/EjUEaLXZto/R3kCGMbQyS7fRd0IQcKq/DRHyvj76slrgJG6B4slkjjBAP0b8zvL4kyOUsl549mjxpnbDBIWMBqZUQCw0uZ65Wc/XuNoH6tEgS6vrDdIQgjUGISlA0DPj9toD0i4ImODO+qifFH54XqDlc4nak= X-Bogosity: Ham, tests=bogofilter, spamicity=0.007222, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 06, 2025 at 07:34:41PM +0000, Shiju Jose wrote: > My understanding is that you meant the following changes (diff to this > patch), for scrub? (and similar for other features). Please let me know if > you need any corrections. Yes, something like that except "select" is evil and should be used only when the items it selects do not pull in more stuff. And since scrub is all optional, it should all be depends. > diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig > index 06f7b43a6f78..709bd7ad8015 100644 > --- a/drivers/edac/Kconfig > +++ b/drivers/edac/Kconfig > @@ -9,6 +9,14 @@ config EDAC_ATOMIC_SCRUB > config EDAC_SUPPORT > bool > > +config EDAC_FEAT_SCRUB EDAC_SCRUB is perfectly fine. > + bool > + help > + The EDAC scrub feature is optional and is designed to control the > + memory scrubbers in the system. The common sysfs scrub interface > + abstracts the control of various arbitrary scrubbing functionalities > + into a unified set of functions. This should come... > + > menuconfig EDAC > tristate "EDAC (Error Detection And Correction) reporting" > depends on HAS_IOMEM && EDAC_SUPPORT && RAS ... in here as it is part of EDAC. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette