linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Huacai Chen <chenhuacai@loongson.cn>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, Koichiro Den <koichiro.den@canonical.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Charalampos Mitrodimas <charalampos.mitrodimas@vrull.eu>,
	Huacai Chen <chenhuacai@loongson.cn>
Subject: [PATCH] Simple fix
Date: Tue,  7 Jan 2025 09:18:48 +0800	[thread overview]
Message-ID: <20250107011848.689556-1-chenhuacai@loongson.cn> (raw)
In-Reply-To: <7gd4skn6l4i3liu6cvzmgqlrwxc3rukrnau7lnpyhmfyjuvqwl@gdwgybedp5gs>

Hi, all, I like simple fixes, so is this acceptable (based on an early
version from Koichiro Den)?
---
 mm/vmstat.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/mm/vmstat.c b/mm/vmstat.c
index 0889b75cef14..1badc24a21ff 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -2122,10 +2122,15 @@ static void __init start_shepherd_timer(void)
 {
 	int cpu;
 
-	for_each_possible_cpu(cpu)
+	for_each_possible_cpu(cpu) {
 		INIT_DEFERRABLE_WORK(per_cpu_ptr(&vmstat_work, cpu),
 			vmstat_update);
 
+		/* Will be enabled on vmstat_cpu_online() */
+		if (!cpu_online(cpu))
+			disable_delayed_work_sync(&per_cpu(vmstat_work, cpu));
+	}
+
 	schedule_delayed_work(&shepherd,
 		round_jiffies_relative(sysctl_stat_interval));
 }
-- 
2.43.5



  parent reply	other threads:[~2025-01-07  1:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-21  3:33 [PATCH v2] vmstat: disable vmstat_work on vmstat_cpu_down_prep() Koichiro Den
2025-01-03 23:33 ` Lorenzo Stoakes
2025-01-04  4:00   ` Koichiro Den
2025-01-06  2:18     ` Charalampos Mitrodimas
2025-01-06 10:04     ` Mark Rutland
2025-01-06 10:18     ` Geert Uytterhoeven
2025-01-06 10:52     ` Lorenzo Stoakes
2025-01-06 12:53       ` Charalampos Mitrodimas
2025-01-06 12:58         ` Lorenzo Stoakes
2025-01-06 13:03       ` Koichiro Den
2025-01-06 13:53         ` Koichiro Den
2025-01-07  1:18         ` Huacai Chen [this message]
2025-01-07  3:35           ` [PATCH] Simple fix Matthew Wilcox
2025-01-07  3:58             ` Huacai Chen
2025-01-07  8:47           ` Lorenzo Stoakes
2025-01-07 10:29             ` Huacai Chen
2025-01-07 11:00               ` Lorenzo Stoakes
2025-01-08  2:22                 ` Koichiro Den
2025-01-08  2:26                   ` Koichiro Den
2025-01-08  2:31                   ` Huacai Chen
2025-01-08  3:41                     ` Koichiro Den
2025-01-08  3:57                       ` Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250107011848.689556-1-chenhuacai@loongson.cn \
    --to=chenhuacai@loongson.cn \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=charalampos.mitrodimas@vrull.eu \
    --cc=chenhuacai@kernel.org \
    --cc=koichiro.den@canonical.com \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox