From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2755FE77197 for ; Tue, 7 Jan 2025 14:53:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B5988D0005; Tue, 7 Jan 2025 09:53:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 964D58D0001; Tue, 7 Jan 2025 09:53:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8057D8D0005; Tue, 7 Jan 2025 09:53:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 613DB8D0001 for ; Tue, 7 Jan 2025 09:53:26 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EEA32ADA02 for ; Tue, 7 Jan 2025 14:53:25 +0000 (UTC) X-FDA: 82980949170.16.0CFD7D5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 4D887180012 for ; Tue, 7 Jan 2025 14:53:24 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LjkvKFlI; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736261604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g7JrPsese7sRiCxkJKkOiOCVe9HpHY9NUFE2NbbCAIw=; b=5RF1puv6dDZPV+Q5sWay8fy952T1ThejVfE6xjce4ZMojHugq5hIAoQTM2G8/AqNfQc/zw tHGY0GhYYg0s8q82VDeKC9le3XVyzlfHFnSS1h2Ci7rFja1MKzvblugbJEwXq9cn1YclCW ZGVKQvEjmrTmGQQ6VWdXLxjNSSRuSfQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736261604; a=rsa-sha256; cv=none; b=ygvDCtQLajQV1Hkw2bWxVn3H3Jg9RtYhB/G2gdrU+QEdPItkHE7SnU6BwNlrC30hJanNIg e97Ww39JoQZnAIkQnoYVmvbzuS9ms5UyX8gEN8MnNTBfOXG79xv50Xk1HKHomZuQIgqq0o egaY48vv2HH26+Z5OC2SyG9yZULmSGw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LjkvKFlI; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 223F35C61D1; Tue, 7 Jan 2025 14:52:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD7ECC4CED6; Tue, 7 Jan 2025 14:53:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736261602; bh=GnpjmvnUMoYz2GvLIOPTjHDiLas71QEvJn7JLu51h94=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LjkvKFlIxmpEX05lXA8Ow/KoaHo4lLpyUn2jN81Kn06BJKJ2j4vz0lDZ9Q1zdAHl5 WuIA7efVcl+tavOuPK9i68MrQ4J1uoK6RbMwPdIznlLyU6i1eypyyMXwGip3ErTBx2 IEa43p9Ow+IsxFphE2V1Yr2riNBfcadcUN1WmJQoHIlkkZ+p1oU0ppeCWGzKgsr4wM f9fdaLwhuPXkNmO2Vk/pXbn5CqmRN1MA50GKlSivq5bOjE2AqgYc7cic5z1V2M4Z9N Lty4SsNq9xumOyPcaWXZVvS2lMl/pyVaMuFF+yxz18K0gM3r7cInMrJmYA2fHBBrR2 HrpbE/lKUTLLg== Date: Tue, 7 Jan 2025 15:53:18 +0100 From: Christian Brauner To: Maninder Singh Cc: viro@zeniv.linux.org.uk, elver@google.com, jack@suse.cz, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, r.thapliyal@samsung.com Subject: Re: [PATCH 1/1] lib/list_debug.c: add object information in case of invalid object Message-ID: <20250107-grade-entgiften-74e459edf9ce@brauner> References: <20241230101043.53773-1-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241230101043.53773-1-maninder1.s@samsung.com> X-Stat-Signature: agjkyj67erj7hsjqd4ea6u85fr4ipswr X-Rspamd-Queue-Id: 4D887180012 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736261604-696214 X-HE-Meta: U2FsdGVkX18/EvCHR8qeFj7a7qPdFNFdlD7OokWDRQRUYCYp0VSSiG/WwEVSv1dRrnwCJX6m88gjsllK6Al5WFG8fbs3al6+2vPZlNWdN+MEZiF2qc4KQClXXlsEJGBI0UZm8NetLXfWAHjbqwwX4ZXoPMXS38E018qmWV7yZ8YSEIYz+lHdLZ2iAFmPlbRwW6NoXlAt/ZpA+UYkrc8XzwSkVfF5GlMK4oTBogI2N0Yc0JCTVm8zw7wzV27LykT2kOsibyMZPIbzzeFGC7fRJmZow9pIOIKBPFBE/pMAVR4DcJgn0RRuG9Eg0MTtf9axHoaUG/YGXfYgV3Quedc9SOoBLpLxnmB+nqhHZU7wfilj8Ssps83w7oMgtVxcc7A658/i3aulcU3rNPEH6k9iBz+e1zhn3DSa3rsZV2YCK3dOSlMaBHWUpD5KnKmjaJdtr1Gq0pUt6SuCXJ1GD58g/wGml7MyeHXaCjEw77Rn1UNz5wRbd3jiqZRGhfNYIc1sMO8YZa+7MOSTSs17VXSpXyvAqP9AKdfm15otA0tL7S10btJPiFfxe39NhNK7zwu+EimovlCTZ0jydxzMKG8Z/a2lbqhtuQOK4L00KZoYgiF7ZehuYLyDl25FuBt854cDllNsfnNt1izZLCdoRoiQGysbUnpMJ1Ae7ihsSJkZq49fAGoZEAKA3RiHklrN6sJwP5xE2VrVgGvwg54zLdEgditCI+OROAgdmsW5Wrws8krT2VD8NRAWSxZRQ1fPhfM2+QBGmsYejr+Yj1XR/s1hxXlz3eF4gTCVeK+/fFjRP4NatfY0tR7yhGm7yp9ZH0f399ybNP4Ob1VbOjqox0tPECvyFKPC7n3LWvJVH/t/Qomgc9jQamM3qdx8ECaxZSRT8CYz9SeC4v+cyfyDygEZF6eFSYFRBUEDZo7AN9IC5sX5jt/01G05uN3v1tPcdM/UQZDh/wG0XWjprO1zhPd aBGrMgmA IL5KAF97bkyY/azN21pIcO/abZG4QPIrb7qE+1zP77sqP/lZMwi0z1MBFECH77LX2gdZBvaIZCz6NhOwwZ7WUGfW+bSYCqetT1f9LUFupVHNZ5VMSEMFW/UiahHLP4agZ4YISKP4GywNDi6joVXQWeR3yfUNLZGbripesNbVr8VixIZDCCne5Ea3xjFQ/BPizTsQ7/0u8FG+q1rrRnoADvzZs+mA3LuItP5REZXYZFEXC+R6qoyIuXWY5sAt315HfRM5y6Bapdxc8gMwkYTMWA53icGAHj6E+fUE0EbgSnxfQknDijSUyF0GVkmZkQVylTTveBcf95lvcBWey8o3yuYRp2vUoLcwxvA//50HoLXf6GhBzOsK/IQ3Ohw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 30, 2024 at 03:40:43PM +0530, Maninder Singh wrote: > As of now during link list corruption it prints about cluprit address > and its wrong value, but sometime it is not enough to catch the actual > issue point. > > If it prints allocation and free path of that corrupted node, > it will be a lot easier to find and fix the issues. > > Adding the same information when data mismatch is found in link list > debug data: > > [ 14.243055] slab kmalloc-32 start ffff0000cda19320 data offset 32 pointer offset 8 size 32 allocated at add_to_list+0x28/0xb0 > [ 14.245259] __kmalloc_cache_noprof+0x1c4/0x358 > [ 14.245572] add_to_list+0x28/0xb0 > ... > [ 14.248632] do_el0_svc_compat+0x1c/0x34 > [ 14.249018] el0_svc_compat+0x2c/0x80 > [ 14.249244] Free path: > [ 14.249410] kfree+0x24c/0x2f0 > [ 14.249724] do_force_corruption+0xbc/0x100 > ... > [ 14.252266] el0_svc_common.constprop.0+0x40/0xe0 > [ 14.252540] do_el0_svc_compat+0x1c/0x34 > [ 14.252763] el0_svc_compat+0x2c/0x80 > [ 14.253071] ------------[ cut here ]------------ > [ 14.253303] list_del corruption. next->prev should be ffff0000cda192a8, but was 6b6b6b6b6b6b6b6b. (next=ffff0000cda19348) > [ 14.254255] WARNING: CPU: 3 PID: 84 at lib/list_debug.c:65 __list_del_entry_valid_or_report+0x158/0x164 > > moved prototype of mem_dump_obj() to bug.h, as mm.h can not be included > in bug.h. > > Signed-off-by: Maninder Singh > --- Can you please base this on either the latest mainline tag or vfs-6.14.misc and resend, please?