From: Christian Brauner <brauner@kernel.org>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: viro@zeniv.linux.org.uk, elver@google.com, jack@suse.cz,
akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
r.thapliyal@samsung.com
Subject: Re: [PATCH 1/1] lib/list_debug.c: add object information in case of invalid object
Date: Tue, 7 Jan 2025 15:53:18 +0100 [thread overview]
Message-ID: <20250107-grade-entgiften-74e459edf9ce@brauner> (raw)
In-Reply-To: <20241230101043.53773-1-maninder1.s@samsung.com>
On Mon, Dec 30, 2024 at 03:40:43PM +0530, Maninder Singh wrote:
> As of now during link list corruption it prints about cluprit address
> and its wrong value, but sometime it is not enough to catch the actual
> issue point.
>
> If it prints allocation and free path of that corrupted node,
> it will be a lot easier to find and fix the issues.
>
> Adding the same information when data mismatch is found in link list
> debug data:
>
> [ 14.243055] slab kmalloc-32 start ffff0000cda19320 data offset 32 pointer offset 8 size 32 allocated at add_to_list+0x28/0xb0
> [ 14.245259] __kmalloc_cache_noprof+0x1c4/0x358
> [ 14.245572] add_to_list+0x28/0xb0
> ...
> [ 14.248632] do_el0_svc_compat+0x1c/0x34
> [ 14.249018] el0_svc_compat+0x2c/0x80
> [ 14.249244] Free path:
> [ 14.249410] kfree+0x24c/0x2f0
> [ 14.249724] do_force_corruption+0xbc/0x100
> ...
> [ 14.252266] el0_svc_common.constprop.0+0x40/0xe0
> [ 14.252540] do_el0_svc_compat+0x1c/0x34
> [ 14.252763] el0_svc_compat+0x2c/0x80
> [ 14.253071] ------------[ cut here ]------------
> [ 14.253303] list_del corruption. next->prev should be ffff0000cda192a8, but was 6b6b6b6b6b6b6b6b. (next=ffff0000cda19348)
> [ 14.254255] WARNING: CPU: 3 PID: 84 at lib/list_debug.c:65 __list_del_entry_valid_or_report+0x158/0x164
>
> moved prototype of mem_dump_obj() to bug.h, as mm.h can not be included
> in bug.h.
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> ---
Can you please base this on either the latest mainline tag or
vfs-6.14.misc and resend, please?
next prev parent reply other threads:[~2025-01-07 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20241230101102epcas5p1c879ea11518951971c8f1bf3dbc3fe39@epcas5p1.samsung.com>
2024-12-30 10:10 ` Maninder Singh
2025-01-06 9:13 ` Jan Kara
2025-01-07 14:53 ` Christian Brauner [this message]
[not found] ` <CGME20241230101102epcas5p1c879ea11518951971c8f1bf3dbc3fe39@epcms5p6>
2025-01-08 3:17 ` Maninder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250107-grade-entgiften-74e459edf9ce@brauner \
--to=brauner@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=elver@google.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maninder1.s@samsung.com \
--cc=r.thapliyal@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox