From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0380DE77198 for ; Mon, 6 Jan 2025 18:15:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5632B6B0082; Mon, 6 Jan 2025 13:15:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 512D06B0083; Mon, 6 Jan 2025 13:15:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D9BC6B0088; Mon, 6 Jan 2025 13:15:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1FEDE6B0082 for ; Mon, 6 Jan 2025 13:15:26 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6EBCDA01CD for ; Mon, 6 Jan 2025 18:15:25 +0000 (UTC) X-FDA: 82977829410.17.0DDC660 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf06.hostedemail.com (Postfix) with ESMTP id 0BF8118001C for ; Mon, 6 Jan 2025 18:15:22 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=bO94gHrP; spf=pass (imf06.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736187323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XtrqCTz17rdNo4T58qOmAk/HkjN9Hdh/wuhUXnMZ4eM=; b=JdddPxGRR7qRpHFzq5Ci7mcrciMHxAYT3F4mgwu1PVIbsigMzT9Pbur8y0BD907WfuFNLm k4mKl+UgMCrTZ6Z6sL1EtmVA3C2Dv3F5Y9r1zpKsUU1+wM+zlH3/0K32G56EzaF7a4Trdu aPqtzrc68RIOE4+uXyeQfw4FRKSXFrU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736187323; a=rsa-sha256; cv=none; b=hBN8OaSVAEEKkFiljQpRZPYg9fZWZuNM9oMGoFgsALymXQFRQZYtmHEo/IF901H+OV4NzQ noFeBR7XIABEbFpirhQmLTW3ZgA7wG15PqAxDadpumeajLmJ8Y7Ls+Qwfb7P/RIYoGnUXc 8zYB1vRz7VjP8qV13wgTT55wc903JHI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=bO94gHrP; spf=pass (imf06.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id C05C340E0264; Mon, 6 Jan 2025 18:15:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id YMeSZnjZtynO; Mon, 6 Jan 2025 18:15:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1736187316; bh=XtrqCTz17rdNo4T58qOmAk/HkjN9Hdh/wuhUXnMZ4eM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bO94gHrPKk2itP27Y8JbFiH2ehGmQ5jMZVP7cho4cSa+7Ky6y47Z6aBIhFJcqU4cr AxxSctnn8absZnIBd6IrSysD9bN6jpR62mFflPciFcSTByB5ZPQyndpPLBWHgGBjsO LCwhkIigrmIa1o69ahzjiMTnMa71QyNemlHQXyjfxYbnpmK4ijoKcvFT4Bf7E4IAJq oekbMiWqp+EYxy3HAMHrScD4iImYOXRU/3Z9j+gDWXlWmJ8hBiUW1N2TI8xT5Mo/kO wCzHmsT2qR6ToIcaKYZy4q14eunfyGR9WqUhKlOmyAIKvSPbmYHS/uOMNAXT3XeXVj 3u+OacamMAYQh6aMQns6Z+5MBPkTuog0WJ/TKQ0/l3xggtKgH47HXJhsxHpeYVePlo q2stVywiBNwr6iP709XIfrjL7jiKMNaN0IR5Yd+vgvFbY3UGgJdRcEMQZL9S7xXTDX 9/i7UiRRdi7hyYGzxZaPBBiJWsPtNG0qWVUpiyW1KtmkeYe/Z0tJQcBDHLst+c/FjN EFTJjWzKEOeetnup+LXA0/PvzM8wfzJ9P1g7dAlB16pcIvCbWvGz+GoI8/buE1kGbz D0Otsy6H+aDB0qKs6bCBJOuPRe/DFtqlGBV2AiWvfA0lJmObEQNPElD33m1n1JPT0W NthDFMeQEBXi7SFhXodxn/xA= Received: from zn.tnic (p200300ea971F93E8329c23Fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971f:93e8:329c:23ff:fea6:a903]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id DACE440E021E; Mon, 6 Jan 2025 18:15:00 +0000 (UTC) Date: Mon, 6 Jan 2025 19:14:53 +0100 From: Borislav Petkov To: Dave Hansen Cc: Rik van Riel , x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org Subject: Re: [PATCH 05/12] x86/mm: add INVLPGB support code Message-ID: <20250106181453.GBZ3wdnUpDfm_t6nvc@fat_crate.local> References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-6-riel@surriel.com> <20250102124247.GPZ3aJx8JTJa6PcaOW@fat_crate.local> <0de32bbc-66e9-4875-af87-7a2fa2e03e39@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0de32bbc-66e9-4875-af87-7a2fa2e03e39@intel.com> X-Rspamd-Queue-Id: 0BF8118001C X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 4ouwcf4k1wb4kk33jdc3u7pdf5dwm5gr X-HE-Tag: 1736187322-248128 X-HE-Meta: U2FsdGVkX19q8ahaUYpJwgGlqNO1uoVojTB3GEAAAaByNDMx8PSyDpnCrmDFNgAjdSqpBzGCls+mBXlGLe4bi2fqnJ/Yv7ka/MBUAPT+PWsm8AK6z3kplJJEGQc9o86IvnpoLh3k+jp+NZs7CDD7oDkwYhI2kcylDA7DTDyXv2J+lLKxhheBP+0tYCuM7ewHvF/t7Pu7S+gZf335caZU6jsqTvZl4LeZUE+8TqGKDcXiMafwqgwnR2ykn3np/dPeq/3UO2V3lUuPMS8CXRFArSQl5F6YSyvSj18jOGIe4317YwByKP4aFNk18O5cwrFp/YiCvIkOnU7bEy5wSaXs2a2Nb35nUVarnOR3XI80GRFncDTleu7jpI6cCO4qWRNjS72BTXJhJWhMOIrFixXgWXVQw9UZFIVWJfv1Fd4MGr0B/Txhg+SbM8Vxz7BGLcpEsJ/QAH3Az3qIVLM3eZcVe/wD24feguHmSFk+W7bCNMmSBcyEAKgmF7RdLzPLCfCc6rKRLWpCt4g30B+WxJQtX+VGorhkRVqZbyJQIQFbDjPJvqFNWl+2GzC/87g8nMpenfhORd71+j9QWmq+2X43LQBhHDhqgGQrS4+ze8vy7pWwL3NWeq9dGA9MxjRRRzydArVHNxluiC6LVo/3kS7RE9gcw6m+D2J4WnAbAlgqebl3aHEn3gk9p8I1h9VXTy/vkDh+frQch1Ab3gm/XqlZ8AlABRNa8FV8m8LAE5Plg51V0Cxi+D1fZQ54hxW/IstTfCMzX85gI+vgcm0B44D/fxRQtpXJH9tf++XfCeKzYnpfSq0rFtZXO9yOvcRilTj8buitloEfJmbAmuyOBPNKOSBteYVFySE0CB7hJzviwqVFf2FUcBG3nf4cquTA16lgK388JTfxI0X3Kx3huIwu0KyTJYG+HruI8FDjJ8XDpCav/iYOeiTes7fHnV10tGCI7pnHo+ImLI+KERaWMzW p2aGjRUM cr425OwTgQVrs+JeQzGYu1roKk0v8aLbFWRfT1B5pF89Oa2oRXHxQsOVwX+jC6DQ9vID/i+23jwJidi9XytGPI097nPSoUmlt35w1QGzYaTYLO5Ko4mRH1tiTegU6Fimdp2b7RHTHVJkbnhuy5pmIIaMLkDABU5VQmLjU2Dfp/o4Nk0ZGM27oXTB+kLjBPLdxXP1X35JJOcXN+uokEUMI3ATNGs1v6gAdcEL5lHb4plv+XzlVYtK6a/PbPMQJ5MKj7iGi/clEKdxp66k9Ve0DkLoDEcP4+0lk6eCouj7YwkX5nop0I2uGfQPCXxYXLe99hbJr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 06, 2025 at 08:50:27AM -0800, Dave Hansen wrote: > There's some precedent for defining them all up front, like we did for > invpcid_flush_*(). > > For INVPCID, there are four variants and two of them got used up front. > But I get that it's a balancing act between having untested code that > might bitrot and introducing helpers at a time when someone (Rik) is > very likely to get all the variants coded up correctly. That's just silly. We don't add all possible hw interface bits, defines etc, when they're not going to be used. If we did, the kernel would be an unwieldy mess of MSRs and their bits, unused insn opcodes and the like. If someone wants to use them, someone can add them *when* they're needed - not preemptively, in anticipation that *someone* *might* use them in the future. Guys, I can't believe I'm actually arguing for something so obvious. :-\ -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette