From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15C01E77188 for ; Mon, 6 Jan 2025 10:08:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8352E6B0089; Mon, 6 Jan 2025 05:08:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E4F86B008A; Mon, 6 Jan 2025 05:08:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AC936B008C; Mon, 6 Jan 2025 05:08:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4D9FE6B0089 for ; Mon, 6 Jan 2025 05:08:04 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C11AA4432A for ; Mon, 6 Jan 2025 10:08:03 +0000 (UTC) X-FDA: 82976601246.17.CCB208A Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by imf22.hostedemail.com (Postfix) with ESMTP id 02D2DC0006 for ; Mon, 6 Jan 2025 10:08:00 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CobwqmSd; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf22.hostedemail.com: domain of lkp@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736158081; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ixM0DazKG3KzmwqQrWR86TiKT9eE8NPJEKcRXqd3AUU=; b=sO+DZwnBDaKRaAjI1bbSPo2pTBwONLjr+B+3o+8HQ8+3uQNTmXEcSGwyzYyzDy2jpgZF45 XDRQAGcbxRAumpi/q9KeqtaCrgd3EpMYH7OFiCw+EmJ1mw63Mrq1aMNuQMUy0aWGlFZ5dX vBkYsz86Gds8Tu9rJdycaXUGFHpAONk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736158081; a=rsa-sha256; cv=none; b=A+OQyeAlulY93X5l0BqdGS8vmMggilCQK/u29hHyjWNtcMbCWGRVZbDywSFTQ1WL0vjW47 xVh+MRzQdYO8pdhD4YHgFqjFXzEL9Or9H+NpEDZoN4lmaswWOXv9pu+3mUj/2os0V8zKkS BMnh/pGn95f9fEBo4lx7ivbpgUL50cE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CobwqmSd; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf22.hostedemail.com: domain of lkp@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=lkp@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736158081; x=1767694081; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=sEL7NksqZgZXuAEm9a2vntcgzwajolbt9hhD8Ehbcv8=; b=CobwqmSdAsANWGWvS2XriQmGb0XLMu4CKljJn0bE9nxsDsQVHNLwK/kV Z5IUcMNOMNTvQKpBPR13nX9zU+ahnMihBIsc9Lu4IAeQ7fFIER6M11z+X /BgWXLQ0Tnc2iBAmJ3gu/ElxqFC6t5oYbETMo38Lr3Iz9xtPTnJkz4R11 kWssikjEm33ZAFE5VRWcTzxLDr/iADmE+vtgYJ+wNyOOuflWNqQumAfFN nyzt4SGvj6lzfCmOm9aePxeMbKNJJ+9RTTkXxAjeI47gLpEO8/4XumGOE GJUNfQORFie2K5t0xBWLcWcVdBo4UZVWtau4z/5YS0eGJ5ssDGJnmGw7O g==; X-CSE-ConnectionGUID: wN00I01zSrW/XGXsGPl19Q== X-CSE-MsgGUID: ub+GZJXhQsKFj27lOh1XMg== X-IronPort-AV: E=McAfee;i="6700,10204,11306"; a="36178046" X-IronPort-AV: E=Sophos;i="6.12,292,1728975600"; d="scan'208";a="36178046" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2025 02:08:00 -0800 X-CSE-ConnectionGUID: r8cLw7L4SKCzwa2GNg8UxA== X-CSE-MsgGUID: IFzx8dRQSGCblnOYPgMMFg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,292,1728975600"; d="scan'208";a="102893843" Received: from lkp-server01.sh.intel.com (HELO d63d4d77d921) ([10.239.97.150]) by fmviesa010.fm.intel.com with ESMTP; 06 Jan 2025 02:07:53 -0800 Received: from kbuild by d63d4d77d921 with local (Exim 4.96) (envelope-from ) id 1tUk1X-000CTb-0m; Mon, 06 Jan 2025 10:07:51 +0000 Date: Mon, 6 Jan 2025 18:07:29 +0800 From: kernel test robot To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: oe-kbuild-all@lists.linux.dev, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, ioworker0@gmail.com, david@redhat.com, ryan.roberts@arm.com, zhengtangquan@oppo.com, ying.huang@intel.com, kasong@tencent.com, chrisl@kernel.org, baolin.wang@linux.alibaba.com, Barry Song , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Anshuman Khandual , Shaoqin Huang , Gavin Shan , Kefeng Wang , Mark Rutland , "Kirill A. Shutemov" , Yosry Ahmed Subject: Re: [PATCH 2/3] mm: Support tlbbatch flush for a range of PTEs Message-ID: <202501061736.FoHcInHJ-lkp@intel.com> References: <20250106031711.82855-3-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250106031711.82855-3-21cnbao@gmail.com> X-Stat-Signature: goh1wgfz1io8hnwgr5p9mf3nn9m4y5cr X-Rspamd-Queue-Id: 02D2DC0006 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736158080-446179 X-HE-Meta: U2FsdGVkX194B8rLH5UT8KT8E1hHVg+L977gdSlPip9/DWPUXuJ1OuenwL6wM1nBj9Dq91AP7p0m+8U7QlWfeWsm5peS3Li9Pk+dwH3WjkBfL6KurxdfyWYRLQHdXJKXiTOF/sEL4O1004+GV2U7MK2MXGBg1U3mkHixBVgbNOjHQgbyNL+USOrkIVIhxDorMLbLH2+aAGw/ds2IG72I2N7FtIkKXYEOxkLYiBVBugQd7Xfbp/VnNxx/orbgDMF6RaXys4hEC9Ovg1koiqIQbEHn+L+4TI32AAZasPNKzcfwVoD4ZIg/hTcmKZcHjZW75ihbtPlCFJO9D+ANT3RIBJRE95fl2KidX9XWpNCe/iGGNwmfpBmuUenyLObe48zPYTUwRJBHQFTZzA1VH3e3GEu9isqg3QaFCd43S7yzjaRYpLZhN7F4wFiy2kq1nqWgv3gqERql5w1CxLHFO3XYFCzuqUEM1Z2E17nEY1b5YtC5oezrhM008TwpcmQVSMGpzo3sIKMqRvxb4oK8VVLyixEcYMLIX7kQiHT3pNuZpQJsoVP6WXXoivD6zbA5QrLaWDrr6ai5MbX4rol5pr0IR5OWNrfBOauRgv6Pi0VP+EqLQ5pwK6npbJy5EY5HCYL469JIDGyMNiCPAtn/MY6MFcxOxtBNUJ6wiojkJV3sx1L0zF8475sDhZShfUaLM66/AFKZmfouEOFaeL5YmZgHH+5zXB76LlBnJk5zAAlRSUMItumb4a42i6FG6bMXxZ1P+7QqlvVFeuRBc6iTfK5b7sf+ZsY2aiQ4jvr/lL/CTBXNJrVGeaww1ZOnwFWotBX9sthyQYG5/uTkcZcYUkt7kbIDEDoyEccAWUx9hwWFd8UzZS7m4wfIXFlHMt6mFNu52ncdrxugVajEEwuSx3GRIFPGzwoi8/QN1w1I6k4uNDKqZp9QB1Sa4mFfUoomeuFeXDoMiOFxkSaGfM5bwjR /SohQKax 8TovnMveBKVr0/JDK8FswIThMHpHdyB+HwTGmeAH1lBcfOLmI1+YlZlkmqBd1GE4S7Yx2n6/+9Or3cRzHgkAZJb+vtN8W1zqS1mDcyvkUrNd3vQomsQajTVlMO80i8ZXAaGRQAR0jwExEXXpVs3hNwoq+7/kHpqFE/2dm/eet2i/xi0fKlp9lhRiV1HKE3hZZLfZlYJP1VFo/uhIyZeuC3C/tT8N/3055G7Z36QDwHsMeutd4RXdgzFfYrEY9sF4qFP7yAMCXetfdTPb71oh/hO41TMJ8dPSlr1sNiMNB+pPfvPNRN864DNRePnFyXPDbRvxbB9lhsBKgemn2ILwd4GUX9wngipTawWYP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Barry, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Barry-Song/mm-set-folio-swapbacked-iff-folios-are-dirty-in-try_to_unmap_one/20250106-112638 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20250106031711.82855-3-21cnbao%40gmail.com patch subject: [PATCH 2/3] mm: Support tlbbatch flush for a range of PTEs config: riscv-randconfig-001-20250106 (https://download.01.org/0day-ci/archive/20250106/202501061736.FoHcInHJ-lkp@intel.com/config) compiler: riscv64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250106/202501061736.FoHcInHJ-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202501061736.FoHcInHJ-lkp@intel.com/ All errors (new ones prefixed by >>): mm/rmap.c: In function 'set_tlb_ubc_flush_pending': >> mm/rmap.c:685:9: error: too many arguments to function 'arch_tlbbatch_add_pending' 685 | arch_tlbbatch_add_pending(&tlb_ubc->arch, mm, uaddr, size); | ^~~~~~~~~~~~~~~~~~~~~~~~~ In file included from arch/riscv/include/asm/pgtable.h:113, from include/linux/pgtable.h:6, from include/linux/mm.h:30, from mm/rmap.c:55: arch/riscv/include/asm/tlbflush.h:62:6: note: declared here 62 | void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *batch, | ^~~~~~~~~~~~~~~~~~~~~~~~~ vim +/arch_tlbbatch_add_pending +685 mm/rmap.c 663 664 /* 665 * Bits 0-14 of mm->tlb_flush_batched record pending generations. 666 * Bits 16-30 of mm->tlb_flush_batched bit record flushed generations. 667 */ 668 #define TLB_FLUSH_BATCH_FLUSHED_SHIFT 16 669 #define TLB_FLUSH_BATCH_PENDING_MASK \ 670 ((1 << (TLB_FLUSH_BATCH_FLUSHED_SHIFT - 1)) - 1) 671 #define TLB_FLUSH_BATCH_PENDING_LARGE \ 672 (TLB_FLUSH_BATCH_PENDING_MASK / 2) 673 674 static void set_tlb_ubc_flush_pending(struct mm_struct *mm, pte_t pteval, 675 unsigned long uaddr, 676 unsigned long size) 677 { 678 struct tlbflush_unmap_batch *tlb_ubc = ¤t->tlb_ubc; 679 int batch; 680 bool writable = pte_dirty(pteval); 681 682 if (!pte_accessible(mm, pteval)) 683 return; 684 > 685 arch_tlbbatch_add_pending(&tlb_ubc->arch, mm, uaddr, size); 686 tlb_ubc->flush_required = true; 687 688 /* 689 * Ensure compiler does not re-order the setting of tlb_flush_batched 690 * before the PTE is cleared. 691 */ 692 barrier(); 693 batch = atomic_read(&mm->tlb_flush_batched); 694 retry: 695 if ((batch & TLB_FLUSH_BATCH_PENDING_MASK) > TLB_FLUSH_BATCH_PENDING_LARGE) { 696 /* 697 * Prevent `pending' from catching up with `flushed' because of 698 * overflow. Reset `pending' and `flushed' to be 1 and 0 if 699 * `pending' becomes large. 700 */ 701 if (!atomic_try_cmpxchg(&mm->tlb_flush_batched, &batch, 1)) 702 goto retry; 703 } else { 704 atomic_inc(&mm->tlb_flush_batched); 705 } 706 707 /* 708 * If the PTE was dirty then it's best to assume it's writable. The 709 * caller must use try_to_unmap_flush_dirty() or try_to_unmap_flush() 710 * before the page is queued for IO. 711 */ 712 if (writable) 713 tlb_ubc->writable = true; 714 } 715 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki