From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BF29E77188 for ; Mon, 6 Jan 2025 15:58:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCD6D6B0082; Mon, 6 Jan 2025 10:58:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D57016B0083; Mon, 6 Jan 2025 10:58:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1F846B0088; Mon, 6 Jan 2025 10:58:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A0B506B0082 for ; Mon, 6 Jan 2025 10:58:33 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 593E81615D6 for ; Mon, 6 Jan 2025 15:58:33 +0000 (UTC) X-FDA: 82977484506.13.4462C38 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf12.hostedemail.com (Postfix) with ESMTP id 19EFF40012 for ; Mon, 6 Jan 2025 15:58:30 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=aSFAR86e; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf12.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736179111; a=rsa-sha256; cv=none; b=xNzZONCarJLkAd/NHoaXCkYwwRO+EZti3Tk863YKfJuLYlDdfWyX6yEB6r3fVwWYl6/Mka 0dzLKpaRioo+jQgRzoK8vRbXzkk9cr6l9h7zl7LkSKbMx1zMVj76HrYh5rR9OsR5B7qbmF Ry3Hl6KBl4YkW53IhhZUibEo20GzYoU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=aSFAR86e; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf12.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736179111; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8FrVdzdC933WpWJbSAkxpf/1Y9ZiykmTnNKJwfdveoY=; b=bjq00d2XKPL47pvIGtdoFU7721afFaq5ixZCXgKMBrf53u6opv8pdx2fuNg+iOuJ86P7Cj d/kgH3bwJlEC71Tzi5VDSXaaBfsLrTq/goXKtA8pUO7w+SCgJRZQXNJx8YmqrSR1aWxVni xueJts6tMR3f2cn+70hOjf/aWcRm9ZI= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 0C9A740E021E; Mon, 6 Jan 2025 15:58:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ays1ynDfBLxs; Mon, 6 Jan 2025 15:58:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1736179103; bh=8FrVdzdC933WpWJbSAkxpf/1Y9ZiykmTnNKJwfdveoY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aSFAR86e8ssloIm1iXi7KtTbARiywe+7BSqSRtda1pArvVPG3Td27EVFLWYHMj6IL UjqKRqJP0SdMEdRGAKunTiM3o424aiCV5t4AJjyaE9yjjBnQ3ztMTS7WXpaN7lQR7X NDdV/JZ9eDK6jweZfrXLvCI9N8a1YhHYemi7ytuORvEvJWrm3SnE1IaYoEsSHH/wbg 06i5Y7MQDKbsWmm9aHOSjXuVdxN65XI0VcpODpuZeZBzUdYSAWN0l/KcXdi1RzbL5o BgcKY7z6gW251R2q1hPlAdsej8SD3yU/4sZ4M6EaV67zZn40byU+QNbmejzzhE/05b r6C8cWyEYL6c8ZqsuEFoUJQs9Nyt10QEKTR/tIv0d9sHmlMw5FAhJg3QEMKn+DwYA5 0aA+ic7VYwYeEOJS1YuZQG0hztPPsl6mxtL5Ehml+K343h/T2y31d1GTCbbFdwLYue 3WuodtQtkwlY9CZ1vLKeVy0FpKTRgtwgMxTvl17R5+Np0Fy8Be/j9/7A+Ohtc4JHXn 4LB8UPDpY3CPmQHeU44fvjdhlmuFN91XTfJwQ6n+Ca1/9xVTyS3LxU2j7ej06sW/10 KbvGnBo4R4wgx08WOfs7WAj/trosJgEm35qzxUPjD/8kdgPn6L4uJzVY4Vwa8tpO43 bae+pjYD4KXbOuNpiOLqQIkI= Received: from zn.tnic (p200300Ea971F93E8329c23Fffea6A903.dip0.t-ipconnect.de [IPv6:2003:ea:971f:93e8:329c:23ff:fea6:a903]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 1420140E0163; Mon, 6 Jan 2025 15:57:40 +0000 (UTC) Date: Mon, 6 Jan 2025 16:57:33 +0100 From: Borislav Petkov To: shiju.jose@huawei.com Cc: linux-edac@vger.kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v18 02/19] EDAC: Add scrub control feature Message-ID: <20250106155733.GAZ3v9bQspKvdi3lZE@fat_crate.local> References: <20250106121017.1620-1-shiju.jose@huawei.com> <20250106121017.1620-3-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250106121017.1620-3-shiju.jose@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 19EFF40012 X-Stat-Signature: r55fzkgn7g1bwcioj5jpin6aqmsj9r8y X-HE-Tag: 1736179110-789858 X-HE-Meta: U2FsdGVkX19NoVrSFhmnmUdT/b8etBLc5CkSzQ3DFPQYU9wxHAGTweAomPol4Qm6b8O5yV4bZLK0iiXQe46pxTlDNkEg5xiFkb/m5kkiltcUPoCHohaH97VVSzCHcWSzZhnDwdsH4XUA2fqY7zg/4P34nO0cOx+IE0Od06ebvRE5I02167Ur5lJU9AiOkpy2qdBxKtGRaPHxb9Pg+X7Rxq+4xC04SBfrALOTQ4zX4EgKHUCJUETHuh9RdRm+XXkjQ1bj9HfubjG4rE1UsHBn8a8ESGYQYBFMjzGykG1lEzIwhMMAmQyac4QtG3Sk6bChckZYGTNcBZY2i1zaOVDdacPzWJGIhauHSeYLEcx0w/k3x9IvAEGBZWsryP79G2zvc2HLCZt4yLgZSFe+0L5srn6GEV63XcKUqH1UpNCH5G1Kg9Lx7QsP/0Qx7dov8hP2idn8TDL+ZaMDn4EYAdOUmJfmP6gd15go8l84uBOVG0PvsWnnm/5IrMti8Pcf582GL0ErNOIlPHe6IrG/hLSr9x2uwIxtER0uJobIZ7OnCrad1RwFHh61z65VhjwYwmkRISew9kQQFzefbbagj2BrqDSHJ7ChESgdD2E1ueJ0DcCllRy8/Nw9BjBzllSCAY68ho6hd1VrJXEy2F5m2yVokQGn5mnxdaIIzFdM+6GViNdj7rkpzDP03Psi7Vmxl2ddGKZyk0SGuaMBdpan/bMWkY/zVcS4Mr6UWTgcIu6ZQ7UbbpJQW513kAZu96chJg5HvSb4isTavixL4STQgZGdGRDt6G5yBCOZdmRyUVjyliheK/v25dqMV8ZYKOiQr6IKDZI6vKw/7EVI1he8zJeR1L7j4Wam1+zslWIVL+XVz4udO8iIvdJ38EuyByZnO/oT0dSO5wBIu+UI3sV23iMTUw8RGjMdm6vQKxhN8ozlK3Hp3jfP+oWwR68fKH9jNI8KUxfHg/xpOvjPGueG90I VV044wlW D+0rlOip/4CQKrnuoujCHzuoCr9T3DpOJesttnugP/VhFNrDbK75wlSq+eEsL1tAnZTri30w+tcu7s68Wo6arMPe/o60e8f4pJAP/6mdMsAgnggVCz2zC+sszLih3ZxkgKvYEtpgfc3YpmwG5Ay7W/kpTPEfi5tt7ZTE+DPHBf4xPZtQP1zf3cmFx9fxLht+5yvSxdHPqLYSzuHuoPHhuDBhmCINsV8XD9cGDrCVdIWvPTManOr9OaGD2xl2PerL/UBohL4JpWuDc7+6HcktF1PAtLVN4Ej8reAh8sd1/yORT+xosY0a8TZS/56UHkKQPAMd8cjASAeyuhwLMidt2x0tk6KhyYo4QEvd1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002703, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 06, 2025 at 12:09:58PM +0000, shiju.jose@huawei.com wrote: > diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile > index f9cf19d8d13d..a162726cc6b9 100644 > --- a/drivers/edac/Makefile > +++ b/drivers/edac/Makefile > @@ -10,6 +10,7 @@ obj-$(CONFIG_EDAC) := edac_core.o > > edac_core-y := edac_mc.o edac_device.o edac_mc_sysfs.o > edac_core-y += edac_module.o edac_device_sysfs.o wq.o > +edac_core-y += scrub.o You're not being serious here - this scrub gunk is enabled by default on *everything*? So the main user of this is going to be CXL, AFAICT, so the scrubbing gunk should depend at least on it or so. Definitely not unconditionally enabled on every build. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette