From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C5F0E77188 for ; Mon, 6 Jan 2025 23:52:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F9BF6B00B3; Mon, 6 Jan 2025 18:52:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A8806B00B4; Mon, 6 Jan 2025 18:52:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5974B6B00B5; Mon, 6 Jan 2025 18:52:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3BB2A6B00B3 for ; Mon, 6 Jan 2025 18:52:00 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8A99080423 for ; Mon, 6 Jan 2025 23:51:59 +0000 (UTC) X-FDA: 82978677558.08.9EDEAED Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf25.hostedemail.com (Postfix) with ESMTP id EDF40A000A for ; Mon, 6 Jan 2025 23:51:57 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=THtnK84Q; spf=pass (imf25.hostedemail.com: domain of kuba@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736207518; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h+t1a+Wcy+KRp/X70C+xsAph3Osz6Q09Wwfd7it6d6E=; b=0NLJQzwMhm239jdilj6uihLZXw2MSLQ+ojJi2jRvuzKmQClbk55FTHl8UwawSKsWM9NrfQ XTvqIZCq64tOKeEVkWhtZEO+At8oH6vKYM6iAzkh/+lK7dpKPDe9Xiax5UeWjzfcVI2KTG CgsrqTYuryr0LJlSilxUEietnYXG8VM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=THtnK84Q; spf=pass (imf25.hostedemail.com: domain of kuba@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736207518; a=rsa-sha256; cv=none; b=jwm7HayLpzq6lSFWKYpqopsRn0zH1M/VTDhGjltyq6+o5h6eN7fjn9W/mYCYH397SF3wbG rtPtk3dqVJuZNGNPh40rNgIcTWH+RglIRH2UOLhtoFxRgiDLA+f8Ztq938OtmgEaC6LhW4 ydNNS06+xQaZkKeHbFtpd3FkIQst7UM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 58059A41F79; Mon, 6 Jan 2025 23:50:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DAA0C4CED2; Mon, 6 Jan 2025 23:51:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736207516; bh=Fu660IWX5S6t38fvF4BJ3mJpDywwH3eUN5CgaE2RF48=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=THtnK84Q3Oz/4hr7raXMxtb5YnvUsRTP0Z19d7W1LrVc020uM7dHfZQfaxiTBglrb 0uuuv4Ij3lvMxNaYs2U4xkdM1Mx/sGjqu1JF+EzVap0/mx7qJl607iIVwFe7HlG/s7 X14tjNK13QKsu2ZiViNL1koaVJB20ifxb0W3EaYPXmPLvd3Yw+D43CTpT1bSdEobVq enX3QqiM+fai2TD9PUP4jYCjrP+vp1tAnLo3Mv9k74nhRw+qMFF8RVBP1HKE/Gn7Dh zUjVlCwE6j30/RjhJSLQ4oMUTU+dCUPoDR1ZtkaF7VWo4Bdbpz0SfAdBVCoaM5Jkwm nSJEIl5AN0w9g== Date: Mon, 6 Jan 2025 15:51:54 -0800 From: Jakub Kicinski To: Yunsheng Lin Cc: , , , , , Alexander Lobakin , Robin Murphy , Alexander Duyck , Andrew Morton , IOMMU , MM , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Matthias Brugger , AngeloGioacchino Del Regno , , , , , , Subject: Re: [PATCH net-next v6 0/8] fix two bugs related to page_pool Message-ID: <20250106155154.7c349c67@kernel.org> In-Reply-To: <20250106130116.457938-1-linyunsheng@huawei.com> References: <20250106130116.457938-1-linyunsheng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EDF40A000A X-Rspam-User: X-Stat-Signature: buc1rbayr71gkc9f5ezbmbxqo6x781ak X-HE-Tag: 1736207517-739182 X-HE-Meta: U2FsdGVkX1+GF6t5TO+epOFtyLW1OYk+c38TJbhu9qAoZ/9SiWyKAWRE+wuhB1QbP29VZa4MDADqreh8SOW6E4Q0qG+pAucp9hDTdzUk7GTe/6lMyCTcoYFiUZmoy7ctpthP9Zv4Hf/1kPXRdx0bv+7V28EFa6YdA8ADRLHi9sCDpGPyRbyut1u7+Ke0ag9M7ncw0wcoVX18T26jvUoHEHy+9iURJa3jLStZRStcB3sfC0HVrzYVoTkNVaTEXXIUxzZfqxkfN8CYJ8/3WYoCE6Ib+7MS+ucV953w+iZ6npwaJd6EUKTdU7GvF4+0YOVEirl8JWIBdKVZwwmXXsquGlw/eqxt0ds9puiPwrPQkbxwqt36eoa5T4LgZ85vT+5xtBEwotZUJM6gr/hjDf1dnITLAyMsC2/NJxza2NbBORG9r6CaWIfzRg8ddET10QIuVLY+Xqd0k5UhfizlRcvi2m+A56VJQcvclVRM42bE/kRXvV5Tz2uAYaoymNv2Ixe7jG3r+YCVkX5ZJkwMseovzJqzaPby+FDL/OfPmcWrb0Y2P5IxFbJk5jA7xpX/2QLQWHmjFzoIBQTnt474kJNhxGpa4P0ozAjXfU0k4NEJInlqQzdlMNtwrmqNdlH/Nu8ARm2KJ3nYkog7GfIPALBttJnozbmYvYj82Ka+fxx9VaKHFTE/VT+YnEMuEAuR+4/1IX+U7+8pxRWxT5foop0n8Q1bQoqEers7tIBVR7UQUxygknkhYcmGde0X3vxZ96vYaHklL1n7vxtW00m/HZq2Mz0ZR3ShtPz/qdYiQc7W0ryI9s95LJ364S7/UhGhxk0SkUGJ8VpcK7wL6P81AVGl1yqbSPWH9NbA82MrKEpx0MnwZwWaqO2TlG/oXaWhxypuCo/+sizl/ea+AzUo9XW9t5fX98JQigtihEaEAbqVyCHP3SE/rLRX7+el2HtWC0+EgDQYB+PRe0I8geRiZV9 ZShDZq3R POgZMa13vF6JnlEuPt+46j41Mm1/TNDcu1nVzWmX261JUU19ExWIoX8NuHDB4YUCxDy0woipNPbWZhbyVwghh5f/O+O58isqCVnHkU+j2dFPwfsdEQnCJQ1RQk7vLLAd5P82s5Fx+bVIeittzTDSACJUykAdYCcIpyirLvnq+en0EhBsotbIP3h9HYFZFCmF2BaxeiazC5ke431aAfchOB8j2JRuuguvDGMKXBy6GJIswqrvzZsj5Ey2OupiXdwMObyvpzKDLcvp5ObPCBF0Uw416bl/9L2D/N2qcd/fdGz0LfDjntWijW3E9S3kEHkP5rNX5BCIsU8fbW0wyvQloAt6+dkHdkM7TUyirw+eUQaOLQi5RaKeu/NQ00VQjHnCkyQw+lGm01ca6s4I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 6 Jan 2025 21:01:08 +0800 Yunsheng Lin wrote: > This patchset fix a possible time window problem for page_pool and > the dma API misuse problem as mentioned in [1], and try to avoid the > overhead of the fixing using some optimization. > > From the below performance data, the overhead is not so obvious > due to performance variations for time_bench_page_pool01_fast_path() > and time_bench_page_pool02_ptr_ring, and there is about 20ns overhead > for time_bench_page_pool03_slow() for fixing the bug. This appears to make the selftest from the drivers/net target implode. [ 20.227775][ T218] BUG: KASAN: use-after-free in page_pool_item_uninit+0x100/0x130 Running the ping.py tests should be enough to repro. -- pw-bot: cr