From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DA51E77188 for ; Mon, 6 Jan 2025 13:38:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C0AD6B0089; Mon, 6 Jan 2025 08:38:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9704B6B0096; Mon, 6 Jan 2025 08:38:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 838086B0098; Mon, 6 Jan 2025 08:38:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6AEA76B0089 for ; Mon, 6 Jan 2025 08:38:36 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2578145C13 for ; Mon, 6 Jan 2025 13:38:36 +0000 (UTC) X-FDA: 82977131832.11.B9CA96C Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf27.hostedemail.com (Postfix) with ESMTP id D84DC40008 for ; Mon, 6 Jan 2025 13:38:33 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b="a6r/e+yp"; spf=pass (imf27.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736170714; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vapTAC/GEEGTnYZ53xdjNO/fhQQizrf5LOYcJ/SbwYg=; b=fLFXMTaeJZfZ1Ht98KGcffb7HMAw6osaSI91fJt0PhzwRLt4qa2LoL2QLbTsIAqH3/IDkJ fzFPMNnSapuvUYZUHB/g0SMh38mgEEFnZt6WLGW6XoEUD0Lc9qx8c9Q8iTrQeA+ul4P90i MCTeLSplLPjfcImBIGl1bJv/8uD3GPQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736170714; a=rsa-sha256; cv=none; b=Wt5iZdvJ0xIZZAEOy//dZ9kqwi8p79TxX7lErRGxCf/iTEGUhg9PevteyF0grSfSepzw9W nRu+kQbUukLGhYBoWWoxJQQyMxqQHbUdFzWRiHFSD2KUnAihFmjvm3szCOIHvkckw2EtKi gbD9bpyYf19MDEGqsRJRv4mXAceg2dE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b="a6r/e+yp"; spf=pass (imf27.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id B576540E0264; Mon, 6 Jan 2025 13:38:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id H0HQOCO2LQHj; Mon, 6 Jan 2025 13:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1736170706; bh=vapTAC/GEEGTnYZ53xdjNO/fhQQizrf5LOYcJ/SbwYg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a6r/e+ypRHhvgbzh/mgij/5mJlINJJ6teS9ui0CKYuuhEQQzvPk88j8Qo1uF6HgVY y7uHlTsz+z4b28mjXefVpUxSVF3629CxLIPUPGob5zJpBPPTNxrZZlpIUA4spHVKgq 8wv9JBYWNgKDxkBrxCUcHpkHed/D6r4VU8kvxaUMonfXUGpZCuQIBbkGKA0gLohUpj shXxeLOLWZrxRJEDJ7T0/I6MRqnuaLOvHEENc44GIdVSQrGmia1E5m0gFMKnEQQ+Cu HgN73nLNk2nX7sOgdye+iab+ZPug9yNYae2YqU2dyQ4n1xtRKsqyqW/xqxA7EJZdaM j2Pttwql9X5yJMtiFZzz3h9IQ+QAnezz/Yeu0DW6rnC7iKrMuk/P8tnaVxqu972FoF +bf5Wuwps1Zjis54u7LFzxu0zCmab48GtFzFhdSnhird8p/ekllkn3H4NialDr8mLC tC2JSsDD+tKqjO/IUSo0ZFRcXo+GhCL6qjdIX1/hehTzPJrh8zy/KKSy7LpTgqho8R qIxJqc5tGD1xvrPMSi0kY84DY7SZXv/mAxFbJooMcdJTbbrnBzI3sfiQpqMk1l6WAV rCyp1rTorZ9PAFQFqkTHydNY4/Ie+/fAfonKg/1wHK/yaED+HaUJwzSfbDnB8Wm9pg hrky52M2BnDnUbve+dlUu4yg= Received: from zn.tnic (p200300EA971f93E8329C23fFFeA6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971f:93e8:329c:23ff:fea6:a903]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2C9A140E0163; Mon, 6 Jan 2025 13:37:43 +0000 (UTC) Date: Mon, 6 Jan 2025 14:37:36 +0100 From: Borislav Petkov To: shiju.jose@huawei.com Cc: linux-edac@vger.kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v18 01/19] EDAC: Add support for EDAC device features control Message-ID: <20250106133736.GDZ3vcoEBa-lJwqAxL@fat_crate.local> References: <20250106121017.1620-1-shiju.jose@huawei.com> <20250106121017.1620-2-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250106121017.1620-2-shiju.jose@huawei.com> X-Rspamd-Queue-Id: D84DC40008 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: hiuwxir837gyk49pkn3199x8ogtmusjx X-HE-Tag: 1736170713-850286 X-HE-Meta: U2FsdGVkX18vSQFFRocO7Ax8xLEN9ndw36kc6hDq/93kJe3VdqNivFYyJiTS7yCkHl4toUe0+qdgsSJDHrBiT/D8PiojD7XdTu2Ghs6RXJuP4tkA9Zy4NZ/c2GBQiZzMcLbwdfHKLB5cZS5KX5oYQ+rRFIsojAph3Kjwl46/6wyaAxttdmP+h+vN6E33A9hbPMAyoNAa53ef60W42Kk1m1Kkcxamq7qJgBEB0ZIZ6ZUYx3dJPAm09Wtt2b276wPAAK15B22Vg4td74lvSD5J4t5JJaW7u1bCEkmuFmVrMYK8Pm/MuuictxcPaHMe/pLAtcQ17ZOrnsL+oVYgmlhAW9Fj0OilCEBys8C9XxG2LmuakJiPKnCKzS95iIFGOeoJ2CZ6a2IhsWFq3gQNcHXRdRBv/Y/eQaJF0v6Yf6zFLlJGum6j5bOEfAw1fw06f9vy9TthEH6e+kobiWlfjSeNgAN9pWiAEsTJeBJiZiusg0qK4uYTlvg+0xgiQwC8pzQiBu+w2x6xCjXyD+KPvPtv17MbLa4+MELwsj4f1nqA2nyRaGr3bbpZ4UfMI172Wgj7PC+RsNa4ccuErf3b+9hWtztdG4OcxqgyhZ5Z7taRzQrPUKaFUNWBrbA4BY5U0eTlIriQ8Z+YMg1kW+NXwkh25Ad5OVx+kuDcPCH9/FLtd+kf9zm/WofsR7SshIB4/W4YG6Meq4tlRFnWaccJH/Mfi7YLv4IEHbj9y0v+OlwbnG3M1LWyBQdOeI+0rpHcmClaEN9v38VIYlM2jiN7Vg3x6in1RW3xVqfYEvPPUIl4zjYnJYdulYnDOWECzEvkzgDSXCyvR4bi8O1Ar9HLfTAeJkepElH2Fiep8GkVyj+NLqxpSmwxg8jkAAxUOtkje/po5kpwLIKEOsveLKh0ZOaV5k6yxD/1u2c6GJp7dcxwY0j0hHFAgO6AH3bBJnoYy+UuP4hjJlz8h2CFnyW60eM 9cKwNMJc dyReN9FqfzuOmTlU0i4X7wpv5S+obIWYxcFE/pBYtpMY/8+CCa3k90rUWRaFLPRM/5pxxZrY0JIzxUDO7jKvbPc0MsXJxSCljwk88//x8Lfv/M1cpswT1E6bmLaMQ3JF3YRrcJNnsIruBvP5O4kVCPCTLlxXZYM94VRYehBoBcW9Y9gURtpSwY5oPwJeUA25P23beKvI9UWb4KWyZp6aWBKn/uhkMTvAGx2kJtyF7YxoZ+uKaVLZvKvBBY+bk7HwEACmFf2OTPv5qcAJV7GoBGi0k19EQUQGwa9pH8FlXA+OUuafF+U95vAlOvzuCiqXn3IyGC4d7Pkicfgni7dSsrmy8v4J9KTgTaptF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 06, 2025 at 12:09:57PM +0000, shiju.jose@huawei.com wrote: > +int edac_dev_register(struct device *parent, char *name, > + void *private, int num_features, > + const struct edac_dev_feature *ras_features) > +{ > + const struct attribute_group **ras_attr_groups; > + struct edac_dev_feat_ctx *ctx; > + int attr_gcnt = 0; > + int ret, feat; > + > + if (!parent || !name || !num_features || !ras_features) > + return -EINVAL; > + > + /* Double parse to make space for attributes */ > + for (feat = 0; feat < num_features; feat++) { > + switch (ras_features[feat].ft_type) { > + /* Add feature specific code */ > + default: > + return -EINVAL; > + } > + } > + > + ctx = kzalloc(sizeof(*ctx), GFP_KERNEL); > + if (!ctx) > + return -ENOMEM; > + > + ras_attr_groups = kcalloc(attr_gcnt + 1, sizeof(*ras_attr_groups), GFP_KERNEL); > + if (!ras_attr_groups) { > + ret = -ENOMEM; > + goto ctx_free; > + } > + > + attr_gcnt = 0; > + for (feat = 0; feat < num_features; feat++, ras_features++) { > + switch (ras_features->ft_type) { > + /* Add feature specific code */ > + default: > + ret = -EINVAL; > + goto groups_free; > + } > + } > + > + ctx->dev.parent = parent; > + ctx->dev.bus = edac_get_sysfs_subsys(); > + ctx->dev.type = &edac_dev_type; > + ctx->dev.groups = ras_attr_groups; > + ctx->private = private; > + dev_set_drvdata(&ctx->dev, ctx); > + > + ret = dev_set_name(&ctx->dev, name); > + if (ret) > + goto groups_free; > + > + ret = device_register(&ctx->dev); > + if (ret) { > + put_device(&ctx->dev); > + return ret; Who is freeing ctx and ras_attr_groups when you return here? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette