From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80612E77188 for ; Sat, 4 Jan 2025 00:00:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE5E26B0082; Fri, 3 Jan 2025 19:00:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E6F0D6B0088; Fri, 3 Jan 2025 19:00:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0ED06B0089; Fri, 3 Jan 2025 19:00:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AE7576B0082 for ; Fri, 3 Jan 2025 19:00:54 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4F590140AED for ; Sat, 4 Jan 2025 00:00:54 +0000 (UTC) X-FDA: 82967813628.02.B0921EE Received: from mail114-240.sinamail.sina.com.cn (mail114-240.sinamail.sina.com.cn [218.30.114.240]) by imf03.hostedemail.com (Postfix) with ESMTP id F1B2D20005 for ; Sat, 4 Jan 2025 00:00:50 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of hdanton@sina.com designates 218.30.114.240 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735948852; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZPidpqXVYcGNjUuHXAmWbEtCflp1zX474t00ZDvIHNU=; b=o1nMx8Qh2lHGc+aqmjcd3G59ETNhFZ4LWr4NnjQHh1DeMHgdqDnaO07HnB1Q6RPQvbDov1 ZdIVcUKfvaPC6ZQRPemo38TB1TInVh2/a7oloRLDyUZm6GPF2YK65yvY5Vko6G0CYpsxrj BVurxNO364teaasUEqn599dhrUBO+Lk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735948852; a=rsa-sha256; cv=none; b=gEWPQt74MUxwqXBvhRYUf87YjWd5ryiOcbXyEKVr56DKRyshLiIlwasFpFybOuHRxWp74w i2YrQBSMn68uJtSf25hWpmpCHLv9uJR4Gp+aDjmi2kXWsuEJtQ6+nje8FBLPmvyPZ9Rgtz FROcFkXKDxvgt+CiTfEY9vnvmCslLdw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of hdanton@sina.com designates 218.30.114.240 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([113.88.50.58]) by sina.com (10.185.250.23) with ESMTP id 67787A2B00003212; Sat, 4 Jan 2025 08:00:46 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 5457368913392 X-SMAIL-UIID: 3FDCAF96B6FE48F9873ED17E530CF1E0-20250104-080046-1 From: Hillf Danton To: "Liam R. Howlett" Cc: syzbot , Vladimir Oltean , linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [mm?] INFO: rcu detected stall in mas_preallocate (2) Date: Sat, 4 Jan 2025 08:00:33 +0800 Message-ID: <20250104000035.1356-1-hdanton@sina.com> In-Reply-To: References: <6756b479.050a0220.a30f1.0196.GAE@google.com> <6777334a.050a0220.3a8527.0058.GAE@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: F1B2D20005 X-Stat-Signature: jo6xmd973awgae5q4eqm5oz9yjn4cea3 X-Rspam-User: X-HE-Tag: 1735948850-319654 X-HE-Meta: U2FsdGVkX18H8vQoc73Cc5xsdftlRPesM+w/wNHpuypxlxg75KI+Kv+rTBCxJhVlIH/jVqcJS5Mb7zRDWqSIgLkUXN4po9jEIidVugfvD1woHt+eO7/yZHBW0lyM27ONO58QSXd/T7tcq+U4SieyY6dy5D1Xytpk/giPNH/4zUMmqj6XmqDz86A4A2ifc0qRskEjijFDW6fZhc6MfhrwoTzSGkZ6mC6Hmap8uNCOtkgxlw9zEvSObaQhPUmZL99FSDEQUD1eKWf6onPPO28On4ggYKgd+AzgTI/gTAeMS2BZk6jzbf07G7JHHt6/hkrhNFEigcuHMbkSkDEQNu3L5/By/lsmrtJKwDWmYSxOpnVDs78bqbYw8eDRT1MdTbQb/dfBvfMyxoEasWzAmB7TcwZuCDkRd/YtQKiU85PXtuuxTBkZrhiXgvDy8t0HICv/Or6azAC5GFqh8wUHIBan4zacBj8E0j5Zhuu6YPwBWvIxr/7M+foQEZbRQaluonfb7dMtoqko/85NwNG/2xQ7S41CUOsgzxOiIhiUMxdF2EFGhoTdeovGEDqw6YKEy3zIjVakwTPRLBkFsVcE9KJxDwnWkC2agYU5W4Y2ip1uZLwaHrsmh8LiL6WHI6nZCAazX9b+CpOU/MTkZS3YqSQNxLOStLCPVYu6JT260gYNyMWovFMU+3tbNihFLthik0xHpjBhXnddnT4z8+LU/ZjQPatqeP3Cj7T2BAuuHOpG3k6KoHsMOsi3zpgBYqyIUOo8ezvulVFI/CjHoPzpw8PBId9zh8oOJH3iEgNkqUNuP1mUIhF2KLgdrGG1sOv7KLUUNSFHZhEADdTH2HxtW7G+C+T4qBwXYvtzXlQMt51MA8sQDZtnGbXQ2cYx9eM3T0CYrXrOjfqAzPvpB2beihsWOHhBWT+sUzKQYiEh2W5xpVtqa61skMbnzPmRoznRj4spQc4XwFQYaiDYqgWS0CB a3WQuft4 cKgoV4pRlBaqo3G6bC3zuHQrhJ5ivex8hLhMwDI6N6ziHDg9Kzzc7DZR7L7tRwRFoXXc6eraajw62Y/zcguGbFjG2QbBet+JWJmLz3sKXqMU1Ow2+K9WS7VmqQ9LbUmVeHnWK2WEb4vlD4MeCwtuaZfbwrHiHMB5TrYF5WoN2XehT3cNY7iCjuyQOoBDIykWb6z84yT0C7G+jAriy7QHqqLDDgt0TRXJuAFy3WwFWUKfCI+eOX3EvgQtDBpXf0V1RgoLWboK+yPoK07EWQdCnLPFeIguFrBmfS+cQnlzIJ4cOr42mfwmK86ChUXU9o44XjeaI+eoA83D6KL/iAra2hT/l56sRwAs2fABx2ovmgwIt4FjkEm+dYZd8seojTasDPLXTIBRFxOKf+R5i+kXJ6KMpaGTSOZC/9TCBjBPUaDcx77C/OYeXRKcoivw/o7Aza5uYuJGQ+2vlh/1cAgSnBHTAit/HCK12IuOo0t9CJ48nTECReOl8qvXe9vjiBgYu8sZSOOqTHJ9TizvQ5PPk0rZK2Te4ZANlHi+txf6TeN/vKWuofQDRTreCZspFziuXdOe2cDOnzytKwDBKmlyP+ZRMA/ETdeJcelqQSRqji12h6sInKpeuBSzSAxIc/fQ0OYNZMb3haS1cEOH1qpY4OJU9jBK5UuycUX2cm7YMDWOMABO1cEJpK6laReea1GPxaQb7s+pKzyDOSRXl88P+KhA/iL6mjO3DKJmLjnOPkGpONJE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 3 Jan 2025 10:20:34 -0500 "Liam R. Howlett" > * syzbot [250102 19:47]: > > syzbot has bisected this issue to: > > > > commit 5a781ccbd19e4664babcbe4b4ead7aa2b9283d22 > > Author: Vinicius Costa Gomes > > Date: Sat Sep 29 00:59:43 2018 +0000 > > > > tc: Add support for configuring the taprio scheduler > > > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=117df818580000 > > start commit: feffde684ac2 Merge tag 'for-6.13-rc1-tag' of git://git.ker.. > > git tree: upstream > > final oops: https://syzkaller.appspot.com/x/report.txt?x=137df818580000 > > console output: https://syzkaller.appspot.com/x/log.txt?x=157df818580000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=50c7a61469ce77e7 > > dashboard link: https://syzkaller.appspot.com/bug?extid=882589c97d51a9de68eb > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10e8a8df980000 > > > > Reported-by: syzbot+882589c97d51a9de68eb@syzkaller.appspotmail.com > > Fixes: 5a781ccbd19e ("tc: Add support for configuring the taprio scheduler") > > > > For information about bisection process see: https://goo.gl/tpsmEJ#bisection > > > > This looks wrong, if this is a bug (which looks like it is since it has > a syzbot reproducer?), then it's different than the previous two reports > and probably not related. > In case you missed it, take a look at https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fb66df20a720 > > Vinicius, > > Looking at the patch, it seems you missed some users of -1 vs > TAPRIO_ALL_GATES_OPEN in taprio_peek(). The comment in taprio_dequeue() > is useful - maybe the gate_mask rcu lock/unlock could be a function and > have that comment live in a static inline function? > > Thanks, > Liam