From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5269E77188 for ; Fri, 3 Jan 2025 13:02:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 189446B007B; Fri, 3 Jan 2025 08:02:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 138AA6B0082; Fri, 3 Jan 2025 08:02:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F41ED6B0083; Fri, 3 Jan 2025 08:02:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D96CD6B007B for ; Fri, 3 Jan 2025 08:02:22 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5285EC07E7 for ; Fri, 3 Jan 2025 13:02:22 +0000 (UTC) X-FDA: 82966152066.06.719569D Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf19.hostedemail.com (Postfix) with ESMTP id 1936D1A001F for ; Fri, 3 Jan 2025 13:01:25 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735909291; a=rsa-sha256; cv=none; b=YIPIVYb0RsTIyImjsn4gTl3urlsVPa57XG0e+3feZpImrfmUMAJvSclx5yzKo3jeJnlxd2 uUnscZPCbsrWf1hFRq/3stUvFjO40uSTO7fFOt6v7DNeXhsxlnbboV6USc4d9Uq/nDN32Z LdYD/yslyRPyxHuvAD24iBG2cY1pjAI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735909291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=feTmGPxFf69liAeK1nRN/Mx31jGFT9XrUKEVPKICnjU=; b=kf2xX3G7Qny3c2iRZ2aIf7Idfo52ueVeyoSdua/x2ksgQVZBo2L/DAFULfd5gSqUn7J3SK 8gvG0xyIWkm1Syv5rOi6V6UnNO82dbkGrNy6cHw+VISEG9Sz7fs1hYdWfauBL0RA4GhUwv QAfoyEhWAfQ5mRWi1LA838VuukHZnwc= Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YPkBp2Pl7z6K9L3; Fri, 3 Jan 2025 20:57:54 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id E3021140367; Fri, 3 Jan 2025 21:02:15 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 3 Jan 2025 14:02:14 +0100 Date: Fri, 3 Jan 2025 13:02:13 +0000 From: Jonathan Cameron To: Borislav Petkov CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v17 00/18] EDAC: Scrub: introduce generic EDAC RAS control feature driver + CXL/ACPI-RAS2 drivers Message-ID: <20250103130213.00006abd@huawei.com> In-Reply-To: <20250103114109.GAZ3fM1dEsyBSn9lWA@fat_crate.local> References: <20241122180416.1932-1-shiju.jose@huawei.com> <20250103114109.GAZ3fM1dEsyBSn9lWA@fat_crate.local> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100011.china.huawei.com (7.191.174.247) To frapeml500008.china.huawei.com (7.182.85.71) X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1936D1A001F X-Stat-Signature: iajingzmc4dq6cpwebiqpdzeej5gb6im X-Rspam-User: X-HE-Tag: 1735909285-570569 X-HE-Meta: U2FsdGVkX1+re/tSpB4zOkBl1PIuSIn3nDKH8ho0dwQx0fKqVufjearwe/0LfyooE+P5KEKIkciMnFQ8OjWzbrilW9OTnKLavr5Czf6SqKWqxYRrlYdS+jraMGEvG0ZPkYHiMDHNEq/0Fl6CZ2lN2pXGSVP2dGeqyj+WGThmMULKEGa/IaEFT/my96mAoC/lU/HFHSzXuwKAYFenqs5MGMUXtMrIKXcTTk5y4UeNsmJdqKb2koc8Q29hQ9YDXOLJg97/5d170c/VpVKSKdeaM5vvBnrg/3khWet/8IarK+6ldoGQS2AyKwc5Ure6Fg80IKhIuQKxtYdqqapOjSGYUWqLpjC6ejg96RRM8JB1GGfJ42RYP3j5+oz5IoqUOjL5kUrtr6/geFKrGj+gWit36AZVNqhr5zdI459wBTVwmVzjUZphE1MhwMfCsYpqfKrMKp4l+BGumPlM8gAh2/vq3n2QBgXUOR3Coy9U61HIHgUkeS//G3btonNVaRP9xiUDfRTj3rWzixjQMjZWB8892cm3bIUqrKD+1pnZ/v3eOWuOlBpM5F82dzSAXIs2Jt5CXTE3gu/TQIl3+9sWF/FmGWV7iE2Y7prQQihY0jt1tBLw3PVUiCNocizrPnHp3+XTRKGQGAYVJhepp5HnP61rG91o0dLLCR2ld9o2px3LfCZHhscyAM54uFLI23fGeqDsIZ74Wrl+2rg9uR/uzMkoc0HWG+0MjmzN9ro8D8W228T3bxX7rE7CwjDxTHzntOAtx5OmQ4dpfpR/YLklSHY72nlo4OJo+2Vw5VNAydZRdQl7dgpvMcc/0xawM9JsdLUEOGgah9riydyYo7wjlRRZGfFYKBbSMu6Y10lCyjjXxd9aWryjHnRDvUeoptYZtUenFX9DKNuTI2+zE55Hmns/rgcDqbiZdVgMAxOBMgHS03LddtQg8HViF/UEy+h8d1uHLGC3sg+XPZzgrROuUVo Fdg9tJ6P OjGnihNAi+kw21/l3nDIhTAEEajXrLUVNXS713RRynQ+eq/xOU8qIWP2vsYb2jeSGeiNeYwhTs4epno4eOKdsluHAb6KPB1syin7mkqk0Lg8GcVYDESn5qpmZjYbTtyH0kbSkjsOVqUqA5Ji7Yfmc8S5IH8zu41WRPpGjJPLveksTU/Gc4x7apwO0bBznSQLHdhGnbLjwRDeafJaTZO3KTkh6EcxB1QFJa2PE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 3 Jan 2025 12:41:45 +0100 Borislav Petkov wrote: > On Fri, Nov 22, 2024 at 06:03:57PM +0000, shiju.jose@huawei.com wrote: > > drivers/edac/Makefile | 1 + > > drivers/edac/ecs.c | 207 +++ > > drivers/edac/edac_device.c | 183 ++ > > drivers/edac/mem_repair.c | 492 +++++ > > drivers/edac/scrub.c | 209 +++ > > drivers/ras/Kconfig | 10 + > > drivers/ras/Makefile | 1 + > > drivers/ras/acpi_ras2.c | 385 ++++ > > include/acpi/ras2_acpi.h | 45 + > > include/cxl/features.h | 48 + > > include/cxl/mailbox.h | 45 +- > > include/linux/edac.h | 238 +++ > > include/uapi/linux/cxl_mem.h | 3 + > > So what's the plan here? Am I supposed to merge the EDAC/RAS bits through the > RAS tree and then give folks an immutable branch or how do we want to proceed > here? > Dave Jiang / Rafael, what would work best for the two of you? To me Boris' suggestion makes sense, particularly as that avoids the complexity of CXL get/set features being in multiple series. I think the split that would make sense is: EDAC immutable branch for: 1: EDAC: Add support for EDAC device features control 2: Add scrub control feature 3: EDAC: Add ECS control feature 15: EDAC: Add memory repair control feature ACPI merges EDAC immutable + 13: ACPI:RAS2: Add ACPI RAS2 driver 14: ras: mem: Add memory ACPI RAS2 driver CXL merges EDAC immutable + 4: cxl: Refactor user ioctl command path from mds to mailbox 5: cxl: Add Get Supported Features command for kernel usage 6: cxl/mbox: Add GET_FEATURE mailbox command 7: cxl: Add Get Feature command support for user submission 8: cxl/mbox: Add SET_FEATURE mailbox command 9: cxl: Add Set Feature command support for user submission 10: cxl: Add UUIDs for the CXL RAS features 11: cxl/memfeature: Add CXL memory device patrol scrub control feature 12: cxl/memfeature: Add CXL memory device ECS control feature 16: cxl/mbox: Add support for PERFORM_MAINTENANCE mailbox command 17: cxl/memfeature: Add CXL memory device soft PPR control feature 18: cxl/memfeature: Add CXL memory device memory sparing control feature That does mean that the actual drivers/edac/ specific drivers land via the ACPI and CXL trees only, but without another layer of immutable branches we can't avoid that. Might cause merge conflicts in Kconfig/Makefiles but otherwise shouldn't be too bad. There is going to be some noise in documentation as examples are added to the docs with the actual drivers (whereas generic docs are introduced with the infrastructure). I think that will work out though. Shiju, could you spin this ordering up and check it all works (incorporating Dave's updates to the GET / SET feature)? Thanks, Jonathan