From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F28EAE77188 for ; Fri, 3 Jan 2025 12:44:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5248A6B007B; Fri, 3 Jan 2025 07:44:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D4606B0082; Fri, 3 Jan 2025 07:44:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39B676B0083; Fri, 3 Jan 2025 07:44:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1B2CB6B007B for ; Fri, 3 Jan 2025 07:44:54 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C13C1A0180 for ; Fri, 3 Jan 2025 12:44:53 +0000 (UTC) X-FDA: 82966109604.14.18A5CFD Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf29.hostedemail.com (Postfix) with ESMTP id AA634120008 for ; Fri, 3 Jan 2025 12:43:38 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=aom6v8Qf; spf=pass (imf29.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735908256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SyDSwOqrq8wgbwDjK4ANOL+V725/oMvEKzRyHtC7kFA=; b=0J6Rf8q7dKlpyjwSJv/wsA86JyuEWNSonhlzKqxcYGcfnLatvsMQhL/l/yjuGEinTZlc/g QUzpJ27xx6ti3qmo560aDCJwTfNZGpC7111VJSBNK5+tnr7+jTZtB4THr7Cq9RtST25RKb Cl8rZfnuZzmyJNFFCTVQfYtFylIrq3g= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=aom6v8Qf; spf=pass (imf29.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735908256; a=rsa-sha256; cv=none; b=gOhulNR0f+Ko07Mugfl2JuRea/7N5+29GcNzY/3/29aAulr4Qb6aTMAYbnH9CFvcOh7Y/9 enP20pbTB5Dq5Z1Eh4ur3kudl2vkhkEqgUyV1X/Ha+WrjgkXA4lgkUCIDaWzwG5M2tTwMo akOtvY0EHCKK+D+jmengeaY2+nFn8MU= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id E09A440E021D; Fri, 3 Jan 2025 12:44:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 6OBLd1zaFhcp; Fri, 3 Jan 2025 12:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1735908286; bh=SyDSwOqrq8wgbwDjK4ANOL+V725/oMvEKzRyHtC7kFA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aom6v8QfkSz9TZrljJk0b1vUp7eK6D5rVgzehXAJZ+SF0e3NEehKt3L4IDAVxoJz3 /7UkM68bjZCE+djuLOa+TwvTcrBPhGKW0X6Rt4kfhua/+R8JQWwqzTUDkT3T+DsH3a /75BYAPlyvwEhUBxSK9P7QOD66LO0dcCFaLVMBZBtF7nxn2CBQIuI/J5QzGCiHu1cq zNxaLp5hWHB6hObbs/1dQlyNAj/9XdVh95M3T636L9iayc6FsMKO/WDhxLHa/MGUMD yGPRV8TSkLykN1qwmKJxvvPw2NRBonk5O9bx16nVKdBl7r0TqpgTp312UpRs0YmCIC 0hFC+vvMRFJ+xcDdru7lEM3iZOYkxTl6IzRGmpzj+sqL5coE3do9jHnxolaxrHK0BE 0+s5I6EjrwOPSa3hsMEvGuvhI1tyIgOq71GABConNU4A1RGVw2TdyjD7Dzfj9b6W7C Z+HlU/5Aipqi4VjXTqcv31k7+EYNdyHBdG3WjSI66SaK6alyGRWptbe/VtmD8mAT6K 23T/n6i/3Wt2G4ieuksni+PMglZPHrI+/b2OQ2kqEVVFlT0WelVyuZ1NoAhcBqXdLS NlPuODyplB3aXxVZ5dUlC8JT4PKsiFDme6zK/rwDi20gOzgCLiwMCC0IlVDYF91Xc9 A6tb2fA6VkB6N3FjYPo2Nuwo= Received: from zn.tnic (p200300Ea971F93bA329c23Fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971f:93ba:329c:23ff:fea6:a903]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4865040E01F9; Fri, 3 Jan 2025 12:44:32 +0000 (UTC) Date: Fri, 3 Jan 2025 13:44:31 +0100 From: Borislav Petkov To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org Subject: Re: [PATCH 05/12] x86/mm: add INVLPGB support code Message-ID: <20250103124431.GBZ3fbr-eRbl83G_Fm@fat_crate.local> References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-6-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241230175550.4046587-6-riel@surriel.com> X-Rspamd-Server: rspam05 X-Stat-Signature: o96akrx9c31ebnqqw7z81kc9cmsx5yob X-Rspamd-Queue-Id: AA634120008 X-Rspam-User: X-HE-Tag: 1735908218-724386 X-HE-Meta: U2FsdGVkX19RUh0g31wyh6M7AEbeMCr7ug+y4Tkk8Ac5qqBwnXWSA+WGZHH5pEEdVGEXGsU+R8zZ5xXgROxtGiVTZxbDRnsSaDTR4f22iPbtKwhg8inIGuwlJgCrFJvGFL8p5Dn939RcH5r55Y9UigynYzrvKCjngUAp3zFZxLbfTGHP8qfx4KCsApr/4xFoeO13SaOxXhsC85kDm+L06+6TyMmab/nI2L+yBOeLUAkfiDyoDJHx6boK6UWCKgLGmU2sEHyz0mdUq9HLwkDXU66oHyJSC5Q3ooG+wcqidFfX24zG1Cv4PbKCMJncuATuIuEoYYXBfR0JpechFuZ8fdILVm0Y2iPm34l4IrlNJkDkWBa1PF9dioWKF9gl3j3dLKxS3YrzMMeadzxFa/1zXVJuDGE93tGej4eHQ90hYmNaKhpptmvFbStQATF6TCG3Dhg5DntfLFutf+bU9UYZUbTrPJR81D3hMlSFyppStL7ze20NT8YkueNApunEfQ+se0lHNksRZfw38L6S+jcaPehfmszzVGAJnisbQvHjEs8N0zWfAZyemGkj7cRGAuxL7QHvxNxUjOyOa5cYImIYUz9HfofJjpR2M4a4AOlhIEYuDT5zTm4zpKY2jZtR8edowxGlPVDIt7+ear1A2f2F12Tz8u47YxvMcjxxpiyaBiG/coLiyz6Er0fXNbNzBxCQf4p54R6CmMn78NEkXZQyn/B0R9poVS7WEbrZ/JLSQ8DM70+mGJiMcsCqlyba4K5UtVlM1t4b3kHILpUhvfz/zPE1Vz/rFyKKMgI65zdkisZAPJsiQqAxxi7rWS/IqzW5luko4H0PiTmgBTRot7DvfIZ/3JF2FQrjE9+ouwHUwqn7DtTeKD5A2QKpnNfyARZQyCzoJyCNSCWU2yZd5AMUVRz9tRskoVS6gNrtE0ritnxth3HcAe9CDxdA9D5BezLym2aIefK1MA4OqP4IwJO hDJh5AUL Gft/sOIKRxa/Z34J1Y31xLPUkl4HjeSlbl5EIxMxO5XzWok7w9us6aDorEgqpNl0TUX/tHE9O3jjz2EIYxQMJu7UoxNETZ197rBDW6xLW5de8uHxNW5OSALrHxpHLF20ljb8pZYrewKiHer1ZdLQDX+EB0u8wwkgLn3v73F0VSa3otRf6wlEvN64iAyo82gM8LKRRdxUwGTv9J/gcKs+WaYyHDbDc7hWLJes2iKl9AvaZdMs5oY87WUfCJCH3VrwIcD4FExJ7cjiUphyHMEWE02ic3iUQjLeTo730tjfoJDW584JsaL4Fw19Y+EsLRFHXy5gW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 30, 2024 at 12:53:06PM -0500, Rik van Riel wrote: > +static inline void __invlpgb(unsigned long asid, unsigned long pcid, unsigned long addr, > + int extra_count, bool pmd_stride, unsigned long flags) That pmd_stride thing - the callers should supply a bool: true/false instead of 0/1 for more clarity at the call sites. > +{ > + u64 rax = addr | flags; > + u32 ecx = (pmd_stride << 31) | extra_count; You need to handle the case where extra_count becomes negative because callers supply nr=0 and you do "nr - 1" below and then you'll end up flushing 0b1111_1111_1111_1111 TLB entries. "ECX[15:0] contains a count of the number of sequential pages to invalidate in addition to the original virtual address, starting from the virtual address specified in rAX." > + u32 edx = (pcid << 16) | asid; > + > + asm volatile("invlpgb" : : "a" (rax), "c" (ecx), "d" (edx)); > +} -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette