From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85AD0E77188 for ; Fri, 3 Jan 2025 12:07:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF4256B007B; Fri, 3 Jan 2025 07:07:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA3ED6B0082; Fri, 3 Jan 2025 07:07:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B92E16B0083; Fri, 3 Jan 2025 07:07:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9C06A6B007B for ; Fri, 3 Jan 2025 07:07:53 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1294BC078B for ; Fri, 3 Jan 2025 12:07:53 +0000 (UTC) X-FDA: 82966015230.10.7E87A32 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf12.hostedemail.com (Postfix) with ESMTP id 377604000A for ; Fri, 3 Jan 2025 12:07:27 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735906017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sc+lIKXJdOjP6BreK7PxINV9vvZ9gU73QHgcgQZCyVw=; b=xw5PCc6ChphXK/ByRxUeZ9H4U1y/CtNbTXwFUnOvOka8jhP9pnDp4AodmgSKJojenQRWtb ZrU/6H2ymTUrrmaP3XcMqk7rZF68jZRsfxE+8vbHWjSFeMlbGCvrtFqz6wlULM8tl1OGVg A3LNSpttDmh8ODUNcEkxXgnSB7aBCQo= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735906017; a=rsa-sha256; cv=none; b=Q+W7tBRLCOrWr+DoWsyYB/5mZC1JGIkYR/qae/UZMtlofG1GepMM5AZ7rt6p85mM4JqiW8 DtMYUSKBnF9TAG/rzCTQQwF1KtZ/TUOSwzYYWGBjjasn6TnJGPG2o89v0qtRneid++yd55 aqYsUW4ycMDZUX9pC0b0xLOp7i87w7Y= Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YPj3y60NSz6K5wl; Fri, 3 Jan 2025 20:06:54 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 9FD80140C98; Fri, 3 Jan 2025 20:07:46 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 3 Jan 2025 13:07:45 +0100 Date: Fri, 3 Jan 2025 12:07:44 +0000 From: Jonathan Cameron To: Neeraj Kumar CC: , , , , , , Yicong Yang , Niyas Sait , , Vandana Salve , Davidlohr Bueso , Dave Jiang , Alison Schofield , Ira Weiny , Dan Williams , Alexander Shishkin , Peter Zijlstra , Ingo Molnar , "Arnaldo Carvalho de Melo" , Mark Rutland , Gregory Price , Huang Ying , Vishak G , Krishna Kanth Reddy , "Alok Rathore" , Subject: Re: [RFC PATCH 1/4] cxl: Register devices for CXL Hotness Monitoring Units (CHMU) Message-ID: <20250103120744.00006abc@huawei.com> In-Reply-To: <1983025922.01735899782509.JavaMail.epsvc@epcpadp2new> References: <20241121101845.1815660-1-Jonathan.Cameron@huawei.com> <20241121101845.1815660-2-Jonathan.Cameron@huawei.com> <1983025922.01735899782509.JavaMail.epsvc@epcpadp2new> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To frapeml500008.china.huawei.com (7.182.85.71) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 377604000A X-Rspam-User: X-Stat-Signature: 3j8ojpsr5ujujxmiaagjbe36w8fafs8s X-HE-Tag: 1735906047-951863 X-HE-Meta: U2FsdGVkX19NMm6IdZk6jZsYxw+tU6cqZWAoDbD++YkmNBjVyLbSI/wXHz4zO7R3Nu/1+sWHshG1Qzb5XQNRSdlZQFATy71f5hjQMIpxKR/shxdWnmvJGWgZUQuusJJPtwpz6mbalCzhoPBQI7sgdzuBT8RqqMT4RyFFc2MM2BXAVPaU7Hpax68m0Alg3p9AIAg8885Yyr/Sh+sh+jS7F24qT287+T4djVC1BbDLXJc33j7npWZnQ70KfB0OxaLfXuMs8dMEDzGvJH8s0R3dsBSaM39xzwMd8VsAgVnH6RN1u7Wmv4A2O3fXVOa7DBibnB7RWmFtc0CVoLnBECiJLFaMgrcLtFQBLUS0t+Aka/GBnU86HTRbrtoEx4oUJ/3Ik2yKRosDUNYZXt1GVyk19EvxOhbMv8bYLOdSWaXR9Nj97NIewj2ocG0/0aZ7o0yMOy0McguV1qLSLkSwLMUfMCUeGNJoZ+aDDkKvaF5Nc8jHWFTrU+0yrnyKCurlccni+/6CuZF9vKn5x91PxQu3pOA5QrBHS51bUsW1AN3rf5LPfRZCzs5pg+XTO8IKDiholE7jPv4tsLhkrzTSXmMT0/Mws5XFxFZYfE0BUbuOLAxsO+IfoO1RTWhZP+3RK9Di3J/ErUEs7xvDaJpzjc1EwnZY5XxYQyPq4OQe9e6s8sX8fTpz9voMFw+jaH0vAzQfrULzR/dfhCHdyV+YumMAHkIH2sLfafNLXDN/fwvFfibOPz2nu4LW5abKmoekhsE5at6zzEEACiC83FsWXmO38gaVdq9P329Iu3+ekaOSR4MXpXjUUeB7QZbUR9+CI4ffa3qyImeOFOoL+Yr0Pz7FqaHEEpZg9w/+HMPky7ZWfRdA6DxS8KB34GdJDHbBI7wMYitvKVY/MdnJqFRwbN58kyeMOOHtY6/MgGsbRznuHa03A3wOfz/qQSwm0K8GrKKHh098L1b5xOLIR6Ky65L mp0peKK+ N12BKfCBMv3AZdqieZLHtC1BiSqE3/yb1PYqrXWiV2EGjx15N+xwwkKrLXa9/U2dOkdu8tBy/2NhiOvMJY9HqKp4O/gO+c7UzVjg8EZGn6gJvBkjPKNDVSOmnD/t26RNp1ImN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > >diff --git a/drivers/cxl/hmu.h b/drivers/cxl/hmu.h > >new file mode 100644 > >index 000000000000..c4798ed9764b > >--- /dev/null > >+++ b/drivers/cxl/hmu.h > >@@ -0,0 +1,23 @@ > >+/* SPDX-License-Identifier: GPL-2.0-only */ > >+/* > >+ * Copyright(c) 2024 Huawei > >+ * CXL Specification rev 3.2 Setion 8.2.8 (CHMU Register Interface) > >+ */ > >+#ifndef CXL_HMU_H > >+#define CXL_HMU_H > >+#include > > No compilation errors even by removing this header. > I think this inclusion is not required. > Also found similar include at drivers/cxl/pmu.h Kernel generally follows include what you use principles to avoid future issues due to reorganization of headers etc. Here struct device definition is needed below so this header should be included. If there are other cases that do not do this, they should be fixed (there are ongoing efforts to clean this up btw by adding the missing includes). > > >+ > >+#define CXL_HMU_REGMAP_SIZE 0xe00 /* Table 8-32 CXL 3.0 specification */ > > Above Macro CXL_HMU_REGMAP_SIZE is not used, So we should remove it. > Its comment is also not appropriate Not sure on the comment being in appropriate but sure this define can go away (and the comment with it). Thanks for taking a look. Jonathan