From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D443E77188 for ; Thu, 2 Jan 2025 23:25:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C16096B007B; Thu, 2 Jan 2025 18:25:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC52E6B0082; Thu, 2 Jan 2025 18:25:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB40B6B0083; Thu, 2 Jan 2025 18:25:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8D7C86B007B for ; Thu, 2 Jan 2025 18:25:41 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0FF22AEE02 for ; Thu, 2 Jan 2025 23:25:41 +0000 (UTC) X-FDA: 82964095578.14.6638086 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 8BE3A14000A for ; Thu, 2 Jan 2025 23:25:04 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uttgSEl7; spf=pass (imf09.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735860304; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vKANJbqHBawECuGUkW5vehc82CRaO4Q0FhW7+9FyfLY=; b=3ic9Y+Tn2a6835JTJqjly1OqzppHw6F12HRoUQxtajxFT2q58lzMlQTBh3LShxgqL+hRTm g1DD/x9/LCn+yMET0atgicDtOXILKZabaWcEEL9kvjQb54ek8TvWAikRV5Z1413Ol0Mvx8 6qGspZ/QnCtR7n4WQyG7Fbu4bsRdqaI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uttgSEl7; spf=pass (imf09.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735860304; a=rsa-sha256; cv=none; b=zu1d0GWZL6KDtzzlNfMhZHVTXY+W29SEaa31IS6lZmfyMI7dD3acLbFG624ANCuAHlNw9T zfDM8V5ypw1qT0V7Ne3m+Y7/I8npo3eCdtcKRgcl4VnwDmCZgKQ+9J5qSym+L85RJkn6mp yq27TkwTO+IKe/EIJvl5IkB9mgAsdeE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F12815C6317; Thu, 2 Jan 2025 23:24:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0325C4CED7; Thu, 2 Jan 2025 23:25:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735860338; bh=mX7FJpx4118ooaZkB/8HWQSJOOPye7uU6pAwUySw0ws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uttgSEl7WvTBTYvBOym5lnIvpwq8txSb23qqFP27KtrOUAanmgGQ004iJ6FfHDtiM 0HD1sZbdxJ1CjrVZJAk3hX0kmJpVSYUJWKvUlgIh/pIzXsdOLEnXSj0XocPnFxSLFC 2w2ZnazfF61HEAyhIaGtJUglqSUU/5ytT9jA9FbMWljXfSX/r2Sme53K8Gm25wGDKZ p+PhosAjMCdJ6mi9wzLUSEBkMVFqhDm/Syc5n7SHg0DCE77CQBEDBWfEmCA8zZB0GT SqWGh/G3pPbtNNerhevUszf9B/G3jHro6J6GusdFeJxkFKp1fSRlObgBRUCknxnnsy rAnCT/TwJzsog== Date: Thu, 2 Jan 2025 15:25:36 -0800 From: "Darrick J. Wong" To: Andrew Morton Cc: Marco Nelissen , "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH] filemap: avoid truncating 64-bit offset to 32 bits Message-ID: <20250102232536.GW6174@frogsfrogsfrogs> References: <20250102190540.1356838-1-marco.nelissen@gmail.com> <20250102141015.bc8ef069a91cfd9664538494@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250102141015.bc8ef069a91cfd9664538494@linux-foundation.org> X-Rspamd-Server: rspam05 X-Stat-Signature: df7f1azkfnp1zo6ankc19txunyixgysz X-Rspamd-Queue-Id: 8BE3A14000A X-Rspam-User: X-HE-Tag: 1735860304-423909 X-HE-Meta: U2FsdGVkX1+4Wm+6MbB2xlWMa+razS2225yoV7m0mMTYrk0SPQQQbpa5pyb2uEw7Q9lNlYg0OJR70J61O94oHSGJMSFaknxzmPXihdLCEeHFJW2y/6GFcpIT6HiGtk1kUd7BBWg9gxZ+YT+i5h8aVoQ3Pfp3kKlqEEG6Ya6hgUjHwc6xnidjtZ2Pv1NU2rXEGOJRCblasT/2gsJlMsM9WPUIpliHArCixIrUczAElfehnDZYEDiH9DH+KH4y4yZGszyg7UsJ23/knVia3ydHA1CD0iQoBu2SeA+6hRf6NjUZpLNopYHnmnv+/Z8RXI7C1qevkDZXJv7LO68NjQQohsWE44TZL+QGPy9YaTmSsgcl641AIGzzkBxZdfFHQVWPcXtRzsNOBfi7zJg7ZSt/eArnpTyau3Fpkq8oCW/MxRyYm6teYm5hCW21KOqTjX3a3BTL2mB9cz3xrneNlPJb0Ylh0h1XKm43YmgqsrkkBu8aQGL9GNGenm30StS7mYbqlfCpDTm56WQjS1o2s9oYoT09dkPzKVzI5VducgtS8Y4ko5xgAVkdt3A58z6e5zh38bsDJC6L5Op+DIAjH58mCktlyT0Rtw/EY6igR6vcdtnxZ9r4ODBfdPZ7HPRuU0jx3mOMDE6w/dAq5t2CWQdlHRKaELzCAJYhgZUL1h0gOLC4uEFsw0ifMO9y5ezBziFBDr2bJjdUPEZ/xvgJMsNnF+SbuTPSoyMqq59mf7qnq4OsMdoi8tw6LsnCx3shEEUD8Q9WRn3h7sF8qAe07sPDFKIZHojDk01D77TxehzNI1/bGAM0IzjBcAdcoMOhTKlXVm3C47H1YVSv8NAwuUIfeFKRqP1HiinOaOQ/ZNIhzk/fbsPpLM76YXzEJqghelWPaqD6QqJ7CeD7KY5T9/2IBzwtv45Zv6rxGzU2UpQemImik3N5DlQUX+T1+duXVFwCZovK/FkwZGYVG9RpHLp p/wWcFSv VVEQwe2DwF+aQ8pqLY9T7rAMr0rPwSOmqcAf3yUBMqSOrywtogBmDbLSorBRsm8xGXnKmnOVz1s7v+aSuUV6WNl7Vh/OD8N4Z54HFGz7wvtUDuZS/v8/LTjaQmXAc92T8pnnc7CvRvw1si6hKCLO+7qOe82GDCTO428W0lsQzmw/dto4BJUY1NcGPVoDhOC/OVDZ9sFibhNh68LdFT91ZG3SfmwmRZIb6BWcmLZA6up7AIOG/U4HrV8XYp8jtWUEZlgqNqcbWrK5VBo2u995xNADqyWa41TFw+AwhBjTg0lCu1KG8QJMJ9n/t/1mbTKo4LxykYmXuSqqGsbxO2s75bmnrJTFptt0Qxmcxroa9d27jw4NiR2Igpq1nuA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 02, 2025 at 02:10:15PM -0800, Andrew Morton wrote: > On Thu, 2 Jan 2025 11:04:11 -0800 Marco Nelissen wrote: > > > on 32-bit kernels, folio_seek_hole_data() was inadvertently truncating a > > 64-bit value to 32 bits, leading to a possible infinite loop when writing > > to an xfs filesystem. > > > > ... > > > > +++ b/mm/filemap.c > > @@ -3005,7 +3005,7 @@ static inline loff_t folio_seek_hole_data(struct xa_state *xas, > > if (ops->is_partially_uptodate(folio, offset, bsz) == > > seek_data) > > break; > > - start = (start + bsz) & ~(bsz - 1); > > + start = (start + bsz) & ~((u64)bsz - 1); > > offset += bsz; > > } while (offset < folio_size(folio)); > > unlock: > > Thanks. I'll add > > Fixes: 54fa39ac2e00b ("iomap: use mapping_seek_hole_data") > Cc: > > The > > offset = offset_in_folio(folio, start) & ~(bsz - 1); > > a few lines earlier is worrisome. I wonder if we should simply make > `bsz' and `offset' have type u64 and sleep well at night. I think that callsite is ok because offset_in_folio() should never return a value larger than 2^31 ... right? IOWs, only the second case needs casting because @start is loff_t. --D