From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 221DFE7718B for ; Thu, 2 Jan 2025 12:15:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE8566B00BF; Thu, 2 Jan 2025 07:15:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A96886B00C0; Thu, 2 Jan 2025 07:15:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95FB06B00C1; Thu, 2 Jan 2025 07:15:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 770D76B00BF for ; Thu, 2 Jan 2025 07:15:39 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 04B2D1C834A for ; Thu, 2 Jan 2025 12:15:38 +0000 (UTC) X-FDA: 82962406128.12.955879F Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf01.hostedemail.com (Postfix) with ESMTP id CC10140012 for ; Thu, 2 Jan 2025 12:14:58 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=IPsWNjuw; spf=pass (imf01.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735820090; a=rsa-sha256; cv=none; b=j2Oe/4NOEiSUgXhgWIjcAn36Hem4jAE4zE08nwZJaU1tzxNp82ffTRwIwM44UvepH2AkFb DhfbHoQF2fse0fqMmgA8ocGO6hi09d5v0YtZLzY/MWR6TGgmSW1ik8CoY8bAdfgQHqQRUq OVEWwH4iTMyB7F2nkPvmlDx+HAbOCf8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=IPsWNjuw; spf=pass (imf01.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735820090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CaLTteEhzdppCEkqInPeT5ONkVHlRKbZKfcoLh4lZWs=; b=CFbOnkljsH5BjOkYswy7PJNvEsFdh/9+btvTEVq3DKU4rxih/EbF8qE000WL7eeYHRdM1D 6hj4ooGM5Z1v8Ikq8FPjrViNcTqw/9Z12pjgoVPKFFLdH3U6FWTbDgC1b3z4YY00W2TPJ+ z1Jw/1Yy7+sxVl4P/DJblU6fiGp9U3o= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id A63D940E0163; Thu, 2 Jan 2025 12:15:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id x54sy7ynYMxC; Thu, 2 Jan 2025 12:15:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1735820131; bh=CaLTteEhzdppCEkqInPeT5ONkVHlRKbZKfcoLh4lZWs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IPsWNjuwQlN0EvuwHl7BIZrELOLwE+GrOGIXOLKSwi0GomI5QwQFM9yKXuIdrSKHe lJJ5U4k1GEk2VUt2ND5zDQvlBntBdvQIIPO4+bqMHDqboh2HYwZdcEcgWWHNvO+/gU ckZ5Crit53CJ4izuj2alecvrlHZJAPBefSaoZBfFdbwLPkaGqgkmeexobkVUCK9fs5 ICrkp76xNs/lQeSG29Akly2YVQciduy4zm2gmvxoaOPQYbiSF1OquGLZm3cXZiXl5A UnBYL5JDq9E1riOMvrDVHzVYlu/lsLe6B2cDlVtZquGfo7TXCw8BvPA3LRH+8sYE0o cyjPj4duyeYrgfeYqGvLBKivlWSdVs+GEm5pu9L58sLwR2Zv6V6F68Q947Z0xuO4tE HQhTXk8N4+ArUIkYbZGnLZGh3CI59FI5OWqNdrpYFreDAzTwT1t/gRjO9NBusXHRPl GkEZSCEdBJfWR+TnPIvi1tZPtWkDmUlXXhkLX5BRgG38Vj2/0P01y02QmcwC35+aqh 7s0FjLC8t1IGkv4++scCu/LrkjmFkffOgkyevkrp/7m/Hx2AO7pe/E//gc9njlTouI C3hj82NlYIQVgwOBD1wpaNqXKt1Mbp2WGzm/UIa2S01k64pkY4c4FArYBuiIrDWy8x LvgzBtcaIOrUKslNFL/s7WRQ= Received: from zn.tnic (p200300ea971f9374329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971f:9374:329c:23ff:fea6:a903]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 5AC3A40E0289; Thu, 2 Jan 2025 12:15:17 +0000 (UTC) Date: Thu, 2 Jan 2025 13:15:11 +0100 From: Borislav Petkov To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org Subject: Re: [PATCH 04/12] x86/mm: get INVLPGB count max from CPUID Message-ID: <20250102121511.GOZ3aDTzdz2-Q_PkaX@fat_crate.local> References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-5-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241230175550.4046587-5-riel@surriel.com> X-Rspamd-Queue-Id: CC10140012 X-Stat-Signature: de331cfgq5ejiwkh4pa174i33ctiyrxa X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1735820098-490446 X-HE-Meta: U2FsdGVkX1/ynOQFq1ZiQEb9y8IuRwNC73gwWdwZbm6V4tksev8rJqdnNX5TFrugoJP49b4YU/BStqJHEXJRycKS/+kvZJs1Vo1D06Mf7Og4DzJYrXD7XTndwGN+dEMOL0ugAFBAMGxVyck06Sc7szTOCrIkUP8vp4DskfpXLzPAfWB51zbLJ7YzuCdv0Or89eW6brOniPNP4pMqHYhbk0WZdjEWRHmxhZ/DC5idl5yBEsTuYbCyzdN3I3/Obq/ConmfhwptL3VxF9+zlQ6FBpgrYFiDi9he1hn5QiRl/2aiHD9wamueVZXpa1LenCeSik7B8ahibCXlCZQjSfPiC0h1MbNIMMtj9U+UBBKsfdKDZioDHlvjaEseIHah2Y9btGcwKc246NIawiyrQ14DSIwVjJVQzi0qmVMbhuEz8xm17EYzLRIroI6ka0Z18pmmNX57ZclHWp4/yUhOpP+M1QD40eXxiWsY2iEyPKjy06yCo2ixMRsHv34zVLf+X3y0KBUkFXDEy0J5/HjTaneURBwGLdHN27mV0Fxun8wfrCVeGylO1JLNgtjE+ti0/m7Ui6jKKqOA9NiepuPnsjcVA0FmV57te086tsZAzVgLq92bQSJxEcLQ9mGFwQGdic5Bv4Jcywg1g4Ltzo+O+JtkA5ZeztAxVPnOcBuF5gzePwHxG3N5drpajPmFlHHu5tVGvTUCMgvY91cHB7eauIupDUyOltmWT3x2IUH2O9frIVc4YVGwIhM3pFYi1XFQkWnlEm5j59qegHQajpzj2V9kqbhEqCblzRgn8AK8g7qosxhzHILuTSiEhYOWQoRP8qU2Sq4ZFiJ/TP3iALRx+iR5O9Sn4w+1F4yZ2X6PqnwFthnFpF388otXVUX11HHfN8xLGjZ9nH+E5wJzKJjvo2CPClgDDadUl+oXAb7x7hdrknX/kPBPfxah7s8DPzIjGae5wAa176SevHxjzL0fHIS a+K0tcV2 SgufchIB7nJZLTOI+aRMzTIAh6EFUGIr5nRmmO4lrn3pLt4TQOoS/D2BugGbOii82Kr9KPDbvoo0h8D1UDpuji7egr7NTHIFAphK5yKwNvfCotIZ/hDXNjlAfYPv0AUhiaUQi+VAwre3bPj2nGVSJdK77Mu9QV/Kp/uU3LTX0ilGx0PWtXIuYFSdsXRjOf89i5G3rVq9ct+P7nCvR7Fz/RyKx+pxSa9v+OEoqBqkGUNSi8NIgUilKLaSB1+eHO7cCeKfSsncrsUKqxMNnt+GwuBS4kuv67q85oS2GmnOhQqgqGsji9IM7/bZsM0Yl+cXQu04w X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 30, 2024 at 12:53:05PM -0500, Rik van Riel wrote: > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > index f1fea506e20f..6c4d08f8f7b1 100644 > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -138,6 +138,10 @@ __visible unsigned long mmu_cr4_features __ro_after_init; > __visible unsigned long mmu_cr4_features __ro_after_init = X86_CR4_PAE; > #endif > > +#ifdef CONFIG_CPU_SUP_AMD > +u16 invlpgb_count_max __ro_after_init; > +#endif You can define this in amd.c and put the ifdeffery in the header. Something like: #ifdef CONFIG_CPU_SUP_AMD extern u16 invlpgb_count_max __ro_after_init; #else #define invlpgb_count_max 0 #endif or so and use it freely in the remaining places. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette