From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97B2EE7718B for ; Wed, 1 Jan 2025 16:16:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3C816B007B; Wed, 1 Jan 2025 11:16:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC5C96B0083; Wed, 1 Jan 2025 11:16:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3F406B0085; Wed, 1 Jan 2025 11:16:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A8E906B007B for ; Wed, 1 Jan 2025 11:16:03 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 21E22141326 for ; Wed, 1 Jan 2025 16:16:03 +0000 (UTC) X-FDA: 82959382632.06.45BE01E Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf08.hostedemail.com (Postfix) with ESMTP id 2DB12160011 for ; Wed, 1 Jan 2025 16:15:27 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="MV/FyKxx"; spf=pass (imf08.hostedemail.com: domain of kmanaouil.dev@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=kmanaouil.dev@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735748123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UoXaW/TDM9WJza7d2C+5/NwV4k2CCNIttmye4XqjrYo=; b=5t9Ulzf11tV9E7OjdncF2z49S2+04tDvdI0Iv5pd/XO0dHSYh+lgPAZahzFQMu6ItRaBwd ARSmfLCYwvba8F+R2SbyFguF1YIatDB1Akh4qO7aJE0/Q29u3SHxKtqg+oY4sWVqo5hno1 XFblW1qnXHr//a/MUjFTc97hfrInvDA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="MV/FyKxx"; spf=pass (imf08.hostedemail.com: domain of kmanaouil.dev@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=kmanaouil.dev@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735748123; a=rsa-sha256; cv=none; b=0n0/8ukEZ+nmumUEBqs3WJpfGn3TzW68yEWLpMsVirjxOLlCMQfnzLBRO41Q3mpe2Wqn8Y vAom1w1LxW1zliLCjv1MqGMUTrIv1L1Zfn+2bfukQWEhrSITWk80GQi2F5PlVlkgcyvnNw KMD6Hree0Gd0MSQ3reGvwF+BU/K1SRo= Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-38632b8ae71so7660217f8f.0 for ; Wed, 01 Jan 2025 08:16:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735748159; x=1736352959; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UoXaW/TDM9WJza7d2C+5/NwV4k2CCNIttmye4XqjrYo=; b=MV/FyKxxN69Btl6IPfa/KNZRi2NfaxyUx/hiewq3B0QVH9dHzJeS2888blNDh8rG7o juWbnT1Fb6G4XXDNQLLsHx+cYcxWMdxCAFe3Pd+4tKRU3tYtTxqLNE5f7oe5WJt956gk Rva7JLmDuMfir64PTpPDBFl52zszv1GAoTqmbCTFkZgCPnkAPJuWmPGEeWNBIuxoBibI MpZygfoOttzPkwiYZad99MJDB484dvwww1emDlyxZ4OhRvqmmtXBIzOp8ZrEOL+4Si68 ImVaZDJmjytHsRmyCzC4gbGjAFxPWVpx+c5LI2prDJrGvvZN7PMnv0w8KpAa6iSKkvxG 8jUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735748159; x=1736352959; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UoXaW/TDM9WJza7d2C+5/NwV4k2CCNIttmye4XqjrYo=; b=nxSJylFPFCR2X73K/t59Dr/IfvVs2ZV0LJED0HrhrVv4bpvEBNbFPAFHp2T0t85/v8 FwpcMloi8lcyhnBx9WmuXQyC1M1d0Sdp1tthYpYNuxtenU2ZKqGct1+ZVfUTt+8296vh H5zyj68dRhuIyLfgu5HposWvDHXEWpLSxDmxrMHQbs4IU5flbrCurewh97lrJ80UOMvE xvF4I3F5vFOjLvltOeJbQMgN5MHvCBz1NXTuMa/qQBDWh9D/8sL3RXFnTqHvA9d/Em6Z SAk/v8LnBlUsswdRxyFruFScgCJH0uuMocsXbRez//lI6Z/3bmRJDg6WCtN+9BGRM4k7 ReUw== X-Forwarded-Encrypted: i=1; AJvYcCXMFpmEZKI9r2ojs7rfac1i3ormRyeEqVrCFr0e3nSaxHhLVXNEvgO9KIWQErbDyUt5FjlLY5d/Rw==@kvack.org X-Gm-Message-State: AOJu0Yw7SP5264o6O+HfDDTRkyZfYpvKtfoxlT+O2whSuGK3386VEySR POV6qnXZowCyjnGocX4oKGhY0LXbgI7AayMbBvLR8JxWBHPovLV1 X-Gm-Gg: ASbGnctQw5Tk9OPiOLF48rhhyqVb405z968c53poUTSkrCW+kpr/wVMWnm3xC5PAyQv AVy5702ZeMZ7UIUyi+6o64J2nQV5VNtM1Pw4ssEVTC/gnzw5Dg1GwKJele0+yU9Vo37RZbo0lc0 G2sMOOPdyeBsur50tMJEDflu0+vg1EtFayQs8xhoDI2gmerujUPhay6ooyMnxhQtLwef/fs7J8L XChvcySWA00ywmp7roCMWCbypZReSt35wSJpC18Xft9JCgZW24yeSSHJLjvdj3YKUpXQUwEZFE7 bCUHO7KUMnkl+g== X-Google-Smtp-Source: AGHT+IEa5P+JcgT9rrO57PPLaKydMwgQFjI1NibO3DyfdgO+aEU4BXx3BSUTN13YvWCiwjQw3XPBSw== X-Received: by 2002:a05:6000:2c6:b0:386:857:cc54 with SMTP id ffacd0b85a97d-38a221e2d13mr35826074f8f.9.1735748159284; Wed, 01 Jan 2025 08:15:59 -0800 (PST) Received: from ed.ac.uk (vpn-fn-230.net.ed.ac.uk. [192.41.114.230]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8475cesm35543198f8f.57.2025.01.01.08.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jan 2025 08:15:58 -0800 (PST) Date: Wed, 1 Jan 2025 16:15:56 +0000 From: Karim Manaouil To: Nadav Amit Cc: Rik van Riel , the arch/x86 maintainers , Linux Kernel Mailing List , kernel-team@meta.com, Dave Hansen , luto@kernel.org, peterz@infradead.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Andrew Morton , zhengqi.arch@bytedance.com, "open list:MEMORY MANAGEMENT" Subject: Re: [PATCH 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes Message-ID: <20250101161556.lniuomixy75vmj5g@ed.ac.uk> References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-10-riel@surriel.com> <95b614577f5475a919c878d6906d721004c83584.camel@surriel.com> <24c9b4b6-e07b-4cee-aa7f-6f317a1b7ef6@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24c9b4b6-e07b-4cee-aa7f-6f317a1b7ef6@gmail.com> X-Rspamd-Queue-Id: 2DB12160011 X-Rspamd-Server: rspam12 X-Stat-Signature: 4jab3kdkwuae3wko3mzdg8cpxecuy3nh X-Rspam-User: X-HE-Tag: 1735748127-93223 X-HE-Meta: U2FsdGVkX18MJHnqR3I2OE6rKn+QjnsqhNMb83Cs8KiQAoC7p+714MeriqAjCnACobU5Bjfscmli5v7l2aKBm1VM9bxVdoWZTxuBzjJz4sxZTdZ/6jmafFYhpHZ92LWQi66/lyxG0xEkWFDz/OT7C+6niI5w5TffqMMLDTwkK8HTBY1OkNKcHKHxb5FO3ty3GJesUo4EBPS/ypJaSKWGNoLEza1XHug9UlhKrmsVhXwfAygImBywGImV9pNs/pV2kERPM4VZHbZ7jFcQrwneaA2KLt8PUUMDdBcR2ye3AZ5BdpCPcmMcHND71GFssBatqraEEEOcH0vsjKv0ivUgKnRlbCyuktuDh03Eqm/0Hpz9ZwIdO4+7LRG1gUKt+vND0JXFijI32fuRR1pjn9KFPZvvFhb7iqbhgZCOrX1st0Z2J3Aq8NsEHXS+cH2y3f6Ju5ztvQxYUu91X15tsQc08DTdzySDcEhGURn7/Br8iYGW97mpi2ZjvMXM71l+XBkctfh2t6Pu6WbNYoBU2qO0spnaECGmYERJ8f/44Nvy3RNMh7BQBctHDccivDatJ3e7TMCmw8Tbb3QNtVYBhJGGcn7BUqIg2gl8VbK912XSTjhIEGbMlahRU0qJgA3hsdz2NFYLpRHB2paFTpEm6teuZ6xfGRk4TW5qOp0IKJUU/GYRzC+d6axThMuDqLS2Rwy2CyJmdvbb+b9vS2WSMk+GABtxKXz+7MZDPPVBPkA15ZU7kbpCbtbpRiWvHPltF0PC2ruongV7DBo/P9tisjX43DamzBSw47Z3r/zssgZtswO6Lx25Tzyfom2jCV+MPnK1dL8+q+eObZcRYGDaxkv3urRBw1nXM+vc63OhRNyyZC8hOc0mSw6eobzoFtLEnQAnnO7lJIJF1fzk5OoXY5gnIswvexJQflYeJmj1jj26MZnsryUL9bpo/61xv3d87FP+oSFluXX6buVhsun56zI ujrLetNM cKZ8bEdVkoj8+KQkjcVlQwdc9yncFKzgwZnGJfBhHpIph1y23TU2RHUZh4Vx71u4hD0AudqX6XLk8O8ScpF6I/VzaGOTeVSYWxoR+niCULTNy2jmrFYMmtTTDXW1dgkztzlemC93dd/N6Ln6/7JPiG0HMKOu6+0xFd3n73rn+iQcpYEragDNY96QxoJNJM0Ox0+0vySp9qUSdRdQGrimCFVL4OAXFZSKA3iowvoebPRmFUQnh7m36cQfPvrTa14lhz3EdCTZ0XF9o7/t5JHY8ZRGFLohdhNPcDXEHrTCuOaubE6g3z5qlJ/BQdNDQwGI1p0ZA+W0gi4kLNANmnvQVt11h2nBJ8zaEvb195Qy0u8Q91JjXDQ5BMQE0svCFX0R5E3o7Qulp7ec8YvBoi3v24uy40OS2ERW2oqtFG6WeOF+N40ySoKijzsh/8wDutMM0KS0CbJ8LQTLREoU/feleOd1HlA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 01, 2025 at 05:20:01PM +0200, Nadav Amit wrote: > > > On 01/01/2025 6:42, Rik van Riel wrote: > > Fixed for the next version. > > Thanks Rik, > > Admittedly, I don't feel great about my overall last review - it mostly > focused on style and common BKMs. > > I still don't quite get the entire logic. To name one thing that I don't > understand: why do we need broadcast_asid_list and the complicated games of > syncing it with broadcast_asid_used. Why wouldn't broadcast_asid_used > suffice? If I uderstand correctly from Rik's patch, I think the list is needed to save the flush for only when we run out of the ASID space (wrap around). Without the list, whenever the ASID bit is cleared, you also have to flush the TLBs. > > > -- Best, Karim Edinburgh University