From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0A0DE7717F for ; Tue, 10 Dec 2024 09:39:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1804E6B015D; Tue, 10 Dec 2024 04:39:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BB346B015E; Tue, 10 Dec 2024 04:39:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E76C06B015F; Tue, 10 Dec 2024 04:39:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C76A66B015D for ; Tue, 10 Dec 2024 04:39:53 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4A1E6A06F7 for ; Tue, 10 Dec 2024 09:39:53 +0000 (UTC) X-FDA: 82878552036.12.1B50E1F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id C0A36C0003 for ; Tue, 10 Dec 2024 09:39:27 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=C5k6jApf; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733823567; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D+Uv+Vx+HF9E4YKbYyzkXKDBdKz+8OHhAuKZnqmZkRo=; b=PIkUOwfvtiIlt8PGNEomg/9Xabwd4qlMiSGpjovGfbWRuiaLuGV+ndK9pf32/hImccYSJv X5ohavAgpaSy/HAEMUrAi4hD4t++Fd5qVo9zAucLTSsKcaVuG/0g2WlYyO7pdDq8cI3fRl FJXUUW1ShyYBxXk2aPi7ssgkSHyVdQs= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=C5k6jApf; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733823567; a=rsa-sha256; cv=none; b=vvzO0VfNhAKWbU+paM09+s7O5SuTTSY/KbOfQmnSUKE/OLKjdj++3vnvpxcE9cE1jdOBQk LrVgp45icApFDG/WC3c93qrx2+rvDPKYJ1cfjobjp5+Ma/HNXY0AChTMobQ1gTijskUfQg InWtZNLYUTY0hvRTU+AZQVZYOOBbl+Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733823590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=D+Uv+Vx+HF9E4YKbYyzkXKDBdKz+8OHhAuKZnqmZkRo=; b=C5k6jApfHHXRGvwk0N38F4EYeHptqBCxKCxP0Ukt7gmYIuQvBqhuWmTAdhmxGzN3nJYB1Z DP0v5AZT5O4IhkCeJbwIi5S6NTtMZfVQHE1LehHcjF1MnsfDiFCL6Bb/PdGqVorgPTU06F DmNaQGHX4UxbPzCEGS7Kt87A9pyvWUI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-48-F2XOjYg6MNqtjAMZwcKavA-1; Tue, 10 Dec 2024 04:39:48 -0500 X-MC-Unique: F2XOjYg6MNqtjAMZwcKavA-1 X-Mimecast-MFC-AGG-ID: F2XOjYg6MNqtjAMZwcKavA Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-385ed79291eso3140254f8f.0 for ; Tue, 10 Dec 2024 01:39:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823588; x=1734428388; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=D+Uv+Vx+HF9E4YKbYyzkXKDBdKz+8OHhAuKZnqmZkRo=; b=AH3rRPdiiMYWitxzjaVoe4UEQq4IfDlHzcrWKlostA7fN11hokWXcme4xSUEQChWFC 7euIL5nQgk5fb6j94//+jAx3iKjVQLOGQC2KK5f9lI+njaBIbcjlEZC75L7bG9bjO40Z ERcLaY9Q0y3roUVXzciwkU4YKmp257sheGqIJmahNuUvD+HGMcEp4RnYmtAJmuQreAPM PH/79dtHcuKeOrrYXXHQiaVub5RUKuFaEOc/uTrBCWy/Y2NLXJnu9NL7doJq9KbGbojL g45pdsdaGN//VqVE2dHbL/OAv0adICY38C6ZNGCcGKTuWEuO0zJcgWizw9DUoiZglajy Vjsw== X-Gm-Message-State: AOJu0YwUPtfPbp9saYom/7yom9E/MNJuHNd1ONyCWeP7pxY3UE3xvpsG p4QXaBxQnYc/7T5ad4Ta6JCRkTLuVwjL80bK2s4Vn2uaEYEfzUZDALFHq5p+74zUEs3tH6t0jKs QNUnnDAFKy0nJllQS9ItH18z6wdTYmh71MmQqtkhhU0BQrMvV X-Gm-Gg: ASbGnct1ZfPUufbCuFnA/uLHKPBERqfezYDCWlInhYubDPriCszfdMNBnHO0VK3FnbP z+jiILek/9HOlUNvLgDsJ/c1gqeX/f21tcPIkGjNIHUp8ZnMRz/Ws1JJEebQYu6xizlhftvvqb3 ejEwqLIrlTh65xshQ5uuHuwCoaJTD9m/G1KCFFMxBa7l5cSQ///E7Kor2usUgXgLRpoalooB9Xy DgZMcK6a36IQT1SO0Qucm+xlh8rb8RUTePR4lRxJx1o88i5ychgNZWVl1J+uKaNpVQ1XkfHma5o Vjtem7GGSpLbAC7OgwibYqujL9b0WqYnFpgomqRIblhk924JJCxdoMGOZL28KnRCAJptGjABP3L hSwFGIw== X-Received: by 2002:a05:6000:2a6:b0:385:fb40:e571 with SMTP id ffacd0b85a97d-386469a101emr1907185f8f.6.1733823587726; Tue, 10 Dec 2024 01:39:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IHTTdWJ3zb1Zjed1HWrG58HyaLWoY79cx2Ofjk54fKEID4esdsAEmYKqs55zCa1MDZw1GjV1Q== X-Received: by 2002:a05:6000:2a6:b0:385:fb40:e571 with SMTP id ffacd0b85a97d-386469a101emr1907158f8f.6.1733823587384; Tue, 10 Dec 2024 01:39:47 -0800 (PST) Received: from ?IPV6:2003:cb:c723:b800:9a60:4b46:49f9:87f3? (p200300cbc723b8009a604b4649f987f3.dip0.t-ipconnect.de. [2003:cb:c723:b800:9a60:4b46:49f9:87f3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3862d7158c4sm12336389f8f.54.2024.12.10.01.39.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Dec 2024 01:39:46 -0800 (PST) Message-ID: <20245acc-1d2e-4166-ab78-6b1614d4e47c@redhat.com> Date: Tue, 10 Dec 2024 10:39:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] mm/page_alloc: conditionally split > pageblock_order pages in free_one_page() and move_freepages_block_isolate() To: Vlastimil Babka , linux-kernel@vger.kernel.org, Johannes Weiner Cc: linux-mm@kvack.org, Andrew Morton , Zi Yan , Yu Zhao References: <20241206095951.98007-1-david@redhat.com> <20241206095951.98007-2-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qmvNQ-1-ckL4WMVUTRhZ27kRQ1t5jD5m_flqDUyvkos_1733823588 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C0A36C0003 X-Rspam-User: X-Stat-Signature: tom4nacmzp3gibz98dghhygfw47kfout X-HE-Tag: 1733823567-977709 X-HE-Meta: U2FsdGVkX1/NiV9kdnY+rpUZueZUvvu79qojC9fBFSAL/JiQBx8b74fpwxZuVCn+yEJP6EaGIkKOqyqLoCwr/4COBihuYbFfEIdP2rbI6Ge09qKnsKAId7a+Iqx07GXIKyvF8LfOQHWg0U/Yea7Qo0Z8IJmhxHrLzMkiMLdYdgz6dBaMWJ/0eqO49WR1bBaysz4m5ZcQn5FyTYdqEeeiO5qwJCV1GPmpv8Wu39/cDD0p1+SoYLc/xuDwGJMYz4i8L1Wn/TQO0St09esDgykAgCFnYpSA06xg/PR1O/bF/YrHM4/hSqzaq0QCF3xVVNn+Dv56tA0NOVrpjx5SBQj6ofwTJyQrBxiw2fiqcRYHjBWJbycXxqjbuX/utIZzSDTJXQjCXCBEvKfUF+k8BB8IseDZYIMWbClWWCSa3Xl816pA99DS1MaVHVEVRbIz9ROpG/tF1OkPu8TGL6c77mEuooA/K334XLrqZugbJSnxXuZgaxsvm1N/KNYgzVe2DONWBKEZwlK0TarirzI54AsmoaUTlHOVfI/YTbrQehfAi7BVnfLk7c+DOLoO3warH7lnDafhswVom+g6xMA8etDzHtR+NzTBkTLaargiZ3OHlw2+gFYaVSelXh1124ubhtrWksWcxufvr1yJXJKuxaPixYuyLHNBKKiXf2Lo63zLxlEgeeYsZSA8ON0AL2iNJehVWoLbrj+JmIVzSbuiJ0amn5XzCgMIVmiKcYqx8Rr9IJXHGGnyxR5/qqxjILiEo8kS4GPfaEPEmOwquRyLjJ6YBylh9GvxOUb9u11RnBjk1UjjY1wEhil3QsZE/EwH8jN70H4+869puKOJZepSkoIDs2Ofg+Qqvg6qp8nt5vY9VDnKDeUwIVjG31gZUc5v1pHIdmCmWSSqV53hA5l0tZq59+621ED/BRoVVJ3iM2rH0rNxB+yQUwiJnFD+OHqMOlNqCn4zSipMgN5XgS4i/o5 7J8aYoWQ 9omNsM7/85ZiIb5r/T2uHBP3QQmIRF4wqUmXAc1wFBoOZs1lfiDNyhRW6THvxijoz9Fsv1ea4qV5I6ubu4J9r9eYdcSUY3mU1UhXQxoawDc1ziMAs6vu5ltA3BpXW7fdFhmDNZDksmXPRXLrSfX/7Hn1p+9knTms6+ifu/w0BV3N+GqUgUEJsJxjvtI6y0FBSy+8y6KRESGhd8yFBqXIOqNbTE74DkNkIHfFODfs7ZIQNcawMcnhLsx2vyTbcjHyJNHTAz06unDfeQ/uQfax4qY3q0+LZCULNsmdH/vCgKg+RWvkAOrVbLnSUsspev0DlFurbvAXrmM9ZPZ3R7bXtBmVSH5TVhOnOLCDIgny1ITfeobj3saZtuZZu7oS2Y6u7/roqLIlhxA91xFirtvY4o7pwkHpSe4wvEoXFcMaA3QU4clhFhYlA3rK+JIX7s3s8Onvt9zsZJT4v6Ajflig5BoFKbvnrrFtuXRW4WtAU7u3e2dNYxzSSevGQBw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000061, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.12.24 20:01, Vlastimil Babka wrote: > On 12/6/24 10:59, David Hildenbrand wrote: >> Let's special-case for the common scenarios that: >> >> (a) We are freeing pages <= pageblock_order >> (b) We are freeing a page <= MAX_PAGE_ORDER and all pageblocks match >> (especially, no mixture of isolated and non-isolated pageblocks) > > Well in many of those cases we could also just adjust the pageblocks... But > perhaps they indeed shouldn't differ in the first place, unless there's an > isolation attempt. Thanks for the review and finding that one flaw. Yes, I agree: usually we expect this to only happen with isolated pageblocks. At least in the scenarios I have in mind (boot, hotplug, alloc_contig_range()), we should only ever have a mixture of isolated and !isolated. Maybe one could even special case on zone->nr_isolate_pageblock: if 0, just assume all pageblocks are the equal. I'll look into some details and might send a follow-up patch. -- Cheers, David / dhildenb