From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1ADEE7718F for ; Tue, 31 Dec 2024 03:08:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2EDC6B007B; Mon, 30 Dec 2024 22:08:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DEEA6B0082; Mon, 30 Dec 2024 22:08:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A6026B0083; Mon, 30 Dec 2024 22:08:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6C0476B007B for ; Mon, 30 Dec 2024 22:08:35 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DEFEAC094E for ; Tue, 31 Dec 2024 03:08:34 +0000 (UTC) X-FDA: 82953770340.18.85EA753 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf16.hostedemail.com (Postfix) with ESMTP id 117DA180008 for ; Tue, 31 Dec 2024 03:07:43 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735614491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6hquwO7rNACS1fzd5jpOK3hfHXRablVSBllo5wslwhI=; b=4esRg3JkoUVjENvTYz2D2tL/iYVU703uhrL/ZmykZ/N2nN3XwfnhWj5qkfQs3DuIcjJ7aW JzK3pZ6nwVfolYrPj42Xm6mHFBKZFjbrO5JHQN3fFUlMWmrjRfgt8FcSd1sddOGbGQYqxe dyO4OLdB49Yu2u8CGUafFaRZBD3Tpf8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735614491; a=rsa-sha256; cv=none; b=fMSHDckYRRUL1cJ1WY9uFyIK0hYoCL4/jq/d3e6wAoQcjvz0JlIS5xwSS5yhd2dWgm6uBE g3NG0j520Eq3lLKvLCf0iUs03h9TpQN+5woqnrpZYNqPrl3gpYYgzujW027ybkNLt5cdZ6 EB+rPEs4V5RuMy8aZuiQJQCHWFK23tQ= X-AuditID: a67dfc5b-3c9ff7000001d7ae-bc-6773602b098a From: Honggyu Kim To: Andrew Morton Cc: kernel_team@skhynix.com, 42.hyeyoo@gmail.com, "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Hyeonggon Yoo , Yunjeong Mun , Gregory Price , Andi Kleen Subject: Re: [PATCH] mm/mempolicy: count MPOL_WEIGHTED_INTERLEAVE to "interleave_hit" Date: Tue, 31 Dec 2024 12:08:10 +0900 Message-ID: <20241231030815.689-1-honggyu.kim@sk.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <50f2f968-df8f-4067-8e19-4d1e5b8cbbfb@sk.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFLMWRmVeSWpSXmKPExsXC9ZZnoa5OQnG6Qe8XFouJPQYWxydYWsxZ v4bN4ufd4+wWl3fNYbO4t+Y/qwObx85Zd9k9utsus3ts+jSJ3ePEjN8sHvNOBnp83iQXwBbF ZZOSmpNZllqkb5fAlfH2i3bBMaGK7RMeMDUwdvF3MXJySAiYSGx81MPcxcgBZrc+4gEJswmo SVx5OYkJxBYR0JVY9XwXM4jNLLCNSaJxtwiILSwQKrHi2CYWkFYWAVWJv5PlQMK8AqYSN6dv Y4aYrinxePtPdhCbU8BK4vvuv4wgtpAAj8SrDfsZIeoFJU7OfMICMV5eonnrbKBeLqDeFWwS Gxpvs0EMkpQ4uOIGywRG/llIemYh6VnAyLSKUSgzryw3MTPHRC+jMi+zQi85P3cTIzBEl9X+ id7B+OlC8CFGAQ5GJR5eh+6idCHWxLLiytxDjBIczEoivOeSCtKFeFMSK6tSi/Lji0pzUosP MUpzsCiJ8xp9K08REkhPLEnNTk0tSC2CyTJxcEo1MJZtbf8bf3f2vtdH1tXeOHDl/7RUD8mi ZR4Jwfoq+ccm7a00y5Zu8jV6aSj+t2G/7b/MuyEzkuLaHzH+enLvz5E+VzvPieftdaI759Xq JRQqFLm3yzMp2cbxZn+9s+RfcUsBN8s2pkX9d9fGdMt+uT7rktaa5q9vT0a8D0rcq+Wycd5r pmmiTEosxRmJhlrMRcWJAEL8cRxNAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHLMWRmVeSWpSXmKPExsXCNUNLT1c7oTjd4NoVQ4uJPQYWxydYWsxZ v4bN4ufd4+wWM9cmWRyee5LV4vKuOWwW99b8Z7X4vW0FmwOnx85Zd9k9utsus3ts+jSJ3ePE jN8sHvNOBnp8u+3hsfjFByaPz5vkAjiiuGxSUnMyy1KL9O0SuDLeftEuOCZUsX3CA6YGxi7+ LkYODgkBE4nWRzxdjJwcbAJqEldeTmICsUUEdCVWPd/FDGIzC2xjkmjcLQJiCwuESqw4tokF pJVFQFXi72Q5kDCvgKnEzenbwMolBDQlHm//yQ5icwpYSXzf/ZcRxBYS4JF4tWE/I0S9oMTJ mU9YIMbLSzRvnc08gZFnFpLULCSpBYxMqxhFMvPKchMzc0z1irMzKvMyK/SS83M3MQJDcVnt n4k7GL9cdj/EKMDBqMTD69BdlC7EmlhWXJl7iFGCg1lJhPdcUkG6EG9KYmVValF+fFFpTmrx IUZpDhYlcV6v8NQEIYH0xJLU7NTUgtQimCwTB6dUA2OQvXtt8pRLE73SQpM+T98THMXM17ZT yc583rqQjuieI6Fnzlz8J/f08m7BZfetZnlV55g5H2jrWdS7Q25Jmagce1+2mXdF9l8zy3rx h733nf9L2kpfqn525MylK8d+Ct5mSJpVJrBlAW+WyqzFb7fOfOrd8eSzuKqn7fwPRb+qlvWm ZMrmGyixFGckGmoxFxUnAgAHf7/yQQIAAA== X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 117DA180008 X-Stat-Signature: q6w3hamuazprxykooj6nqoaee3c9kg63 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1735614463-41009 X-HE-Meta: U2FsdGVkX18kBBofKZVX+/wr2mI5dZdGDY66uiIiqO7gtKLcC1CiZEdEzv/jehuoCjxGMwFzZvWkbsu4Um/EYkAL0Va2+7TzRER15OgkY6Ou0Bc8zyvRsNg8Pb42y1KuBbCrkyCQWbAEkSRFdWNaKAfbenZRAeexcdryTy7VxecP1/FepwyXbpLEct1lxjXCi7V/0Ne5enO3Yg3y6ATvcwCOTE2YwpwKvJ5k8yO3aClyMTUSoB4M+Ky92oDGJoZoKsL2BImK7is/wJ8EZo8jBEBr2ig4NavrEyzUsbRfE4tgC9hdLoZ2HC/7X/Oco0L2RIN98Q3qkFZuXSg4ciMqc+bKBbNGzONysQvhfdy4PtNepzkcK+ODuTzXEVwEjdzC4p8GayCW6vFavIZdo7cdcWYnQKdefomfWJyjToYhd9l5insArF68QU38eYxKEz6t0yFVPZisdCRCpdlAH5Il5dOrmWOMo966VTIGSggI1yooijKB17/UgRlJo9WkLoWmGqI9v/pT9OQBs/kRlKAVCN3iJfozVgrBpJPNodhen1rGhj5lkPpKyTShZK6tsbmKdvzzfCEK6iHO2x5GHwoijsweSWzhjzEm1pQtWTvWD0BR7yEfglZaoj2vi16AXYo23/HOCwetFPOWssz/qaFSkqVBDV2z2Gae0yYbiq/+uvMvER2QBxBbuymbMKlTskt1ohFlCRadQIoA+cTUdfe7TXB6hplCDzewFVYPBQxxX7kfYF4QDPi0JQQbY7wsl2VB8iK/Lx6k3VSImw2NONSv77dvYnUT9dLsA35+cIdQrtwb4nSKnh1+bkxrZHnhbjVWYP8ovc2VFG2jHj+aWbEdwJGlc3ZaS5ULEHuyfsj0go8Sd2RCzxioHjkcRKIXuFWoisBEUDBq0V0A6njgg1FnCyuNiLUf+WfKZ+rKlWLkfH+eRODZRNw6jMMYoj7VRPOblveECyCwcqdeU+eQ54l ycq3VvsS WzL34SJr1FPejd1Bdnp+shi+6rVXC0My5+biqhSOfTIwHwtUFAldfEVr9MLStIK8QJG4/pXSqJiLZhg4ol4+qX3deNGMHRdzF74JGHUesMA7eusnHcNPp4di0lTctpn+xBLlsIpk00ovnP3h52HYC3QLJ5yp8krAw1r7YXi7iHpuRxWshl3jjVpJosLGmq5LlWx9OeCF+GcU0tLYJNJMaFAVMFT0vndJ5NOw0vmgJgL/QUFEaja8X6cGLYfOyoZ3EQTtNPEGHrswkidyBKiHsDQcKcJNa8KYK2ev7K+rK4IgrmoJ1c8So4h9ZgvnUrMssC+eA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 30 Dec 2024 10:22:24 +0900 Hyeonggon Yoo wrote: > > > On 2024-12-27 6:57 AM, Honggyu Kim wrote: > > The fa3bea4e1f82 introduced MPOL_WEIGHTED_INTERLEAVE but it missed > > adding its counter to "interleave_hit" of numastat, which is located at > > /sys/devices/system/node/nodeN/ directory. > > > > It'd be better to add weighted interleving counter info to the existing > > "interleave_hit" instead of introducing a new counter > > "weighted_interleave_hit". > > > > Fixes: fa3bea4e1f82 ("mm/mempolicy: introduce MPOL_WEIGHTED_INTERLEAVE for weighted interleaving") > > Cc: Gregory Price > > Cc: Andi Kleen > > Signed-off-by: Honggyu Kim > > --- > > mm/mempolicy.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > > index 04f35659717a..162407fbf2bc 100644 > > --- a/mm/mempolicy.c > > +++ b/mm/mempolicy.c > > @@ -2268,7 +2268,8 @@ struct page *alloc_pages_mpol_noprof(gfp_t gfp, unsigned int order, > > > > page = __alloc_pages_noprof(gfp, order, nid, nodemask); > > > > - if (unlikely(pol->mode == MPOL_INTERLEAVE) && page) { > > + if (unlikely(pol->mode == MPOL_INTERLEAVE || > > + pol->mode == MPOL_WEIGHTED_INTERLEAVE) && page) { > > /* skip NUMA_INTERLEAVE_HIT update if numa stats is disabled */ > > if (static_branch_likely(&vm_numa_stat_key) && > > page_to_nid(page) == nid) { > > > > base-commit: 4bbf9020becbfd8fc2c3da790855b7042fad455b > > [+Cc Andrew] > > Looks good to me, > Reviewed-by: Hyeonggon Yoo > > We discovered that interleave_hit is not correctly accounted > while testing MPOL_WEIGHTED_INTERLEAVE on libnuma and this patch > fixes the issue. > > Tested-by: Yunjeong Mun > > For reference: > https://github.com/numactl/numactl/pull/238#issuecomment-2563532910 Hi Andrew, I saw this patch has been merged into mm-unstable only with Gregory's Reviewed-by tag. https://lore.kernel.org/mm-commits/20241231002913.D5122C4CED0@smtp.kernel.org But this patch is contributed by Hyeonggon and Yunjeong together for their review and testing so please add their tags above in the commit message together. Thanks, Honggyu > -- > Hyeonggon >