From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6730E77188 for ; Mon, 30 Dec 2024 18:28:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C1C76B009E; Mon, 30 Dec 2024 13:28:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7710E6B00A1; Mon, 30 Dec 2024 13:28:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6123E6B00A3; Mon, 30 Dec 2024 13:28:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EEC066B009E for ; Mon, 30 Dec 2024 13:28:20 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3D657161A37 for ; Mon, 30 Dec 2024 18:28:20 +0000 (UTC) X-FDA: 82952457042.20.CA558FE Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf23.hostedemail.com (Postfix) with ESMTP id 56B7A140006 for ; Mon, 30 Dec 2024 18:27:47 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=e34qp0hX; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735583276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hL1rgyIQSCoillYTBxVGuIpBBwf2vvhYnZKllR4yA8Y=; b=K7kz1+XZ8tuKcFasztU8TEyI1yQlb3qjXCdVqIxZ3SlUTKYWNHnFPInGZkBmwfGthCdf7Q ZRgTvc5YA5Qb02u7/RXsZSNACcVFsKiyEzppQvHhm+pzK/kRjVG5UhX4lrfs502o3iYp9J +QxqHU8+eiTroxuCVPExbGyWFNlxIZ8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735583276; a=rsa-sha256; cv=none; b=jOJuO5nEkFvGCIitlpLdeOR2CyRQkTkGOJprFuq2Qfso8e/vPflL9VavM2UKrc4wiLvCkr VKaccram1YK4+1tF52M9zRExkLG2E+1K9SeYw/6soNgkFGaj3e6ldGinmuwzYWPzONo7PF E8WYzOs2kOV1jnBHllXeJ6QZKAkAcgc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=e34qp0hX; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 675B6A40210; Mon, 30 Dec 2024 18:26:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D0D5C4CED0; Mon, 30 Dec 2024 18:28:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735583297; bh=U2YpTtqlCJIY1bpxAmY0gX8HWkNJ4GZ9RZ6Wnr2pBBc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e34qp0hX5lnvN/wVs+id/n6r9AiG2VCg45VWhm1BcpdQd/vLIxiY1Mv3uzrSuGkmw 8fvpclyNSbvfoVwqnIPRtj+KJWp1VMCDBP9jpouSqaKqXd+bVj+gbArNNndU2LJc5c GNm0dhmDfKCUQcCZz8dhkOVHss+WijkVdeK6d7Uk1PQr/GZweh72KDOH9l4SLTNgil 0YNX0bUTN/nlJPeCbKuAE6nR45N2tnVCZgvfRrP3zCJq36TafhaRGJFP/Cj7TrwrCQ jAcUvyOU/C+1wnhw3f9qUuGRFT70rLTPZkX1cM8OJqZA7CjrRcjjLDuW+eQSoKna0s EpI+y4qUwdQxA== From: SeongJae Park To: Akinobu Mita Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH] mm/damon: trace: print address range in hex Date: Mon, 30 Dec 2024 10:28:13 -0800 Message-Id: <20241230182813.14349-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241230134221.166041-1-akinobu.mita@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 56B7A140006 X-Stat-Signature: g15mme4zqzogd4ketbt49fw5tjxc6aik X-Rspam-User: X-HE-Tag: 1735583267-82890 X-HE-Meta: U2FsdGVkX1+DJPn3amZH4ef7cygsfy9fi7wTSVgPo50jWj/jdjiHFNwpzmSxIo8HU6oGUeMFtBFhgWKqUCFpCaY5jvChTmQ6IDt7IqeckU7e1CEsk3CTG/EoCNn0kcnTO7+2qrHJm6Z0qcPf4vRkUHglx87JCXoelHYc7L8Of+mJL/X3o3M4aJaAWkf7N5O5wkgTc15/kFBq5MUqeEEkWVlsoS/61bxG0LcgHeaYdBKwOzG9DzWeAOs4bBhfVnHLWGjAP4bhScKhJ+TxWO4S7rDfC0jUwGoTcI7NjjcN+7Ic2HMq4bNZrbpKx2/BnlTuS/TxVn3n9/pSfSgamVpXFG4Ot7MOP+HduXb3SVWQHSMYhH34NMR4SC/McFbAAM5bekz+DRg0b0TFnKLmpa+jvozXgXEukpdCGqm18/MaxFEnv8moUlPDqgg+rbLIFZ/Ulcwy/XSBtdSaWFUxUt6W09EMedSbrA3bCrJKJzSS1z+PJ3PpSTBXRISQ93Y/0wDG4hQEjuzn9HuC/rKaUTLiY+mEZ8BrAiuBY83YB00NTNbHhcIL2IaRsYrZpOu4cDti8OU7fro9qqhLHPtTlEZ8grbqWS1u4NwUXIkrT2HY0O57PocT3k4bZzjb0T/4Plbj7Ei9JreSwaCjCEG+ovgDCJbB1HbVLKXUGWYtOowYhPYsF1PIAGEglv3QrqyRVH72ShhbQQ6PSli60wKm0bM173SPnBfkzbbFOZWXL1zsBJIk2+c1xmhpLAN6kfAMkIDnw8zNFOBxhnq/f3G5xs8LfeikEImEINQywR8GfoqDhuqFMbt+vbMvFWhROu/kRUVxDLeEUYBv5utt+ZWeyXF8Jg37HbtjjMt9OeFFK1VGG+QyJrwtgHDlnNTyWrnM2BpXaKoy20ZTVpcOh5322vzV2VCycHLQ0Sokx9jmZTq2b6Y5TS3tXRj2dID1GtHA7hpuaL2pXdrpL4yKQvj79k6 CFZC7q0n 92i2oRYyZVBVISgxgJ4Lwtd9D+d3PzSPO3/TjI4hXryMNVJtQpV1ZSKaU8SOVP8jv8sOQt9giqdqT7yaFTqPg/kekRXD1zgFmcBrch+qzlBBxMtkPekT82Wzep+/sMACazIuM14MZJwiJ5FXCjZJGE5iIPwI+VTMbieLGQ07FRsLFFJIu9xxondVtibUCkl7KqTW/Y9YfSKcou1PQF9xhbqYC2EdMV1rllqa0tkQI7Q+1gf0lKp32g8fOPpHv8pwdEFMs39Svnzhn8BLXw2oSBF9NBomFAkT2TkGVp3HptToyQAg168Rs2xiv1vRXeyq8Xsz+JfhOaIb+2zs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Akinobu, On Mon, 30 Dec 2024 22:42:20 +0900 Akinobu Mita wrote: > Currently, the address ranges are displayed in decimal format in > tracepoints for DAMON, but hexadecimal format is easier to compare with > address ranges in /proc//numa_maps. I agree that it could be easier for the use case. But, I think writing and using a script converting formats for DAMON tracepoint output or numa_maps could also be a way to resolve the issue. Do you have any problem at using such solution? > > Existing tools such as damo need to be able to handle changing the format > of address ranges, Thank you for taking care of damo, too! > so display address ranges in hexadecimal with a "0x" > prefix. This is a user-visible behavioral change. I understand it is an improvement for your use case, but could be a degradation for some use cases. Also the change could confuse or break old use cases. I understand that 'damo' users will not get such problems thanks to your work, but not every DAMON users use 'damo'. So I'd like to add this change only if there is some critical issue or benefit that we cannot fix or achieve without this change. As of now, I don't see such things since I think you could use some user-space tools for your use case. Please let me know if there is something that I'm missing. Thanks, SJ > > Cc: SeongJae Park > Signed-off-by: Akinobu Mita > --- > include/trace/events/damon.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h > index da4bd9fd1162..8df59ef18660 100644 > --- a/include/trace/events/damon.h > +++ b/include/trace/events/damon.h > @@ -41,7 +41,7 @@ TRACE_EVENT_CONDITION(damos_before_apply, > __entry->nr_regions = nr_regions; > ), > > - TP_printk("ctx_idx=%u scheme_idx=%u target_idx=%lu nr_regions=%u %lu-%lu: %u %u", > + TP_printk("ctx_idx=%u scheme_idx=%u target_idx=%lu nr_regions=%u 0x%lx-0x%lx: %u %u", > __entry->context_idx, __entry->scheme_idx, > __entry->target_idx, __entry->nr_regions, > __entry->start, __entry->end, > @@ -73,7 +73,7 @@ TRACE_EVENT(damon_aggregated, > __entry->age = r->age; > ), > > - TP_printk("target_id=%lu nr_regions=%u %lu-%lu: %u %u", > + TP_printk("target_id=%lu nr_regions=%u 0x%lx-0x%lx: %u %u", > __entry->target_id, __entry->nr_regions, > __entry->start, __entry->end, > __entry->nr_accesses, __entry->age) > -- > 2.34.1