From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6FCFE77188 for ; Sun, 29 Dec 2024 02:00:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8EBB6B007B; Sat, 28 Dec 2024 21:00:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C3E2B6B0083; Sat, 28 Dec 2024 21:00:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2CBE6B0085; Sat, 28 Dec 2024 21:00:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9477A6B007B for ; Sat, 28 Dec 2024 21:00:38 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1105112182F for ; Sun, 29 Dec 2024 02:00:38 +0000 (UTC) X-FDA: 82946341128.23.46DBE35 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by imf09.hostedemail.com (Postfix) with ESMTP id 4F99A14000A for ; Sun, 29 Dec 2024 02:00:04 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ik3R44HZ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf09.hostedemail.com: domain of lkp@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735437594; a=rsa-sha256; cv=none; b=gFnrnwdlApFMTuYmfA9Ie+8OwAPv3PMdR1hYNDKqRysq4zUpWgqecH8PL9h73M8OOHg6Z6 RLWQLcUTkLk7JssIehKK44S/vfatMgOuAsow6+kaFN7xWXpjjbAPSHuQtu8+Wjri2+4CNU CD7y36EptHrm7Q85/OgXpQedp74Ycwk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ik3R44HZ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf09.hostedemail.com: domain of lkp@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735437594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=jBglQbb/r4vjNISMKGoEUfaeWuERA1fcw/kGpO0pg60=; b=KkCDqVB+NlQir9Uj0yu0p1H3cpsPE1zhMaaL55fD5C+/7zPYZoGwJ55oew1t4YthOQPrSq hSgQIIJbYEiFQO50R5xS+8jIP9K76HaVOxjO968Zqh8HGfN/kU3aQ5gMG5s2qZ8ZcwMwd3 y5DSJtdkJD4iwUEYzlovOj6MKK4o8Y4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735437635; x=1766973635; h=date:from:to:cc:subject:message-id:mime-version; bh=lZlZ0iCKtbfZtHanAEx/Fq3bhM3KFefHnqD1r2TIWa8=; b=ik3R44HZ4Q+PGY1BsUiDK9Ku3TCgqJ3IX46k7rT9SGigz91ynJM8d9sb 38xHPiLStpLFE+bDjxL1LXqgH4hsiKIkdElsIG64khz82epADdFR7LPwS gYXpmK/5fyAv+FZ9YucendVvvs4RJJK3xBWTbXESoUrqfI3EostQMazGU uehcXseNhccChaY/OsMvJT7rrpAYECzhdK8DPPhr4xTdO7C5cr4WkDGR+ oeT2r2n95QMXwEYEBFmIoOVmjwh9fnCYY1W+26aKprLaoqUY7wsZJ8bM1 PrsA1se5WugFrW14oZgrXE070uBtOdgSBrsXqYiE8xqaEPV+FgCQwh4bf g==; X-CSE-ConnectionGUID: /eshhI+NT5GKucxR1WUiIQ== X-CSE-MsgGUID: tmmFBCLMQCu1NZTyz09vgQ== X-IronPort-AV: E=McAfee;i="6700,10204,11299"; a="47190643" X-IronPort-AV: E=Sophos;i="6.12,273,1728975600"; d="scan'208";a="47190643" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2024 18:00:33 -0800 X-CSE-ConnectionGUID: up9ojHzhTxOWjgxeefyw8Q== X-CSE-MsgGUID: cKWC35ldSKinxswazUReBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="123748575" Received: from lkp-server01.sh.intel.com (HELO d63d4d77d921) ([10.239.97.150]) by fmviesa002.fm.intel.com with ESMTP; 28 Dec 2024 18:00:32 -0800 Received: from kbuild by d63d4d77d921 with local (Exim 4.96) (envelope-from ) id 1tRibV-0004Qw-1z; Sun, 29 Dec 2024 02:00:29 +0000 Date: Sun, 29 Dec 2024 09:59:48 +0800 From: kernel test robot To: Kairui Song Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: mm/list_lru.c:514:3-8: WARNING: NULL check before some freeing functions is not needed. Message-ID: <202412290924.UTP7GH2Z-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4F99A14000A X-Stat-Signature: 6g6tmz5w3hnbyzt6zmtz4xtp3ykygett X-Rspam-User: X-HE-Tag: 1735437604-892408 X-HE-Meta: U2FsdGVkX18mcMF7yfnkxGSYke2CFXOR4P+iwpnWNgDvR9e+ZGnbaph3vqIQLMj924eN3GPgaJ/BMuE+f6gXudBuWT3BN/cDaAFo/Lfsz7C1Nl1BMi3kmNdD+e6Cu6SMm8V2kxdkDJ8thf1Vr+vOnQPX02pJztSzRH/ezCdrex2jRqKn1yxuNaOriaXxn/O3VjdwmoWPbQZ3pZr5SijzCTu7VRmYjiGXa/WyhWGGrS0cShkTKkmteTrYBsGBhqoktKGnizWsqa188Si4kmOMElo0A4DKGPmk6nKlM3DQi/SQkpZOPqguZwQwYqlAClsTfDaofvIdM0DwixbmLpZMssemz2iNxNgVQWcJ6W0HSVZgm91sm/sEPdb1p/biILhqurTohO/XJ+J+aFwAC91Mm3xs7AeqzPzoIH4LWOTwqrFHRW51yX/QMrlCmVZZdYjHqjA7orA1z8/MHabfsQyaMtAk4s26i3Qa7jHKtRLyuiV43c7purK2smG5FZvrd3au7ZiawCDxBtawFvYfkxdJ7fjFpm5rg3bQhmvL+6k9jHe+jho77V0gdikzj2z2kIgmBGdk6YDhwSx41XdvfWT4FomAJWWI6oL0SlCY3TAIouYB2LQn+rdSsxPpns6T4L/tUBPP6Tei8CC6r2XDkLze7LyaEFrsavK/52L6eujezOIDYRtFR6TB20EIL4xGnj7sKqN46JU7huj4q5RFoYTuKUx1sXWBA2WS4f8LqXDNRQ5vOqGyUF88ZjomIvSIq+h9dt+dFpROl5ucqqUqwD8XaJYpEhDF2WJfZTzcVK6V05eaWgRfiOrASlv4cxjyxzfacdiYsHHJ4aQgEinbQly7S3Fc2GWAQBOwxgJ6UKQHVPZ1A1hqc/uMqSrC3lIYmbCAGFyDGIJ+d9sjdWis578P8op7EY590ID0GRa7NN03kjTR96GLGCN0o1JUiPveioOEk4ktQppNP+TYDDTbr9x 9AkUrKMB tnBIynyVJIcGGD/6G+UV+nH11jI3mJdfbBE8aOoy5Rben264+lEJmggmfmNB2h6y5fuLd3Bjlv/KrnKQo+ENk0urRfEQ1gdsp+JaXQFAXQFH5qgC+gyacmm54lzf+Cc05SKUgej+htCx1hOmPBbFF1FjBa82qzHjAwUP3oHfJDZqdm7L3E+CrOcAyCfIktqkhdFcDQyEC3o+sbDc851VOBgToWPhq+P52t3djrDZcceki8vhgil+x3+J7PRPudlaVr2UViENxNzpeVDT2xm7LkIFBEd3F1+6ucVOKPJUX8PDjiJzDNEWncEDpoHudGjwWQYblw1ygB7AHCD2QBwo/BFIap5J2j7f/hKb1UjfruPVCNqdy7RbeSDdulw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 059dd502b263d8a4e2a84809cf1068d6a3905e6f commit: 28e98022b31efdb8f1ba310d938cd9b97ededfe4 mm/list_lru: simplify reparenting and initial allocation date: 7 weeks ago config: i386-randconfig-054-20241229 (https://download.01.org/0day-ci/archive/20241229/202412290924.UTP7GH2Z-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202412290924.UTP7GH2Z-lkp@intel.com/ cocci warnings: (new ones prefixed by >>) >> mm/list_lru.c:514:3-8: WARNING: NULL check before some freeing functions is not needed. vim +514 mm/list_lru.c 470 471 int memcg_list_lru_alloc(struct mem_cgroup *memcg, struct list_lru *lru, 472 gfp_t gfp) 473 { 474 unsigned long flags; 475 struct list_lru_memcg *mlru; 476 struct mem_cgroup *pos, *parent; 477 XA_STATE(xas, &lru->xa, 0); 478 479 if (!list_lru_memcg_aware(lru) || memcg_list_lru_allocated(memcg, lru)) 480 return 0; 481 482 gfp &= GFP_RECLAIM_MASK; 483 /* 484 * Because the list_lru can be reparented to the parent cgroup's 485 * list_lru, we should make sure that this cgroup and all its 486 * ancestors have allocated list_lru_memcg. 487 */ 488 do { 489 /* 490 * Keep finding the farest parent that wasn't populated 491 * until found memcg itself. 492 */ 493 pos = memcg; 494 parent = parent_mem_cgroup(pos); 495 while (!memcg_list_lru_allocated(parent, lru)) { 496 pos = parent; 497 parent = parent_mem_cgroup(pos); 498 } 499 500 mlru = memcg_init_list_lru_one(gfp); 501 if (!mlru) 502 return -ENOMEM; 503 xas_set(&xas, pos->kmemcg_id); 504 do { 505 xas_lock_irqsave(&xas, flags); 506 if (!xas_load(&xas) && !css_is_dying(&pos->css)) { 507 xas_store(&xas, mlru); 508 if (!xas_error(&xas)) 509 mlru = NULL; 510 } 511 xas_unlock_irqrestore(&xas, flags); 512 } while (xas_nomem(&xas, gfp)); 513 if (mlru) > 514 kfree(mlru); 515 } while (pos != memcg && !css_is_dying(&pos->css)); 516 517 return xas_error(&xas); 518 } 519 #else 520 static inline void memcg_init_list_lru(struct list_lru *lru, bool memcg_aware) 521 { 522 } 523 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki