From: Kaixiong Yu <yukaixiong@huawei.com>
To: <akpm@linux-foundation.org>, <mcgrof@kernel.org>
Cc: <ysato@users.sourceforge.jp>, <dalias@libc.org>,
<glaubitz@physik.fu-berlin.de>, <luto@kernel.org>,
<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <hpa@zytor.com>,
<viro@zeniv.linux.org.uk>, <brauner@kernel.org>, <jack@suse.cz>,
<kees@kernel.org>, <j.granados@samsung.com>,
<willy@infradead.org>, <Liam.Howlett@oracle.com>,
<vbabka@suse.cz>, <lorenzo.stoakes@oracle.com>,
<trondmy@kernel.org>, <anna@kernel.org>, <chuck.lever@oracle.com>,
<jlayton@kernel.org>, <neilb@suse.de>, <okorniev@redhat.com>,
<Dai.Ngo@oracle.com>, <tom@talpey.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<paul@paul-moore.com>, <jmorris@namei.org>,
<linux-sh@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-nfs@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-security-module@vger.kernel.org>, <dhowells@redhat.com>,
<haifeng.xu@shopee.com>, <baolin.wang@linux.alibaba.com>,
<shikemeng@huaweicloud.com>, <dchinner@redhat.com>,
<bfoster@redhat.com>, <souravpanda@google.com>,
<hannes@cmpxchg.org>, <rientjes@google.com>,
<pasha.tatashin@soleen.com>, <david@redhat.com>,
<ryan.roberts@arm.com>, <ying.huang@intel.com>,
<yang@os.amperecomputing.com>, <zev@bewilderbeest.net>,
<serge@hallyn.com>, <vegard.nossum@oracle.com>,
<wangkefeng.wang@huawei.com>
Subject: [PATCH v4 -next 02/15] mm: filemap: move sysctl to mm/filemap.c
Date: Mon, 23 Dec 2024 22:15:37 +0800 [thread overview]
Message-ID: <20241223141550.638616-19-yukaixiong@huawei.com> (raw)
In-Reply-To: <20241223141550.638616-1-yukaixiong@huawei.com>
This moves the filemap related sysctl to mm/filemap.c, and
removes the redundant external variable declaration.
Signed-off-by: Kaixiong Yu <yukaixiong@huawei.com>
Reviewed-by: Kees Cook <kees@kernel.org>
---
v4:
- const qualify struct ctl_table filemap_sysctl_table
v3:
- change the title
---
---
include/linux/mm.h | 2 --
kernel/sysctl.c | 8 --------
mm/filemap.c | 18 +++++++++++++++---
3 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index d61b9c7a3a7b..dbdf8950d681 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -40,8 +40,6 @@ struct user_struct;
struct pt_regs;
struct folio_batch;
-extern int sysctl_page_lock_unfairness;
-
void mm_core_init(void);
void init_mm_internals(void);
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index f1ab251fc2d0..23c8db80da5d 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -2079,14 +2079,6 @@ static struct ctl_table vm_table[] = {
.extra1 = SYSCTL_ONE,
.extra2 = SYSCTL_FOUR,
},
- {
- .procname = "page_lock_unfairness",
- .data = &sysctl_page_lock_unfairness,
- .maxlen = sizeof(sysctl_page_lock_unfairness),
- .mode = 0644,
- .proc_handler = proc_dointvec_minmax,
- .extra1 = SYSCTL_ZERO,
- },
#ifdef CONFIG_MMU
{
.procname = "max_map_count",
diff --git a/mm/filemap.c b/mm/filemap.c
index 899dab55d235..bb7aff8960a4 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -47,6 +47,7 @@
#include <linux/splice.h>
#include <linux/rcupdate_wait.h>
#include <linux/sched/mm.h>
+#include <linux/sysctl.h>
#include <linux/fsnotify.h>
#include <asm/pgalloc.h>
#include <asm/tlbflush.h>
@@ -1069,6 +1070,19 @@ static wait_queue_head_t *folio_waitqueue(struct folio *folio)
return &folio_wait_table[hash_ptr(folio, PAGE_WAIT_TABLE_BITS)];
}
+/* How many times do we accept lock stealing from under a waiter? */
+static int sysctl_page_lock_unfairness = 5;
+static const struct ctl_table filemap_sysctl_table[] = {
+ {
+ .procname = "page_lock_unfairness",
+ .data = &sysctl_page_lock_unfairness,
+ .maxlen = sizeof(sysctl_page_lock_unfairness),
+ .mode = 0644,
+ .proc_handler = proc_dointvec_minmax,
+ .extra1 = SYSCTL_ZERO,
+ }
+};
+
void __init pagecache_init(void)
{
int i;
@@ -1077,6 +1091,7 @@ void __init pagecache_init(void)
init_waitqueue_head(&folio_wait_table[i]);
page_writeback_init();
+ register_sysctl_init("vm", filemap_sysctl_table);
}
/*
@@ -1224,9 +1239,6 @@ static inline bool folio_trylock_flag(struct folio *folio, int bit_nr,
return true;
}
-/* How many times do we accept lock stealing from under a waiter? */
-int sysctl_page_lock_unfairness = 5;
-
static inline int folio_wait_bit_common(struct folio *folio, int bit_nr,
int state, enum behavior behavior)
{
--
2.34.1
next prev parent reply other threads:[~2024-12-23 14:20 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-23 14:15 [PATCH v4 -next 00/15] sysctl: move sysctls from vm_table into its own files Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 01/15] mm: vmstat: move sysctls to mm/vmstat.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 02/15] mm: filemap: move sysctl to mm/filemap.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 03/15] mm: swap: move sysctl to mm/swap.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 04/15] mm: vmscan: move vmscan sysctls to mm/vmscan.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 05/15] mm: util: move sysctls to mm/util.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 06/15] mm: mmap: move sysctl to mm/mmap.c Kaixiong Yu
2025-01-02 14:08 ` Lorenzo Stoakes
2025-01-09 2:20 ` yukaixiong
2024-12-23 14:15 ` [PATCH v4 -next 07/15] security: min_addr: move sysctl to security/min_addr.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 08/15] mm: nommu: move sysctl to mm/nommu.c Kaixiong Yu
2025-01-02 14:09 ` Lorenzo Stoakes
2025-01-09 2:26 ` yukaixiong
2024-12-23 14:15 ` [PATCH v4 -next 09/15] fs: fs-writeback: move sysctl to fs/fs-writeback.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 10/15] fs: drop_caches: move sysctl to fs/drop_caches.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 11/15] sunrpc: simplify rpcauth_cache_shrink_count() Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 12/15] fs: dcache: move the sysctl to fs/dcache.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 13/15] x86: vdso: move the sysctl to arch/x86/entry/vdso/vdso32-setup.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 14/15] sh: vdso: move the sysctl to arch/sh/kernel/vsyscall/vsyscall.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 15/15] sysctl: remove unneeded include Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 00/15] sysctl: move sysctls from vm_table into its own files Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 01/15] mm: vmstat: move sysctls to mm/vmstat.c Kaixiong Yu
2024-12-23 14:15 ` Kaixiong Yu [this message]
2024-12-23 14:15 ` [PATCH v4 -next 03/15] mm: swap: move sysctl to mm/swap.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 04/15] mm: vmscan: move vmscan sysctls to mm/vmscan.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 05/15] mm: util: move sysctls to mm/util.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 06/15] mm: mmap: move sysctl to mm/mmap.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 07/15] security: min_addr: move sysctl to security/min_addr.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 08/15] mm: nommu: move sysctl to mm/nommu.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 09/15] fs: fs-writeback: move sysctl to fs/fs-writeback.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 10/15] fs: drop_caches: move sysctl to fs/drop_caches.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 11/15] sunrpc: simplify rpcauth_cache_shrink_count() Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 12/15] fs: dcache: move the sysctl to fs/dcache.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 13/15] x86: vdso: move the sysctl to arch/x86/entry/vdso/vdso32-setup.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 14/15] sh: vdso: move the sysctl to arch/sh/kernel/vsyscall/vsyscall.c Kaixiong Yu
2024-12-23 14:15 ` [PATCH v4 -next 15/15] sysctl: remove unneeded include Kaixiong Yu
2024-12-28 12:15 ` [PATCH v4 -next 00/15] sysctl: move sysctls from vm_table into its own files Joel Granados
2024-12-28 13:40 ` yukaixiong
2025-01-06 11:22 ` Joel Granados
2025-01-09 2:35 ` yukaixiong
2024-12-28 14:57 Kaixiong Yu
2024-12-28 14:57 ` [PATCH v4 -next 02/15] mm: filemap: move sysctl to mm/filemap.c Kaixiong Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241223141550.638616-19-yukaixiong@huawei.com \
--to=yukaixiong@huawei.com \
--cc=Dai.Ngo@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anna@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=bfoster@redhat.com \
--cc=bp@alien8.de \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=dchinner@redhat.com \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=haifeng.xu@shopee.com \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=j.granados@samsung.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=jmorris@namei.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=luto@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=okorniev@redhat.com \
--cc=pabeni@redhat.com \
--cc=pasha.tatashin@soleen.com \
--cc=paul@paul-moore.com \
--cc=rientjes@google.com \
--cc=ryan.roberts@arm.com \
--cc=serge@hallyn.com \
--cc=shikemeng@huaweicloud.com \
--cc=souravpanda@google.com \
--cc=tglx@linutronix.de \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=vbabka@suse.cz \
--cc=vegard.nossum@oracle.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=yang@os.amperecomputing.com \
--cc=ying.huang@intel.com \
--cc=ysato@users.sourceforge.jp \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox