linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kanchana P Sridhar <kanchana.p.sridhar@intel.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com,
	chengming.zhou@linux.dev, usamaarif642@gmail.com,
	ryan.roberts@arm.com, 21cnbao@gmail.com,
	akpm@linux-foundation.org, linux-crypto@vger.kernel.org,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com,
	surenb@google.com, kristen.c.accardi@intel.com
Cc: wajdi.k.feghali@intel.com, vinodh.gopal@intel.com,
	kanchana.p.sridhar@intel.com
Subject: [PATCH v5 06/12] crypto: iaa - Disable iaa_verify_compress by default.
Date: Fri, 20 Dec 2024 22:31:13 -0800	[thread overview]
Message-ID: <20241221063119.29140-7-kanchana.p.sridhar@intel.com> (raw)
In-Reply-To: <20241221063119.29140-1-kanchana.p.sridhar@intel.com>

This patch makes it easier for IAA hardware acceleration in the iaa_crypto
driver to be loaded by default with "iaa_verify_compress" disabled, to
facilitate performance comparisons with software compressors (which also
do not run compress verification by default). Earlier, iaa_crypto compress
verification used to be enabled by default.

With this patch, if users want to enable compress verification, they can do
so with these steps:

  1) disable all the IAA device/wq bindings that happen at boot time
  2) rmmod iaa_crypto
  3) modprobe iaa_crypto
  4) echo 1 > /sys/bus/dsa/drivers/crypto/verify_compress
  5) re-run initialization of the IAA devices and wqs

Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@intel.com>
---
 drivers/crypto/intel/iaa/iaa_crypto_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c b/drivers/crypto/intel/iaa/iaa_crypto_main.c
index 6d49f82165fe..f4807a828034 100644
--- a/drivers/crypto/intel/iaa/iaa_crypto_main.c
+++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c
@@ -94,7 +94,7 @@ static bool iaa_crypto_enabled;
 static bool iaa_crypto_registered;
 
 /* Verify results of IAA compress or not */
-static bool iaa_verify_compress = true;
+static bool iaa_verify_compress = false;
 
 static ssize_t verify_compress_show(struct device_driver *driver, char *buf)
 {
-- 
2.27.0



  parent reply	other threads:[~2024-12-21  6:31 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-21  6:31 [PATCH v5 00/12] zswap IAA compress batching Kanchana P Sridhar
2024-12-21  6:31 ` [PATCH v5 01/12] crypto: acomp - Add synchronous/asynchronous acomp request chaining Kanchana P Sridhar
2024-12-21  6:31 ` [PATCH v5 02/12] crypto: acomp - Define new interfaces for compress/decompress batching Kanchana P Sridhar
2024-12-28 11:46   ` Herbert Xu
2025-01-06 17:37     ` Sridhar, Kanchana P
2025-01-06 23:24       ` Yosry Ahmed
2025-01-07  1:36         ` Sridhar, Kanchana P
2025-01-07  1:46           ` Yosry Ahmed
2025-01-07  2:06             ` Herbert Xu
2025-01-07  3:10               ` Yosry Ahmed
2025-01-08  1:38                 ` Herbert Xu
2025-01-08  1:43                   ` Yosry Ahmed
2025-02-16  5:17                 ` Herbert Xu
2025-02-20 17:32                   ` Yosry Ahmed
2025-02-22  6:26                     ` Barry Song
2025-02-22  6:34                       ` Herbert Xu
2025-02-22  6:41                         ` Barry Song
2025-02-22  6:52                           ` Herbert Xu
2025-02-22  7:13                             ` Barry Song
2025-02-22  7:22                               ` Herbert Xu
2025-02-22  8:21                                 ` Barry Song
2025-02-24 21:49                               ` Yosry Ahmed
2025-02-27  3:05                                 ` Barry Song
2025-02-22 12:31                       ` Sergey Senozhatsky
2025-02-22 14:27                         ` Sergey Senozhatsky
2025-02-23  0:14                           ` Herbert Xu
2025-02-23  2:09                             ` Sergey Senozhatsky
2025-02-23  2:52                               ` Herbert Xu
2025-02-23  3:12                                 ` Sergey Senozhatsky
2025-02-23  3:38                                   ` Herbert Xu
2025-02-23  4:02                                     ` Sergey Senozhatsky
2025-02-23  6:04                                       ` Herbert Xu
2025-02-22 16:24                         ` Barry Song
2025-02-23  0:24                         ` Herbert Xu
2025-02-23  1:57                           ` Sergey Senozhatsky
2025-01-07  2:04       ` Herbert Xu
2024-12-21  6:31 ` [PATCH v5 03/12] crypto: iaa - Add an acomp_req flag CRYPTO_ACOMP_REQ_POLL to enable async mode Kanchana P Sridhar
2024-12-21  6:31 ` [PATCH v5 04/12] crypto: iaa - Implement batch_compress(), batch_decompress() API in iaa_crypto Kanchana P Sridhar
2024-12-22  4:07   ` kernel test robot
2024-12-21  6:31 ` [PATCH v5 05/12] crypto: iaa - Make async mode the default Kanchana P Sridhar
2024-12-21  6:31 ` Kanchana P Sridhar [this message]
2024-12-21  6:31 ` [PATCH v5 07/12] crypto: iaa - Re-organize the iaa_crypto driver code Kanchana P Sridhar
2024-12-21  6:31 ` [PATCH v5 08/12] crypto: iaa - Map IAA devices/wqs to cores based on packages instead of NUMA Kanchana P Sridhar
2024-12-21  6:31 ` [PATCH v5 09/12] crypto: iaa - Distribute compress jobs from all cores to all IAAs on a package Kanchana P Sridhar
2024-12-21  6:31 ` [PATCH v5 10/12] mm: zswap: Allocate pool batching resources if the crypto_alg supports batching Kanchana P Sridhar
2025-01-07  0:58   ` Yosry Ahmed
2025-01-08  3:26     ` Sridhar, Kanchana P
2025-01-08  4:16       ` Yosry Ahmed
2024-12-21  6:31 ` [PATCH v5 11/12] mm: zswap: Restructure & simplify zswap_store() to make it amenable for batching Kanchana P Sridhar
2025-01-07  1:16   ` Yosry Ahmed
2025-01-08  3:57     ` Sridhar, Kanchana P
2025-01-08  4:22       ` Yosry Ahmed
2024-12-21  6:31 ` [PATCH v5 12/12] mm: zswap: Compress batching with Intel IAA in zswap_store() of large folios Kanchana P Sridhar
2025-01-07  1:19   ` Yosry Ahmed
2025-01-07  1:44 ` [PATCH v5 00/12] zswap IAA compress batching Yosry Ahmed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241221063119.29140-7-kanchana.p.sridhar@intel.com \
    --to=kanchana.p.sridhar@intel.com \
    --cc=21cnbao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ardb@kernel.org \
    --cc=chengming.zhou@linux.dev \
    --cc=clabbe@baylibre.com \
    --cc=davem@davemloft.net \
    --cc=ebiggers@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=ryan.roberts@arm.com \
    --cc=surenb@google.com \
    --cc=usamaarif642@gmail.com \
    --cc=vinodh.gopal@intel.com \
    --cc=wajdi.k.feghali@intel.com \
    --cc=yosryahmed@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox