From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7445E77188 for ; Fri, 20 Dec 2024 17:33:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B7716B0088; Fri, 20 Dec 2024 12:33:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 167A46B0089; Fri, 20 Dec 2024 12:33:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02E936B008A; Fri, 20 Dec 2024 12:33:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D29E46B0088 for ; Fri, 20 Dec 2024 12:33:02 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 783601A0D26 for ; Fri, 20 Dec 2024 17:33:02 +0000 (UTC) X-FDA: 82916031996.22.791A34A Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by imf22.hostedemail.com (Postfix) with ESMTP id 94116C000C for ; Fri, 20 Dec 2024 17:32:23 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JsxHvWxv; spf=pass (imf22.hostedemail.com: domain of lkp@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734715941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OnGjcXw+FoSzPbR1pOkCigHRwXb4XtQH3V3TCCheeNs=; b=sfCrdsOA5u49R7zxKdhduhx2SdUHgzQXJlux3vpNvexvNgaQyQpfHfvJq/kOUq4N0uGWM9 aUsRQ5BJHWvJSC0TV+jr3My0AnDh4Xjntp9gguaZNR8Z15yqa7S8t36ncs4OMFyjEpxXlY F9ZASSCInyGwHE0qRzFGTjVsulp2tAE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734715941; a=rsa-sha256; cv=none; b=Ft6ySQGZkXOM28Jt1zWAIS0hkrQeVgIEas9WdAc5E0RxKVapa2Vy509JD5uXs2cuRRne+f 9V3apptXctlSO+EvimjHXW+8UsohORbfqYTxBmBv0EnDvioxRL92MkXjspSTR4px8MdTwL MGNUc+7NzQtOjoSchlaGZoazzC14LeA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JsxHvWxv; spf=pass (imf22.hostedemail.com: domain of lkp@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734715979; x=1766251979; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=TBas8igC7du+Ed2ZzdVC19hjX6NShxHjnEaw1zBz9nw=; b=JsxHvWxvt8exs/8PKIZIp9M7VE3c8w/4EfaZCNNEf0NM4fL+FDrCu6p1 ZzJeG+ppUWgyzAQQAKQQpGcQG/L1g0nVChyfoagg4wCZxC67todu+iqXW LPlQVSSmPBgRI8o2w7EQre3NeI+j6Xtge5mwNX6n+BaIRFx38GD4rxr0Z NEYvQv1IIHKscUUVsk5dYWpvJBS/Iy3A5aRco2H5hrOvudwVpkfbeQo6K VmNx+8VpAvfza7ltW+q7x1nCxVaEot96qLck+CYw5Pp1dpgsPClD6WzED tJnvEshCxc7DDC4uL5zo/VfpPVmXN97SOC2TQdw2gwpQuGOlB/fUybeA3 A==; X-CSE-ConnectionGUID: nS97mlKnRc6rwNm/kvkWxA== X-CSE-MsgGUID: FmrpLCemQ5yhh43sHNMjJA== X-IronPort-AV: E=McAfee;i="6700,10204,11292"; a="39207313" X-IronPort-AV: E=Sophos;i="6.12,251,1728975600"; d="scan'208";a="39207313" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2024 09:32:58 -0800 X-CSE-ConnectionGUID: FvIR2muVRgO6CkiEz0P5jw== X-CSE-MsgGUID: 4+QdaSJVTyOWvnJhHLezLQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,251,1728975600"; d="scan'208";a="98771468" Received: from lkp-server01.sh.intel.com (HELO a46f226878e0) ([10.239.97.150]) by fmviesa008.fm.intel.com with ESMTP; 20 Dec 2024 09:32:54 -0800 Received: from kbuild by a46f226878e0 with local (Exim 4.96) (envelope-from ) id 1tOgrr-0001U3-1u; Fri, 20 Dec 2024 17:32:51 +0000 Date: Sat, 21 Dec 2024 01:32:45 +0800 From: kernel test robot To: Chen Ridong , akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org, yosryahmed@google.com, yuzhao@google.com, david@redhat.com, willy@infradead.org, ryan.roberts@arm.com, baohua@kernel.org, 21cnbao@gmail.com, wangkefeng.wang@huawei.com Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com, xieym_ict@hotmail.com Subject: Re: [PATCH -next v5] mm: vmscan: retry folios written back while isolated for traditional LRU Message-ID: <202412210101.Og2hX0Rs-lkp@intel.com> References: <20241220010931.3603111-1-chenridong@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241220010931.3603111-1-chenridong@huaweicloud.com> X-Rspamd-Queue-Id: 94116C000C X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: skc3hsxm3jy7xnfbj1wqdinhof6j87hu X-HE-Tag: 1734715943-793643 X-HE-Meta: U2FsdGVkX1++sZ6O339upWutx7X2NgacbGpbSQE+YeIJB8Qh5U1UZ4Y4uhRq03Ng/BmObMNSRo/lvLPoa3zbcvh6xVFfdgLrkMZwjba3/TvfwvCCWMyYQrfRkGy3bP5/5Ra1qal8x878+NLVsvAWzuopsNN4DWZ+P+u2swCE2UDlCVEgtN9N1Zq5VW+ZiMIRu3KhVPsbd1WaeyYeWWsJH/iDhCT3fBTgB2LDllOiwJPM1+Hjp7HIZvuDR1gRW6xZ6Lf/3KxJQtveltuTfxIE5Hiuq+TYiupf2bQTlpU4IGbBqPZSWotlqR8YKSauOnrvYv4sxg1RQ8Guqi7fxE3XZo7LW2PHYVX3LkBYqVIRrhzRp52xcat+3AWd27oYehiELW3sUHN07nlo5OTKi/3pYftCQr+nN8dox3nhOjYyfYoGchThjBGcsBDZeIuyRER251NxDNaYiYfA4Oc0IgAxNaBrAGhDIgoA/8bijeHSDWMgoTCn1OCp033bzQU0rA71kLypLhxst44tCDxABHSM7ux42YYDjGnIMNwvlvHSmQkM8zyG7i5tuhq3wvoLxY8b3QrpKOb7QzAlf7R8rLHkk1ZkCy5BGXi/vt/PDGGviYBlLPy+xNe0OoHP6D+jVmCtqqwOaBokULAlYmYqDH8gi+6XfeGmeNljaFpZbufZeMydQKIaeEkAkYZB0sVWPgOZ3d4SHoyppLgUJfDyd3+WGHnF5VSqSGc5y/zDsBHy8kkvP/ChBD0M+i+B7gv5+KIq5U11tRwR2o63ok/5CaKdZ3Fq2jUOG2SSAcabq3JncjnRXKY/1p8eEn9aim0cdoSY/xYzEpFa9QrtRVm7sQ+z7kFx1n8879lZZV/8yIKd/glrat43iSxhsNtlirQ5itJfD7uBZ8cS/1QHXozz9BdPHTWYTd0EyDp6u5TyevLZ0RnFoHTsuFLp3pbdyoZl0MzYlGs2dupBIwTRpOtG2fB n8wjQqnI CVK8MJVLtZ6lHJbwIVk3ojeb1+xxFufa9l9A9KbEibXDHVd2jdiKUjAv8Yl8mURDcMR8cXydWv6ZAUBK7099AE56DfEZW+XEcPQBv7KRQ3mkR7gQndL04L7W4qMgqi9UhaIGvZoPPRPVnPq6fU9AycwuLixyQKuk03p1JpZJqa0Ud+ZLec3KB/qJlA1LTYy85C+2N55721IjyDLSTDxSKqPv357I7AokOS11pC8jTeevuBV7y9/yjL8a6aWnNzt1YSsu3QNYW6bZx7vnyjRLhuwCWHh1EEQ4HT0v3POrDEr1BrufL2JYZYNjM1R6fapVKixjJukVanFNDEnXT7p3TljRgPAOTK2fXCZff X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Chen, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Chen-Ridong/mm-vmscan-retry-folios-written-back-while-isolated-for-traditional-LRU/20241220-092147 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20241220010931.3603111-1-chenridong%40huaweicloud.com patch subject: [PATCH -next v5] mm: vmscan: retry folios written back while isolated for traditional LRU config: i386-buildonly-randconfig-004-20241220 (https://download.01.org/0day-ci/archive/20241221/202412210101.Og2hX0Rs-lkp@intel.com/config) compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241221/202412210101.Og2hX0Rs-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202412210101.Og2hX0Rs-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from mm/vmscan.c:30: include/linux/mm_inline.h:47:41: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 47 | __mod_lruvec_state(lruvec, NR_LRU_BASE + lru, nr_pages); | ~~~~~~~~~~~ ^ ~~~ include/linux/mm_inline.h:49:22: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 49 | NR_ZONE_LRU_BASE + lru, nr_pages); | ~~~~~~~~~~~~~~~~ ^ ~~~ In file included from mm/vmscan.c:42: In file included from include/linux/migrate.h:8: include/linux/hugetlb.h:1063:5: warning: no previous prototype for function 'replace_free_hugepage_folios' [-Wmissing-prototypes] 1063 | int replace_free_hugepage_folios(unsigned long start_pfn, unsigned long end_pfn) | ^ include/linux/hugetlb.h:1063:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 1063 | int replace_free_hugepage_folios(unsigned long start_pfn, unsigned long end_pfn) | ^ | static >> mm/vmscan.c:313:29: error: call to undeclared function 'lru_gen_distance'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 313 | if (lru_gen_enabled() && !lru_gen_distance(folio, false)) | ^ mm/vmscan.c:442:51: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 442 | size += zone_page_state(zone, NR_ZONE_LRU_BASE + lru); | ~~~~~~~~~~~~~~~~ ^ ~~~ mm/vmscan.c:1806:4: warning: arithmetic between different enumeration types ('enum vm_event_item' and 'enum zone_type') [-Wenum-enum-conversion] 1806 | __count_zid_vm_events(PGSCAN_SKIP, zid, nr_skipped[zid]); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:139:34: note: expanded from macro '__count_zid_vm_events' 139 | __count_vm_events(item##_NORMAL - ZONE_NORMAL + zid, delta) | ~~~~~~~~~~~~~ ^ ~~~~~~~~~~~ mm/vmscan.c:2330:51: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 2330 | inactive = lruvec_page_state(lruvec, NR_LRU_BASE + inactive_lru); | ~~~~~~~~~~~ ^ ~~~~~~~~~~~~ mm/vmscan.c:2331:49: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 2331 | active = lruvec_page_state(lruvec, NR_LRU_BASE + active_lru); | ~~~~~~~~~~~ ^ ~~~~~~~~~~ mm/vmscan.c:6271:3: warning: arithmetic between different enumeration types ('enum vm_event_item' and 'enum zone_type') [-Wenum-enum-conversion] 6271 | __count_zid_vm_events(ALLOCSTALL, sc->reclaim_idx, 1); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:139:34: note: expanded from macro '__count_zid_vm_events' 139 | __count_vm_events(item##_NORMAL - ZONE_NORMAL + zid, delta) | ~~~~~~~~~~~~~ ^ ~~~~~~~~~~~ 8 warnings and 1 error generated. vim +/lru_gen_distance +313 mm/vmscan.c 285 286 /** 287 * find_folios_written_back - Find and move the written back folios to a new list. 288 * @list: filios list 289 * @clean: the written back folios list 290 * @is_retried: whether the list has already been retried. 291 */ 292 static inline void find_folios_written_back(struct list_head *list, 293 struct list_head *clean, bool is_retried) 294 { 295 struct folio *folio; 296 struct folio *next; 297 298 list_for_each_entry_safe_reverse(folio, next, list, lru) { 299 if (!folio_evictable(folio)) { 300 list_del(&folio->lru); 301 folio_putback_lru(folio); 302 continue; 303 } 304 305 /* retry folios that may have missed folio_rotate_reclaimable() */ 306 if (!is_retried && !folio_test_active(folio) && !folio_mapped(folio) && 307 !folio_test_dirty(folio) && !folio_test_writeback(folio)) { 308 list_move(&folio->lru, clean); 309 continue; 310 } 311 312 /* don't add rejected folios to the oldest generation */ > 313 if (lru_gen_enabled() && !lru_gen_distance(folio, false)) 314 set_mask_bits(&folio->flags, LRU_REFS_FLAGS, BIT(PG_active)); 315 } 316 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki