From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2006DE77188 for ; Fri, 20 Dec 2024 23:06:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 501626B0085; Fri, 20 Dec 2024 18:06:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D8B16B0088; Fri, 20 Dec 2024 18:06:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3792C6B0089; Fri, 20 Dec 2024 18:06:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1D1266B0085 for ; Fri, 20 Dec 2024 18:06:31 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C7616A0F0E for ; Fri, 20 Dec 2024 23:06:30 +0000 (UTC) X-FDA: 82916872668.11.CBE243F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 7F1F11C000D for ; Fri, 20 Dec 2024 23:05:22 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ko0NoC85; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734735956; a=rsa-sha256; cv=none; b=Ul/GXwD16hfWG2dK5yFe5LId//A9Cd3MqIvYCGPwrNCTHtW6otiHvE6019VUMrECztIpT9 rpvyqTjyYvhx4HDtkIdqFmxoh2WCNTooPbCCe3q8I/cgo53dYQqQ0J7fhRRp8JHNWqGx7Z mG988cx7DYuIkmE73qPyC09yPIyVu5w= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ko0NoC85; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734735956; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EwcaWmbpAr7Tt6bNh0ZEoMJ/C6ZMgwB9Hii3xy1Ro3M=; b=kxeb48AA8urzsyj/Sz0X0M39iFdUiPOtdn6Qc4n3olyOi80kxyf7swF3xYntmolFtvb7EA zzH7inS7GT0HVTjBjByhNCnBGUgVh4TE/sFax9TTW8a2IJwW6Cnds9TcxIUyTiXzQo9J5D zifWSmLIKApEVrPLkE/Y8MkDcRdLC1c= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 683895C3B27; Fri, 20 Dec 2024 23:05:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51D4DC4CECD; Fri, 20 Dec 2024 23:06:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1734735987; bh=rDnT4CiiEQHDei+WTY8t89wAldSK7/wzy9hzuNQ2FY0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ko0NoC85TGcP1IppTBQ7r5GFZyBBTG2SpQ0tFrc/AJkG+/T9Itx2K+hPhmLUjOFT3 W/JopMsDfKdWQ+Sgte/CaZu5u4oCC9X7AhqHTGt1/QNG5SKrdk/OmLPnondMcorXOq YK2sRjfqtNIqcRTWYGNAXSYWTaR7HQTBx80wOGXo= Date: Fri, 20 Dec 2024 15:06:23 -0800 From: Andrew Morton To: Guo Weikang Cc: Mike Rapoport , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Bogendoerfer , Sam Creasey , Geert Uytterhoeven , Huacai Chen , Will Deacon , Catalin Marinas , Oreoluwa Babatunde , rafael.j.wysocki@intel.com, Palmer Dabbelt , Hanjun Guo , Easwar Hariharan , Johannes Berg , Ingo Molnar , Dave Hansen , Christian Brauner , KP Singh , Richard Henderson , Matt Turner , Russell King , WANG Xuerui , Michael Ellerman , Jonas Bonn , Stefan Kristiansson , Stafford Horne , Helge Deller , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Geoff Levand , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Len Brown , Juergen Gross , Boris Ostrovsky , Chris Zankel , Max Filippov , Tero Kristo , Michael Turquette , Stephen Boyd , Rob Herring , Saravana Kannan , Pavel Machek , Yury Norov , Rasmus Villemoes , Marco Elver , Al Viro , Arnd Bergmann , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, kasan-dev@googlegroups.com, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] mm/memblock: Add memblock_alloc_or_panic interface Message-Id: <20241220150623.278e8fa9f073b66dc81edfe6@linux-foundation.org> In-Reply-To: <20241220092638.2611414-1-guoweikang.kernel@gmail.com> References: <20241220092638.2611414-1-guoweikang.kernel@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7F1F11C000D X-Stat-Signature: g4gmbufo3hgfed7k6c9op5k37t7x8cx4 X-Rspam-User: X-HE-Tag: 1734735922-279250 X-HE-Meta: U2FsdGVkX1+4nouaofX7m+xchSiyUWcZ2P4F2HezzozTScMTCpVU+Q86EMFL9VlW7DbeNMEnM74GqquOY7gg7j47YXjnZ/6pYVUxagUAo6sUF154H43VUfnK3urngjFgwAjZA7QrMCu2pCd0n8LliuyaS6BIKk8JodKvs7/VdAKkaC6Zh7L+3/F4hyotS6ZqWwYRnRmIO+trrs+V72KedvQc3ChYooG2pQM4k2IhQLNVmtmzo5hqDtGgPwbSh2WCz6FC5gpvkVLTkCdCoOGGSu2i7mPvMLqNvRGotEI8q9q0PN0uy0815+W/02CccjaQ3lIfElcJP3K+Q5QX78nzOpRuXDznn0MsJ0eG7y38zEy7T308XX7YGfBwWHhQ7D4K0l/chlIHW8in8I9ckdxpu84LlgNa9lsmvr7nuzAXBq3Suq9ljL6rN/lWHc0D3UkP/z3a9ckeGi9zdsvDcqlI7tIADRhvl3eV6Xww0Iu2eVENtFC58WqFp+Ztdo1MHKpiFuPPCFwJPFoM/3esvx52q0ehjhfU+HTsdDTRbuiU5SS/wsdDmUDC2sKHVfTv4tDCfKAxAzwVrGZgEszCCdWcvqN2xLGUzo23jssIQYSGzKF0oIDRL+luhW0jPUOo8mzxc3/iIZxy3phADSvYBE7cmRLDUxnZmdE6xIVmIXy0TwkbDHsSUO3iM2WTBSLPNXp/tVw+y01wF78hJT7T9rJHSHaAZbo+O6bcGfLZq0UwKUb4cAZnpP2LlnNPJP5LTV685Vpuw/s77OJOFP8Ruy4hKtqNVmkUm0+COrd0GAF6qpMY31LQVN6b0k13J15h/9VpkmWdFefO1ldbVL93X7qzUNzfRKahk+McviNSZBvd4TYzxX4jdWhrzJICAfy8EJX7aToctDM/yEROPjHAiob213LHe5ic70n7VBNNnQcc5hPac3GonBw2FohJvjMLOi9V2xEgWU45nXFs9raKQPk wNvKzeFo voX3iyFc1+PO2v3/g5YOalW6lqZs0M2qcAmPrVQ+oNPe051bFBNbuemhv9aKvU951tXue7QbcKzS05Jc30TaozDphnGUwYhWyaOogJVtaqVrNTFFWbPFywTIvFLsWrTjQNbjXG6eHHab6r67rwqmBY0xus9+12VG9yXKUKZhSHNkPO2BCksiyDYuh6qjUbkCKt/Qw8Vr2WFqP6GkSTg+CCOhsNZVWqd1J1/jX/T7mJyXTTtFe4+ZDLSSa06BsblBv2uSP5WIsSCZD5nZACp8vL/E1WF6dJuR934LCFDVN8bAS+sgIAWm4o/KUSGo30zPFLMqXplQuU2xivp3LJFodByTwL+gouLvxUxnP7DzW7aCGf9yqnYFY4I12yv557lpxrdhvhtxoE9y9244= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 20 Dec 2024 17:26:38 +0800 Guo Weikang wrote: > Before SLUB initialization, various subsystems used memblock_alloc to > allocate memory. In most cases, when memory allocation fails, an immediate > panic is required. To simplify this behavior and reduce repetitive checks, > introduce `memblock_alloc_or_panic`. This function ensures that memory > allocation failures result in a panic automatically, improving code > readability and consistency across subsystems that require this behavior. > Seems nice. > ... > > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -417,6 +417,19 @@ static __always_inline void *memblock_alloc(phys_addr_t size, phys_addr_t align) > MEMBLOCK_ALLOC_ACCESSIBLE, NUMA_NO_NODE); > } > > +static __always_inline void *memblock_alloc_or_panic(phys_addr_t size, phys_addr_t align) We lost the printing of the function name, but it's easy to retain with something like #define memblock_alloc_or_panic(size, align) \ __memblock_alloc_or_panic(size, align, __func__) > +{ > + void *addr = memblock_alloc(size, align); > + > + if (unlikely(!addr)) > +#ifdef CONFIG_PHYS_ADDR_T_64BIT > + panic("%s: Failed to allocate %llu bytes\n", __func__, size); Won't this always print "memblock_alloc_or_panic: Failed ..."? Not very useful. > +#else > + panic("%s: Failed to allocate %u bytes\n", __func__, size); > +#endif We can avoid the ifdef with printk's "%pap"? > + return addr; > +}