From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BDE4E77188 for ; Fri, 20 Dec 2024 22:19:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2E3B6B0083; Fri, 20 Dec 2024 17:19:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DCF26B0088; Fri, 20 Dec 2024 17:19:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A48D6B0089; Fri, 20 Dec 2024 17:19:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6A2406B0083 for ; Fri, 20 Dec 2024 17:19:48 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EA957C0DEC for ; Fri, 20 Dec 2024 22:19:47 +0000 (UTC) X-FDA: 82916754606.26.CD09CA2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 7C99720014 for ; Fri, 20 Dec 2024 22:19:12 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=JD8uPrOs; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734733163; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GT0eLD7TL3JgQ6NTwvn72WbmRplSwDHkfnEQtwZ7Fc8=; b=r8uHSfr8HbiovWwAKsfYhdhvYgaSlUOWnlp38+8gpdyEOVBPq7zNX8Pi2y4E/EI8D4ym0E U33rTbw2d6SzWMefDMsCbUBRctcdT2hShzKZ9BH3nLp2jqAu4L41Zv0M23xo3zv13yPi9K DRd77vzVwSFFTzfN8ecfUtEtG2JbMi0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734733163; a=rsa-sha256; cv=none; b=NbxD9Uo01tj3QQYdGA0W+7/tLm8xPcXxKehWzcnOkP8FqBmMMEBR8lsdyByaQIRYTgRXNa 4FXfs8NGYxXXKkzwOUAP5k/JItqDXbQRimiirmnzOupfpHVgX01A5D86rdRiXZKoLSfPEb jKh9tdES4U+p1T1XeZ9LyaonXC7yZ8Y= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=JD8uPrOs; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 14F025C5AB8; Fri, 20 Dec 2024 22:19:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91206C4CECD; Fri, 20 Dec 2024 22:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1734733184; bh=YxgJqPKaNgBjWRHZz2knk1IKZ9j6M+BCC2f+qx3AzU8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JD8uPrOsIrfU0+gnjrEvbD3R5+22Tw//QTdEDJNMrDYX0UhTzp96U2T6IR3iVaY7T e3E05HzJbi93CCiT1Xh3PMZ/ZXG12ospk/P0GXtyLI3vgk7VyBMCNpx7aWwR7rnbGT 4xIHqGOwiFJRXXU2E5FRH2nG1hnvmGBhStp9cPPY= Date: Fri, 20 Dec 2024 14:19:43 -0800 From: Andrew Morton To: Phillip Lougher Cc: Matthew Wilcox , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 5/5] squashfs: Convert squashfs_fill_page() to take a folio Message-Id: <20241220141943.8e63906eb73da5f29979eae7@linux-foundation.org> In-Reply-To: <7a9355eb-810d-4f5b-90ed-bf4f4ae7e161@squashfs.org.uk> References: <20241216162701.57549-1-willy@infradead.org> <20241216162701.57549-5-willy@infradead.org> <7a9355eb-810d-4f5b-90ed-bf4f4ae7e161@squashfs.org.uk> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7C99720014 X-Stat-Signature: 8wrsms9fg9qyqcstsnbmxiicos6wwgws X-Rspam-User: X-HE-Tag: 1734733152-623393 X-HE-Meta: U2FsdGVkX1/p+lA1zx3WPUsph4jEOq4eAnQL/00HWCSWkLC8QbOir72Rvm/4i9dYvF2euxMv7uV3QiNze2BT/teCooef05wYSFkMT0ZS406sJKqQl26LiWGZPEcoOVKfrURPN5CqzZURMAL/kqjW4wtRDpPnDPQkaTzaD+JgralnBUYP1IM2+YlQFK1TCt2H7n3lubPizr8LrTScf6+T/uWpiHR633bzumvFrXi/VeP238vOojRzEXWsNuFzPzmjzqFBsSDlsRZBfKptwYAJrlKIf0bL8imAyUfMwmu4uz3zXsfCX9K/koWPElbcjO/Y0tJacSZmGWzffkXdQP+znWFXjLQDbdqjI5gwDD43oo9TqQHDXETmYz5m4B9xPJQ3/jDnkkR/04MzTbBWAlQfNhFGXUP/2wQVX2GXlLJTgAGN3+5yCkuRA4FMNYsWlpLnROEi05zvwOHuT4ef1LzvFtvzSzDl1TmH3lMnqlyFO2ycTbmdtf6xkEZW4RtdXD+1pf7D9GfIdDhbtKhM35Z/yaVavmZM7W8xQSbu6I1W03q0t82+Mh4svoK6tSgnTB8UoHmgUb/+GP/faj/c01x5fvQnIfdRWU7uUBEUoptDpQa9gAyY/rRup+np572QE6ewoEHV5LiV4yMaDT5+ZZ1QTvDg2zeI62HhyX2KrVALqkGcbOLX2dc2Z4TBDLo2peRRB6jgD6NlxitzLPxEZNal8WOumrfwkSG+7QqbqWh0pJEVSWXI0w7VNkLL6ImpF6sYL+nFrZ+GepAQyS2ySVsfnj4KAHQA36BQxjlC4hl0IKqhH9xRIH5J6CAdGbr2MyTVkfKvRtd2v+B6qNzZJs5tTLXjOv+9HbTDyxkLKrtIVDwG8Akr+hlboiEXHjTNT1xSszdecYNov1oflFZKlJgqPPvOhSeyX19yHdlS3ruwSVrQKbRkLBdPdmiZr78gNlBrjNOMuIBcTK1TYr40oyK nxgHrCm4 EOC0OJlroSs8Nfi8xJqq3J9LkObI6ylGmxpM2r+p9gJ/p6VIXN2GwcQieCbjzIxG2W2H1cSe9qV+qp47LMX1Y+Dht8ZkeOEj0pws/tfqnJYP2/XqamPlowK2p48SBTSpXpGG581KSsuqc1OlRsUkeA61s709ZnKl1PKrQcIR4vQgY7Coy1hH5G6cfHh9dy3j/9e1HueETdZDSIojXJvUEXsdPUVE5pE+myudx99Fsq/sjFWBCrm6A0Wi4By41rUZOJHYF36PlSVQcf9+UMHYL+wmQs0MMrdzDggjutMWPKu8tas9WBK2Bd4xmO+M0Wb+Lptk70CElteEUNAFGctgEWAVsE+guRWqFK0t9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 20 Dec 2024 18:42:57 +0000 Phillip Lougher wrote: > > > On 20/12/2024 18:24, Matthew Wilcox wrote: > > On Fri, Dec 20, 2024 at 06:19:35PM +0000, Phillip Lougher wrote: > >>> @@ -398,6 +400,7 @@ void squashfs_copy_cache(struct folio *folio, > >>> bytes -= PAGE_SIZE, offset += PAGE_SIZE) { > >>> struct folio *push_folio; > >>> size_t avail = buffer ? min(bytes, PAGE_SIZE) : 0; > >>> + bool filled = false; > > > > ahh, this should have been filled = true (if the folio is already > > uptodate, then it has been filled). Or maybe it'd be less confusing if > > we named the bool 'uptodate'. > > > > Would you like me to submit a fresh set of patches, or will you fix > > these two bugs up? > > > > Thanks for testing! > > Np. > > Andrew Morton is kindly handling Squashfs patch submission to Linus for me, > and so I can't easily fix them up. > > Andrew what you like done here please? I think a v2 series would be best, please.