From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0648AE77184 for ; Thu, 19 Dec 2024 17:19:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90E296B0083; Thu, 19 Dec 2024 12:19:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BE916B0085; Thu, 19 Dec 2024 12:19:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AC586B0088; Thu, 19 Dec 2024 12:19:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5CD446B0083 for ; Thu, 19 Dec 2024 12:19:28 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 066E914171A for ; Thu, 19 Dec 2024 17:19:28 +0000 (UTC) X-FDA: 82912368378.03.C2DA63F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 12D22160014 for ; Thu, 19 Dec 2024 17:19:03 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jMA8lMwS; spf=none (imf08.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734628751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hD4px1JE4Hs8C37Ywe2qi4X3aSr37zS1Mt6jQs2kxto=; b=g58VlGXoYRZwmq71DCJBK1ARwwynQwj0EIoVg0jtEzwHjsEG9HPKFUWQ4tKEMWwedNlEes +HVHEACyDSxBvIHvVl3tyRJ+kGvXASjVsbpDlt8bGVNYPXyJhSmWI0MPwjMBC54c7JaIbQ NijwY0nOC1oVhdF4NTx/jjHDTkiqdVM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jMA8lMwS; spf=none (imf08.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734628751; a=rsa-sha256; cv=none; b=BKzMmdAgxJrqYPx5f6zdQcYNhzyWoihT9s54TwLKyN0Ar3l8jRdElQHMHcN0hf5zmq9b8f dHx2DLt4q0Y+lLEz8lIkPoO8eYSzv50kNo99O7sqXi6/hmhT9/Ep9YLaBjoZ4VVJ5VBi4F rAH4K2NS2HSv6WuZJOKuFl+LZvPreGQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hD4px1JE4Hs8C37Ywe2qi4X3aSr37zS1Mt6jQs2kxto=; b=jMA8lMwSy3+bHUFP+4fZVh7IPx FyB8T3nnJ+VnT7ZEnXN4F5h9lorBeRxAcY4z9Maf9ZBSgXjPacaS/BsCuz4mxMNgmCy3EixkzWxA8 9nBGzEYRwL6XhZtK8PGvIXWpbtgGjKa8UuZdrgNUr1gstWSzlDEZ4zghJ4X+5rUW+ExR2CzI8b/1g YgjbYJKE2JG9e/5b3h6i12Q8gw4+bdp4OGw8Yz1qz6fCcq72C9V4mGlNHIwG/Qn1QQ04br8S23m9g PMS2zOscxtTixVnQcYQzt7oYvJcMlPkATcO7LstZ0mhOYVVLul4cf4Ep3YiuOjwMWaSE7gfJig0Rg 0p7Jj9wg==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tOKBE-00000004Vjs-3SFX; Thu, 19 Dec 2024 17:19:21 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 0A1A23004DE; Thu, 19 Dec 2024 18:19:21 +0100 (CET) Date: Thu, 19 Dec 2024 18:19:20 +0100 From: Peter Zijlstra To: Kevin Brodsky Cc: linux-mm@kvack.org, Andrew Morton , Catalin Marinas , Dave Hansen , Linus Walleij , Andy Lutomirski , "Mike Rapoport (IBM)" , Ryan Roberts , Thomas Gleixner , Will Deacon , Matthew Wilcox , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, loongarch@lists.linux.dev, x86@kernel.org Subject: Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers Message-ID: <20241219171920.GB26279@noisy.programming.kicks-ass.net> References: <20241219164425.2277022-1-kevin.brodsky@arm.com> <20241219164425.2277022-2-kevin.brodsky@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241219164425.2277022-2-kevin.brodsky@arm.com> X-Rspamd-Queue-Id: 12D22160014 X-Stat-Signature: g6trj6c7krn36a9w38qaggbiixrr13he X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1734628743-828952 X-HE-Meta: U2FsdGVkX18hdm34GMwDxBpqfagrAuqdhPhy4arNFLi6zlxgkq0SH/WvEAraLtZGwBbZcL/Ct6VQ3947nogZDE+TbmyKgWrFYEvA8N34sVJ9vmPnFVt7UH2wUs+6HOp60r6Pptvq1ZKM8i1BFjM7mwuQ8BvxNuC6spnzbtus+r4+ZjGtCkDZk15kck/Y8HyKSiSmI0jK/5R3UMJc834czzeA5PJeK/f/fjv0LrUk8ptDl6QobUwfCcmwOvQDVT52vjNEXYAcrSuEN1G73wPJwvaMCgPG+mUvHH9B+Mz4mB/nYjSfM3SSEsmd/4IlAUChQK/CtF6IBtLFAIFK17F//bHfNz6mfrXFuiwNovTOCeWuVQUIy23wQwC5laI2VLvAasKm/2LMBmsrAWf/d9NlinRydDFyzsJtt48gxvJNjD/Pm7ae4PcCJeaG3NoD6U6t8PxIfGsSJdSEO3zO/19kCxzKPGgRZbjUgo3nUqUxuGUOQq6c6JyPW96GtFUoWfYqgP2dVgK8Vik8Tc9+A7MQlLmBmH34b+nJzsBq9oB09ayk6CsT7de7wLGdpbo0MJYsReOtPYl1CW+xr6KV7leN+o5/4ScF+V2TABtIxIyv95XnP7lyhAGji4zCdKm8a/GsOb4YuXIUallOmjrzTFu9rlsN/aaQs1PrGjY+utq6+oHMeAFuuN8/u9Bjfktt5s2FaLv64TgolYL9ufEkthNQsgzolDKEXTHl4bFijLq5mLOoBMqjRhm8X5fvdaRHqhadCLZERgFWM48xzzcdXY4JkmXENw6cSIbBgXV7vLChuxxTxp0oueCOxLirBYXzrup5+fFh4zo4ZMrN7201C63ThyeOvyGmXv1Tfrn2RM4MnacETPuBtdvmty4K2ZBbrXSpe0oFM7PAfouOirkmU2pFiZAg45BHM6aQUqw77R75ipd2+7idanz7S0leGjhgEqOomZieeqHeOMcaF5wiMrh whcRuuMm w6Xq2S7z+273tk/8he7XO3aw68MFXL1MxuwLKKe6FAtImyd7kW+gopAnm49tcjfues18kzM9w+7FJGDohDTTisbUr33aJrN1w/iA5FrZL8Nh5FDDqfxF8sx8NsxdaVe5lJdxpZA4HLC31Ggc/lJ5vyTzX+aFVfbXouPkjhw3HMxtBjU50rQNdqACu7WQPkxpCF5JUqwrgD5+xzbebyDX5Qoc0NMEcqHou1CXIuxHp4SJ5eSdUTf/fJiwmJu0Mi18tUlEJ2Vmn5I2gDyKKzKp2KmI15Z9TbbI1ShGo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 19, 2024 at 04:44:16PM +0000, Kevin Brodsky wrote: > Besides the ptlock management at PTE/PMD level, all the > pagetable_*_[cd]tor have the same implementation. Introduce common > helpers for all levels to reduce the duplication. Uff, I forgot to Cc you on the discussion here, sorry!: https://lkml.kernel.org/r/cover.1734526570.git.zhengqi.arch@bytedance.com we now have two series doing more or less overlapping things :/ You can in fact trivially merge the all the implementations -- the apparent non-common bit (ptlock_free) is a no-op for all those other levels because they'll be having ptdesc->lock == NULL.