From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA49AE77184 for ; Thu, 19 Dec 2024 22:51:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CDD86B007B; Thu, 19 Dec 2024 17:51:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 17DB46B0082; Thu, 19 Dec 2024 17:51:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06C606B0083; Thu, 19 Dec 2024 17:51:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DA8866B007B for ; Thu, 19 Dec 2024 17:51:16 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 580CDC02D8 for ; Thu, 19 Dec 2024 22:51:16 +0000 (UTC) X-FDA: 82913205396.05.287A85E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 851A6A0004 for ; Thu, 19 Dec 2024 22:50:50 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=t0rhhzjp; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734648659; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cujcYkCd6i7tHb9g+1RnZTWJMzNJy0+aU6N9ea6Vmgo=; b=kqXSNaaDzTEViEtMzvOZ0URu66RlrfNab06NdkFA/j9WwhCU11WYQU4znFFQuJYiNfCfsB Ps2aI4qpG5g+wdWr4vAOHQ9rttjoq1661Luzz1idRAZYfyYtyJdCmc2B1kIPB6f0Wugvs2 VSOhHNFsTPR4tLiR7S1l4UY/bq2XSd0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=t0rhhzjp; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734648659; a=rsa-sha256; cv=none; b=XxwVNCSsx6Zn/YrePbxtD+RYAK+8FpTMUHTx5SluR1F5KmjKKJ6bwAkpd5S+pAYDA38RIo TXNLkqlMQuV+N6Pc/+w9TkUyFm25s9+vOXytQTXzRSPC8vGP9K4e6wQeZuHqN9jxWYqHhp 72Rg8bjxXlW9brzyYskwSMQlDdlVNGo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A9DC35C6A4D; Thu, 19 Dec 2024 22:50:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBE18C4CECE; Thu, 19 Dec 2024 22:51:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1734648671; bh=vn2Y7HOGnDiERqHrmWj9W5nFrgVwON2deCzXDJZ+tIw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=t0rhhzjpz1vdogEA28Fuz6THqQkcz06UXa/pxjoJwkMHEOkW2Hoc0+OlDTF1h93YH kXPOg9U0/QVr1oW9unJNYie8W/5guioFlUO/vGigsJsCVETXNdy4yRVsOUoNUkUpAu H7efylqhoOToOqhPLENNK395OTBawe7wI9jBDNg8= Date: Thu, 19 Dec 2024 14:51:10 -0800 From: Andrew Morton To: Uros Bizjak Cc: Gal Pressman , Dennis Zhou , Tejun Heo , Christoph Lameter , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, netdev@vger.kernel.org Subject: Re: [PATCH] percpu: Remove intermediate variable in PERCPU_PTR() Message-Id: <20241219145110.a4815019ca69d6d5c36f1fdf@linux-foundation.org> In-Reply-To: References: <20241219121828.2120780-1-gal@nvidia.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 851A6A0004 X-Stat-Signature: bwzcgkabck7ihswmcqsst3romdg3yzyi X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1734648650-682197 X-HE-Meta: U2FsdGVkX19YRfuLL8LlmQOfsJr40gP62MsjUuEBM1H1iKJSfxip49Uy00v9uRxtuYAxKf7uvMzGVeMlAkJEDjoF1SjioFEBdFX8RU/SA7gbRUcnnWYhnYKincbiGylRm+2ipg2IdakXx8iWiY2kI40DB4EAquUAFbyJow8FQa2QGcX9dGkWvHEBACotZzHcSASq3SJd7whQz/TKD5iAkMwk8w+xnj3CAblD5NMNMSM/BbyAtRf7p8yXpYehk5iM0FDkKHZTxeilK/wie+g4ZjREDFslD0Lcvd4v6u0FPRJ02y+Z7l4VOL6RuGpJZPbsJ8MSzSTeIM5v/3DAV0fSoQbBnP+EUKqIswgYdmpjaNKRei5Ip8OgoZAKwaHhIm/KQVy91T+YP7/LbCz0JmvNzasvSRyx+Bdb/reItBUYO8nIcGrp3dYC2igVIVjf1jYSaND5bvXN5oInM/9lCmkQdIk86pHwKGVJTsebRLel9LojOgtXYdbLVhC0rMFns5ezRaYjOvkZEl0A7wW8G8C3o4HOMTIuc4bAJEMbWFB6Pw9oAJ2vODXnizkTnQ153YPBQiYQCo8xfX6zNQEE/kmniC6PDZ0j5VSIYRQJoyUwIO8+8CT7fiXuVIaVBnXZ+Qer7f9a/S2L8LgyRjzKZcADIG/h9e5qJMqAvbWvSBuAMxn2WaSyjm+zlQHv4STMYLxOSW33GzE7acq45zBohVj0m7k+DBJHnYv4wDhuV8fcJorKXsk1VS318kgtyVmoi8xTGAIX6zDReQkQkBlbLO+mkDsXMlf6RvYxP1PK0lIFCDVVQ/q4wvz89QYpU4edT2iNkL4n5SPWsNB2d4EWEircC99n0hrqR0JtEKc4Vd9+XigUx7j49vk+LMAPmRRrpMuVWMy0SHco5tEOwfaZSG2wx3T8CqjzZnMOV3UWWXEh4Kqp/qO3ilLcyvy/GOlsi0xkj31IU09yTz3XV+9ql19 63Rdee7d fhG5mG4ijfTP70Au337UP1ntbgKCbm1ppzrNcmsvK4YtuWe9v4wl9RKwgVzTva4PokGzMpg8cxL4/suP7tByV0Kqwrzc/Bl0Yk8f1oXK3LfkQ6f/LS1danHrr/40k2Y77eMxu+L3n0DHaMlUAPceKbJI6nlOFshImR9DOJ111tD7KTxsylx1EVcVhD+y27+U21qgi2vKgoOVnKUOSX8TN4IeXFBLdFRG+Z3GPsI9j/ouv/kFshGMxvSd/FTdx7hFR2zVjyCI9XJT45CqrEZJS3awjzdZLj5Mxl7IJEXiJfXsnIt5C7wH5EJD0ITjgc1p2OPDq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 19 Dec 2024 18:03:47 +0100 Uros Bizjak wrote: > > Actually, you can simplify the above a bit by writing it as: > > > > #define PERCPU_PTR(__p) \ > > ((typeof(*(__p)) __force __kernel *)(__force unsigned long)(__p)) \ > > Andrew, please find attached a substitute patch "[PATCH 4/6] percpu: > Use TYPEOF_UNQUAL() in *_cpu_ptr() accessors" for your MM tree > relative to the above hotfix. The whole patch series (+ hotfix) has > been re-tested against the current mainline defconfig (+ KASAN), > compiled once with gcc-11.4.1 and once with gcc-14.2.1. Updated, thanks. > #define PERCPU_PTR(__p) \ > - ((typeof(*(__p)) __force __kernel *)(__force unsigned long)(__p)) \ > + ((TYPEOF_UNQUAL(*(__p)) __force __kernel *)(__force unsigned long)(__p)) \ > I removed that final " \".