From: Andrew Morton <akpm@linux-foundation.org>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: Gal Pressman <gal@nvidia.com>, Dennis Zhou <dennis@kernel.org>,
Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, netdev@vger.kernel.org
Subject: Re: [PATCH] percpu: Remove intermediate variable in PERCPU_PTR()
Date: Thu, 19 Dec 2024 14:51:10 -0800 [thread overview]
Message-ID: <20241219145110.a4815019ca69d6d5c36f1fdf@linux-foundation.org> (raw)
In-Reply-To: <CAFULd4ZcSY+1WPn2T9dHVJZyyg1p+YaexQMJzAXHnCDy90j2fA@mail.gmail.com>
On Thu, 19 Dec 2024 18:03:47 +0100 Uros Bizjak <ubizjak@gmail.com> wrote:
> > Actually, you can simplify the above a bit by writing it as:
> >
> > #define PERCPU_PTR(__p) \
> > ((typeof(*(__p)) __force __kernel *)(__force unsigned long)(__p)) \
>
> Andrew, please find attached a substitute patch "[PATCH 4/6] percpu:
> Use TYPEOF_UNQUAL() in *_cpu_ptr() accessors" for your MM tree
> relative to the above hotfix. The whole patch series (+ hotfix) has
> been re-tested against the current mainline defconfig (+ KASAN),
> compiled once with gcc-11.4.1 and once with gcc-14.2.1.
Updated, thanks.
> #define PERCPU_PTR(__p) \
> - ((typeof(*(__p)) __force __kernel *)(__force unsigned long)(__p)) \
> + ((TYPEOF_UNQUAL(*(__p)) __force __kernel *)(__force unsigned long)(__p)) \
>
I removed that final " \".
prev parent reply other threads:[~2024-12-19 22:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 12:18 Gal Pressman
2024-12-19 12:30 ` Uros Bizjak
2024-12-19 16:02 ` Uros Bizjak
2024-12-19 17:03 ` Uros Bizjak
2024-12-19 22:51 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241219145110.a4815019ca69d6d5c36f1fdf@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dennis@kernel.org \
--cc=gal@nvidia.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox