From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 403DAE7718A for ; Thu, 19 Dec 2024 12:03:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABF086B0085; Thu, 19 Dec 2024 07:03:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A6DBA6B0088; Thu, 19 Dec 2024 07:03:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 935F16B0089; Thu, 19 Dec 2024 07:03:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 763426B0085 for ; Thu, 19 Dec 2024 07:03:54 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 007A2AF380 for ; Thu, 19 Dec 2024 12:03:53 +0000 (UTC) X-FDA: 82911572436.20.E353635 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id BE94C40013 for ; Thu, 19 Dec 2024 12:03:17 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=a7Tbwibe; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of mripard@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mripard@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734609817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZL0G2YAE5eYBemYaLgIjkJyizBBMpLXVBwgmoCj3NxI=; b=bnIVk3zyOwndGYH3o5VoXl0xj5vF21O4xFc+wEE3etkyjE1tMYbzWHZUxZKceWj92xRV2R P04Rs7yirOy27A3PjthPN/cFaNmpMOQPiLPIdT5huTZ2YpMjLRKTiYZzmEtOG/3MVUV+wd xzTyMpr+yPKiocY77DQEjglVDra9DA0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734609817; a=rsa-sha256; cv=none; b=sDsdL25qhxr8HFyTuDQtnwyX/dHVQnRQbkcSEgp8uumQ9Cp3Vj+Y39HJemCWmBwFqGnnqs dOPQcgg1YYvirDqkTWiIHpfkuCmc5swpk1GxakPpG+o0s3CiIrHZIWspUMd7NqPoiWVlMA 48iaAuxPLcTlONawYDwfouKvYz7CWM4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=a7Tbwibe; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of mripard@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mripard@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8FB555C5F8E; Thu, 19 Dec 2024 12:03:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9A7CC4CECE; Thu, 19 Dec 2024 12:03:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734609831; bh=8PH/DWN/c9/9fyd6ftKv7/M7QYHtzh3//Hu5Mz/KnLA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a7TbwibeVI0NjEa8csMF5UCh16/W5N0o/IA8zcK/qH0nhrO2qQMzSTTu2TAQlrP0i NO4bNCKKLvBC9Dnd5P8lnnfSZN8BDFooO5XHmXspnbK6jEI4K4u/2/wXedieeBl4vu Je8w0fpycJY+eTP48dDWvidxUvIYtRtXsa31OjHVuuro0hQatBHp2SY4WaxnVTjlKV DNs4gIHh57AJt77NvCbkH1jfGfAgIg23V38c1RiLx2otTccQotVbipKeSVdeob9o1f hHUXWLt+2A2WMYj6ijLMuH6VtM6sgehOZOEwI4OPxbLadYDFVIJWPXhfs8BwWPyhMK e2Du5ncTub0bA== Date: Thu, 19 Dec 2024 13:03:48 +0100 From: Maxime Ripard To: Lucas De Marchi , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , Rodrigo Vivi Cc: Maarten Lankhorst , linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Tejun Heo , Zefan Li , Johannes Weiner , Andrew Morton , Friedrich Vock , cgroups@vger.kernel.org, linux-mm@kvack.org, Maarten Lankhorst Subject: Re: [PATCH v2 4/7] drm/xe: Implement cgroup for vram Message-ID: <20241219-banana-pudu-of-radiance-aa62db@houat> References: <20241204134410.1161769-1-dev@lankhorst.se> <20241204134410.1161769-5-dev@lankhorst.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="5iyklvofd5jx5ou2" Content-Disposition: inline In-Reply-To: <20241204134410.1161769-5-dev@lankhorst.se> X-Stat-Signature: pkyap6xx63uubphwtemeifu9bdx4dr38 X-Rspamd-Queue-Id: BE94C40013 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1734609797-602267 X-HE-Meta: U2FsdGVkX18PtOQcdF/gGNb5r/2bHFno1andfHwqIjpjbkQdcfvYsPcjpA4flEEG5HjL4lk/FaU+aEOseJbO+vggwsee761BlQJIYBTS8/qxQDN9E3QbyiFrFWh2olwaS0mSU58GTD0x4M+rt/ko2Oyj44Pr8vRfPmD52ez0i1fDapfPlUfmASO74suu5RU+uXGM7CAXZBmLA8d25lukc4RtencHqVdgSposJgSIRZn4kFY7JZqq78vmIH/HaOBuKMjAOU02YWkq8Spx7bzAr/WFJr/e12TYVrECZXb185RRzfbMGhy85SyD7yMMiqSTnsiW6JkoiK+qHy0hymkkDJhntrkpZ7OmuYU2a/YrP5bwhmNzt3ktWskuuXe6raYe5sNV9n4gfpvBGM0trSlzqvUgCtAo6+K7SGKIBkKLQSmwY6TqKnSQ4Jk8Kr9jST74f9ZijTCtGjUq6iDO6lgL8DGStteZK8VAwsdUebnuHQVEPl2FrvX2NRmBxjK4FyiKLuCuMDDCXR3ZW44XkijjozxnDAar8Jc3bxXqpNKnXN23tsstUnKj+uLQKnuAbVtjpBlCaurDRLp8HlZY4n8wKv7eI8WBqeWFDAFGwioQnUXgtt4P9yM+3J9dAG1AM6pvRW56ovH5UHQW8GdcYYdLJnlxgn5zEnG1hOi4/tYS+w5ZJrJZthuCUhDTCIceZJW/NWLRQyLMgQIezg//woLJYOI+gwQJzMdsH8Rm+duTOFVMOwzk+vGMDRLfu8pLlCHwDWGqmSR+mIfHiEhf213SSs0vY2W7Gvr7LWm3eUZA1Z1gz/uTdXda4UrbNWVtBqd0aCIMRTn5IIUZXcKbbYBGH/Zoh9A6KimvA4NSHdIKmz2ty2gLtlkC+dV0hByBTdYbEhOCHW70Rev9I3KWoacRqdJ+DBVRM5J0KNNIdEKs+bX5TaXcmmuKcJVwv3hzbt+pVgPu8vGu7yv8eHCOfcY QZa82DF+ EkCdB4oB1IP1zvuam2p9MDIbooCMlvTJcMb52zvayzlE61ASfbQJn8OGExVmmJ7ku87bHYptYlAIQ9ROk4vFfGlVSnONyk7XTSnecCuvzADo/vKHrsBroKxkgBF+UfTb3nDAGPDuF/V1KswPtG8Op9q0B1wQjp/qZ4OromuvZThC17S/cP4yRzw2szQSvanA8FSCyqyStMlEObxbycQwOw9UGyBLQPWDqjK21gxqSmVU1hVSLssU0nFZ4kYYc6WSCNRGXaJvVpGyIrtHBc9FNOUgY+Mak44cRwuT9uzfLkPeyBv6+dwxRSJG1aVNwbQsDP9Hcoz2al+1dXnobuhyEjuihA2D8G1hvJqOUG88m+kercobh/hWR7A5WWtFn7kP/qndf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --5iyklvofd5jx5ou2 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 4/7] drm/xe: Implement cgroup for vram MIME-Version: 1.0 Hi Lucas, Thomas, Rodrigo, We forgot to Cc you on this series, sorry. Could you have a look at it, and especially the following patch? On Wed, Dec 04, 2024 at 02:44:04PM +0100, Maarten Lankhorst wrote: > Add vram based cgroup eviction to Xe. > Most hardware with VRAM uses TTM for its management, and can be > similarly trivially enabled. >=20 > Co-developed-by: Maxime Ripard > Signed-off-by: Maxime Ripard > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/xe/xe_ttm_vram_mgr.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c b/drivers/gpu/drm/xe/xe= _ttm_vram_mgr.c > index c95728c45ea48..f4a16e5fa7700 100644 > --- a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c > +++ b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c > @@ -5,6 +5,7 @@ > */ > =20 > #include > +#include > =20 > #include > #include > @@ -311,6 +312,13 @@ int __xe_ttm_vram_mgr_init(struct xe_device *xe, str= uct xe_ttm_vram_mgr *mgr, > struct ttm_resource_manager *man =3D &mgr->manager; > int err; > =20 > + if (mem_type !=3D XE_PL_STOLEN) { > + const char *name =3D mem_type =3D=3D XE_PL_VRAM0 ? "vram0" : "vram1"; > + man->cg =3D drmm_cgroup_register_region(&xe->drm, name, size); > + if (IS_ERR(man->cg)) > + return PTR_ERR(man->cg); > + } > + > man->func =3D &xe_ttm_vram_mgr_func; > mgr->mem_type =3D mem_type; > mutex_init(&mgr->lock); > --=20 > 2.43.0 >=20 --5iyklvofd5jx5ou2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCZ2QLpAAKCRAnX84Zoj2+ dql1AYCyzH2b+9id2ZtcdDKPRcjpVHpPPKa9YUlwBXCWZRc2Cp/OdQB0XUAnWdRP SVvncNoBfi4EkuvuzdkaXRQICUAD2hMvKBypNAKgio0vUTBwF64j2WVhsNWAhFLR Pj9H6miOCA== =UMTT -----END PGP SIGNATURE----- --5iyklvofd5jx5ou2--