From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 817F8E7718A for ; Wed, 18 Dec 2024 16:45:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D47996B0088; Wed, 18 Dec 2024 11:45:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CF6606B0089; Wed, 18 Dec 2024 11:45:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBE756B008A; Wed, 18 Dec 2024 11:45:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9C3616B0088 for ; Wed, 18 Dec 2024 11:45:31 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 584E7B041F for ; Wed, 18 Dec 2024 16:45:31 +0000 (UTC) X-FDA: 82908654654.23.20B5542 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 9A4891C0011 for ; Wed, 18 Dec 2024 16:44:55 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Y50Yqyve; dmarc=none; spf=none (imf20.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734540314; a=rsa-sha256; cv=none; b=vi9QTnUXyy6dQE36KMENp47OVwVuSi8Y4zTkIU+lo0e99ay2Ja80M1nkZWqkFSNhB4sEKo L9GTlPv4ejrzNkgK7RIbj/aQodGPy0AuFf8r9+Ts+SQdLYg+w6v1wG2xf33a+8V4KTAHBD M8JFpInpleTIrxOYL1letrmbwfIML0o= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Y50Yqyve; dmarc=none; spf=none (imf20.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734540314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q9h1y8HNwaX+erCAdQRplaoG7Vs3tlrGQ/uNEMNyDdY=; b=yJCFkXRHxuw+uJMK162nR6Q2xLqSAdKfeY4LfO/Igexf50dVaoZ/h4l6UNs+EcIhhW0DBe Uj6K1Qg8fgtT7DR0AAQc0xYWL+3ZV+4AHTX4reaN53rD7a66Wy00n8IHly5LVk1lpb5XCw ov4AghuAsTO4BlLtf7IDZJZEoirEerw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=q9h1y8HNwaX+erCAdQRplaoG7Vs3tlrGQ/uNEMNyDdY=; b=Y50YqyveEkhyROAq+uqLMYCfT5 9I37rSTg+XkF9F6ymf4IBIlKLFmVgHg1ype2zNE5xfUh8eOTqTUy+SHFxsYAywEHXHLVJmNs4quYZ ta5gngwSvWTfHRnvHTjRkvS4xh48xjwR95OCjFr6IuWgwoblUE0u1kXbfBeNUn/0/hVjxFk+DyxNT mk5Uy/sLeiBFbNF6fZIL57dZqBXZlfaCYc1sLkQV0/SjRn1mG23LWOBw6UmCRVSJVRnhuRVyJofOt 2UB51LNPzCJ8tnuL/HAmLKZcYj3M9RscrjloUx0d/cRM6l5WNs+jYGd/kWQJAV3Vy0CJCu1zUXiYw pyqQIK4w==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tNxAm-00000000IIl-14Qq; Wed, 18 Dec 2024 16:45:21 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 7AA9B30031E; Wed, 18 Dec 2024 17:45:20 +0100 (CET) Date: Wed, 18 Dec 2024 17:45:20 +0100 From: Peter Zijlstra To: Qi Zheng Cc: tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 14/15] mm: pgtable: remove tlb_remove_ptdesc() Message-ID: <20241218164520.GK2354@noisy.programming.kicks-ass.net> References: <79b20df78eb81a9cd07e3048f2d4d63d98759b4a.1734526570.git.zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <79b20df78eb81a9cd07e3048f2d4d63d98759b4a.1734526570.git.zhengqi.arch@bytedance.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 9A4891C0011 X-Stat-Signature: 7p5t35u9m3iwk3z5r56r5mnquo3aua3s X-HE-Tag: 1734540295-829089 X-HE-Meta: U2FsdGVkX19oQnT09PQo7vInOf1y5wqUbdpuUYI3IkzvRTxp/lfOUtJztYP2OU87gvM4yYtyt0dIDiuDdn6QLdvj98uRjEB3CyqYJ1762dXG6JaTVqbxCKCoOnjbT70u9J5T2hfRKIxydrYAr4rIi7emFyxOz4WQadI4f4zCPGXC0VNmbqSdBE8QHrbRi3+KcF4ahmpfzSxmsIKm12RzlO8s7Te5iwlN0WEZz96J4DQ6qveLbyefqKdrsDD7YlAk541vgzawJI5rGb2jb9UywvyjxY0WvOo3JtUWg0XvGOVKGGKDOR5XE8fG2H9qpwg1jkTCNOktxS6zF/CAQCO8v9VSCj2UgL3rPGexnJIqhgRRc8sjSXzekp09gC3g1NE3rdK2z4A6t6onmchImSs5IiOfDl6QrejCrIgZiRKacEEaIJLzlq9F2DF2vcZb2oFrHU15TzB+sytSOgbNiMRcl7S7S59cM4nXaiZRjeh8PeKJBeeSjZBPM+ieDGLq28/XH5TqwjpyWSHPihG8szb2A2T8gN7q3fG4q1PkbBhHbcwZ3fPOdfqMT6VjOYN37fQK/zLVD45LnwBB829fAq2UcT5czPuwbZV8NmY3Y8jbJHFQFKLiwyNVjyzEHZxi4H8H1LGiXfvJDXsT3JOzm4qG0tDXPtDwgcRGSzne7Je+r0ZFGqLDRYZflajRlW6CQ7HpynWLhoKEAKvFoTOT4CGZWTExjjMsgDAePeox443hDiqjgySjsHHJ3fl/GSGbtmZWmhhhV2qVYTU0QqCOZnrjiFna3eCg9GPfj7ShkMo4BLQtjyN5LvZ+XV41Kzr0B5R3HqZ8ZXK8IT1OOlsuCMagVU/vFkKWdvw5VvIsmOmR/P0vOLj+P8E7PICw8mG1VOjqxwJrHWUNi0wdGaPZwOiv+lQX4w/TgGmR3l1YDzvbtzr17UIzzuVBXLzOSOOhKpYRIcgRGrfFlSUYylr+Rve 1x9t+81U SjGNGZyn5RKQXBOYR7w6sNPtA25Jt0cBvK6pdragSpUPqP8Le7apqPgeGomW0WkzoaRU4CWes6hy3IWXR3ASOcbgHQoUbFhZC9cH7SAxUKKoADcdC8I2R3LsnIYn3s6TQBwK4DsWJs8XJdy9yGh6P5q3FsXVmLsoBENVZngEYpFPI6gVYJtaQuiKvEIr16GY8dVHibD3MvEJ32axMzTxQVeNsNtdd+JUARGNIg07zEPokyH0yVqwC7QYlDkNX7fjzfp8JtHFiFN6mzpVnAbD/+YKFAWU6sNpVJh9UHip5CZdNYRZLTKA0DkixRw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 18, 2024 at 09:04:50PM +0800, Qi Zheng wrote: > diff --git a/arch/s390/include/asm/tlb.h b/arch/s390/include/asm/tlb.h > index 7052780740349..fba11949dd2ea 100644 > --- a/arch/s390/include/asm/tlb.h > +++ b/arch/s390/include/asm/tlb.h > @@ -86,7 +86,7 @@ static inline void pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, > tlb->cleared_pmds = 1; > if (mm_alloc_pgste(tlb->mm)) > gmap_unlink(tlb->mm, (unsigned long *)pte, address); > - tlb_remove_ptdesc(tlb, pte); > + tlb_remove_table(tlb, pte); > } > > /* > @@ -105,7 +105,7 @@ static inline void pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd, > tlb->mm->context.flush_mm = 1; > tlb->freed_tables = 1; > tlb->cleared_puds = 1; > - tlb_remove_ptdesc(tlb, pmd); > + tlb_remove_table(tlb, pmd); > } > > /* > @@ -123,7 +123,7 @@ static inline void pud_free_tlb(struct mmu_gather *tlb, pud_t *pud, > tlb->mm->context.flush_mm = 1; > tlb->freed_tables = 1; > tlb->cleared_p4ds = 1; > - tlb_remove_ptdesc(tlb, pud); > + tlb_remove_table(tlb, pud); > } > > /* > @@ -141,7 +141,7 @@ static inline void p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d, > __tlb_adjust_range(tlb, address, PAGE_SIZE); > tlb->mm->context.flush_mm = 1; > tlb->freed_tables = 1; > - tlb_remove_ptdesc(tlb, p4d); > + tlb_remove_table(tlb, p4d); > } > > #endif /* _S390_TLB_H */ AFAICT these are all virtual addresses (still) > diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h > index 8d6cfe5058543..583e95568f52b 100644 > --- a/include/asm-generic/tlb.h > +++ b/include/asm-generic/tlb.h > @@ -211,7 +211,7 @@ struct mmu_table_batch { > #ifndef __HAVE_ARCH_TLB_REMOVE_TABLE > static inline void __tlb_remove_table(void *table) > { > - struct ptdesc *ptdesc = (struct ptdesc *)table; > + struct ptdesc *ptdesc = page_ptdesc((struct page *)table); And here you're assuming they're page pointers. > pagetable_dtor(ptdesc); > pagetable_free(ptdesc);