From: Kemeng Shi <shikemeng@huaweicloud.com>
To: akpm@linux-foundation.org, willy@infradead.org
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-nfs@vger.kernel.org
Subject: [PATCH v4 3/5] Xarray: distinguish large entries correctly in xas_split_alloc()
Date: Wed, 18 Dec 2024 23:46:11 +0800 [thread overview]
Message-ID: <20241218154613.58754-4-shikemeng@huaweicloud.com> (raw)
In-Reply-To: <20241218154613.58754-1-shikemeng@huaweicloud.com>
We don't support large entries which expand two more level xa_node in
split. For case "xas->xa_shift + 2 * XA_CHUNK_SHIFT == order", we also
need two level of xa_node to expand. Distinguish entry as large entry in
case "xas->xa_shift + 2 * XA_CHUNK_SHIFT == order".
As max order of folio in pagecache (MAX_PAGECACHE_ORDER) is <=
(XA_CHUNK_SHIFT * 2 - 1), this change is more likely a cleanup...
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
lib/xarray.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/xarray.c b/lib/xarray.c
index d0732c5b8403..3fac3f2cea9d 100644
--- a/lib/xarray.c
+++ b/lib/xarray.c
@@ -1022,7 +1022,7 @@ void xas_split_alloc(struct xa_state *xas, void *entry, unsigned int order,
unsigned int mask = xas->xa_sibs;
/* XXX: no support for splitting really large entries yet */
- if (WARN_ON(xas->xa_shift + 2 * XA_CHUNK_SHIFT < order))
+ if (WARN_ON(xas->xa_shift + 2 * XA_CHUNK_SHIFT <= order))
goto nomem;
if (xas->xa_shift + XA_CHUNK_SHIFT > order)
return;
--
2.30.0
next prev parent reply other threads:[~2024-12-18 6:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 15:46 [PATCH v4 0/5] Fix and cleanups to xarray Kemeng Shi
2024-12-18 15:46 ` [PATCH v4 1/5] Xarray: Do not return sibling entries from xas_find_marked() Kemeng Shi
2024-12-18 15:46 ` [PATCH v4 2/5] Xarray: move forward index correctly in xas_pause() Kemeng Shi
2025-01-27 16:21 ` Geert Uytterhoeven
2025-02-06 6:13 ` Kemeng Shi
2025-02-06 7:34 ` Geert Uytterhoeven
2024-12-18 15:46 ` Kemeng Shi [this message]
2024-12-18 15:46 ` [PATCH v4 4/5] Xarray: remove repeat check in xas_squash_marks() Kemeng Shi
2024-12-18 15:46 ` [PATCH v4 5/5] Xarray: use xa_mark_t in xas_squash_marks() to keep code consistent Kemeng Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241218154613.58754-4-shikemeng@huaweicloud.com \
--to=shikemeng@huaweicloud.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox