From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7228E7716A for ; Tue, 17 Dec 2024 09:02:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5447D6B008C; Tue, 17 Dec 2024 04:02:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CC1D6B0093; Tue, 17 Dec 2024 04:02:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36E298D0002; Tue, 17 Dec 2024 04:02:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 198636B008C for ; Tue, 17 Dec 2024 04:02:32 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C2E8112055F for ; Tue, 17 Dec 2024 09:02:31 +0000 (UTC) X-FDA: 82903859178.30.E1AF75F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 3139C40004 for ; Tue, 17 Dec 2024 09:02:05 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZbQ14THv; spf=none (imf17.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734426135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6Jv+ZONtdqzGZ4nmes9OBiDMW0hfpFb7vEE9LvODlo0=; b=fYnSbgA0lLm9MnCJtNJOKXEIGlDRNAMCI2p+jTul/PUlefWYx8/clRsfUqNLKDAqLUcOGp iYp3TSAXGDLsk6/VrMd9ygcO50K8+9wDf0ycnutdQrpJquVmydZ8ZoxCI3ukoJfvW4g0ql rIoBIYCb5woz1zgui3aQpivL29OGoBg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734426135; a=rsa-sha256; cv=none; b=cHFdnmJEbu1Xcrol2rs5w7fAt45gUJ+ZUjaGBJZKN7E6e1H4LgNQIK5HGHXkfVCBuT8CM9 1AedUILd5tBxGCHAav/PSY5hCOUmEfx9o8w8dg0YtZKYojypRmAh5NtAS4NnB2aKNk5VBt 913qlzcNASBqmxOP+EP+3XLhT0WYx84= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZbQ14THv; spf=none (imf17.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6Jv+ZONtdqzGZ4nmes9OBiDMW0hfpFb7vEE9LvODlo0=; b=ZbQ14THv2aZ3fvyVzP4VRJv8q/ wIFOlt8ftGbrRfJlt4wNRPquLm0w5eFYabv6rDrSoLmV/veg6VL2BAhMGmKpQwQvwDMKFO7+pS76T weGr6CjdCFKTBxqHqSygIc12hM7MMds2Kre/0YUc+dkBKyU22kWHQa9nGJIWl9iDBaJRAssn3hgl/ EwAqrojDg5ihuWz86FwHFbV4o6twKWImaaqRXezMwINpheLv/PkGmVGZ2NT+5684bW+fE+UWZhz66 XEEwR0HqhZ36ImvAxZ0prGkdWqF0vgsbo/64S1CRMwTiyTzpL+uKmHCeYuSCul3uZY2VgvZF1lXVG 4JJCRETg==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tNTTC-00000005vsK-2hcd; Tue, 17 Dec 2024 09:02:23 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 280ED30015F; Tue, 17 Dec 2024 10:02:22 +0100 (CET) Date: Tue, 17 Dec 2024 10:02:22 +0100 From: Peter Zijlstra To: Qi Zheng Cc: Vishal Moola , tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/12] mm: pgtable: introduce generic __tlb_remove_table() Message-ID: <20241217090222.GJ35539@noisy.programming.kicks-ass.net> References: <271e58cd4ab808c4f402539b76d5916924e2bc6f.1734164094.git.zhengqi.arch@bytedance.com> <20241216120043.GA11133@noisy.programming.kicks-ass.net> <20241216181225.GB11133@noisy.programming.kicks-ass.net> <6666f651-2a59-40fb-b984-60669d4fdaa2@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6666f651-2a59-40fb-b984-60669d4fdaa2@bytedance.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3139C40004 X-Stat-Signature: 7rc34is38ocpa5wmhgzaz8u8c41mfiza X-Rspam-User: X-HE-Tag: 1734426125-907897 X-HE-Meta: U2FsdGVkX199uZhTxVj1BEsAErSM/Zg+rcVsnr214nR6KfauUPqbqRHbGBymOzP7kvbGwYojiJ0hE/+omKdjoxUKafu/rOuod944dnFMhRHSgBj+GXHlFi7E8Cba0NHh5yDoMDCDQHtlpO+BOg0Qi2gk64O5suvWOsFesMeunU3owAAnoXg/Lt96lOM70hYh6ab+lOUQpS/CyqdQgSlE3PvAbhFDkRuiOZ+PTHBUeye5idDn/SalUaWPI0GsDXUYPQr2gkzCug4CEG2mCEpufGQJhWocCOfo44Z0M0D7/BVVtbqS4VvPK2HfKH/jpE56XdkszkDUZtVNTJCf24vFojwScaoMHwxdt0QToiFWtUqhYzK0pHWI+cOGix6ecqbm9lE1Wz+nw0HUFm2dylsfvRav/G1EnbiS2H4695ePQ6vNYU1bK/I43uTedlRP6k0rtH5MJBqhl+OdFLNCNu/nP6E4HdoleRO3X9cpOJLkcpfEPcYLv0RZfwlcfomcPPqjtHDcjNOICyBPvZkb3miyaT371feWnV/laB3dSAokgwUPI9aJHmZQq0LdaC+AkzCYzDiOgSr7leqFBHlQq6kiIHX5BmJIxpxqIQ8dK4MUOVMTLTPE8RAyJmbKdRY7FuUAV5Z5XOs5ZN7Zq7AYK6fMHWIi3PahWvkD2WqH4O2jOUOr0UcvPo3dGqqoqtP/C2lV3KrH7Do4fFB4H9xHOqHaZAq26poCTk7BUHnwuAh6OI3LR8vIkIk0qVCCsX7oLOPNZHQjHDkNxUz6WwFZrhrLzdJ56kCTdvwvZxlGr1bl5x/IehaZ3H8Spfx71sIf7d5wwmH0i7mbrHcZSGLgrgsOWRoXxxsgx9n5bBCpKrbcU8w1YLkWdLyjRdCfl0RJBx9Ymc2EtFNt8xgMP+AzYxl8/kQriUD23An2QncyDT/nM6Eqv/6foKuVDERjuvZeC4xuq5pxA45sOykgvUrocNH Y70SR13f K7AWHAiPhq5foHyxke/430RwVG9wjiUn60T5U2anLxqPTWf0Ji1MuF06AJoQw3DjlYuyrKXJ+aN0ZXgBujt5Q+DFpXwLGJCtZaUxtDgz/9B4xZn7ovnRZ5KndNyXmqNplZhYd3fjZ2zWu5zIoLtZuvN1i+9+xzDHjDl4q1cM6OZMPOnZgT28T8urQV9hEomEFISNPgCy/V8ZMfIt0adlMWUUkWuLSnBmVMBYxvRs16dgZpLbV/ebkdcnpslm1Cz8q4MnyuBMAXdfwlY1hrmAn0Ine2d8Ji0tqL3F+NBs3lGg2a2++0tTwTlvD1w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 17, 2024 at 11:42:02AM +0800, Qi Zheng wrote: > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 497035a78849b..11829860ec05e 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -3064,6 +3064,14 @@ static inline void pagetable_dtor(struct ptdesc > *ptdesc) > lruvec_stat_sub_folio(folio, NR_PAGETABLE); > } > > +static inline void pagetable_dtor_free(void *table) > +{ > + struct ptdesc *ptdesc = page_ptdesc((struct page *)table); > + > + pagetable_dtor(ptdesc); > + pagetable_dtor(ptdesc); > +} Right, that works, except you have whitespace issues and I think you'll find it'll work better if you don't call _dtor twice but instead replace that last one with _free() :-)