From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 162D5E7717F for ; Mon, 16 Dec 2024 22:00:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A14F26B00B0; Mon, 16 Dec 2024 17:00:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C6A46B00B4; Mon, 16 Dec 2024 17:00:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83D706B00B5; Mon, 16 Dec 2024 17:00:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 641D96B00B0 for ; Mon, 16 Dec 2024 17:00:31 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0E267A029E for ; Mon, 16 Dec 2024 22:00:31 +0000 (UTC) X-FDA: 82902191274.04.DDA043D Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf19.hostedemail.com (Postfix) with ESMTP id 78DC61A0023 for ; Mon, 16 Dec 2024 21:59:57 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=H6U4LrpO; spf=none (imf19.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734386401; a=rsa-sha256; cv=none; b=UBKCER07Ea9lus6NZ7ubjg+mggdsoScYtH2+PIIZ8kdku0G+Rr1b5WPiex9e8UTnSJQ9va K6GmkNMrFq0YX9bMhITOxiyn5QkyuyNRGQk2TzJoYvv2FFdU2XNrfS/hBSZL0I5BIN2INB Xm/hjGDVv2PCbjmjhmiX8EHbAYko49g= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=H6U4LrpO; spf=none (imf19.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734386401; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WwOpWuV55ttk34xYcb1itv2pXV6N2/L1ZVzPXCDpyeQ=; b=QvDvgMeN/49IgSJEnf/13SZPxGOrTyVv/XZOQiu0AOCcbhlKtsCV8A12M2TLPf/7+Jx3Ee geLrT6NgQQD1GkqliyXxZYlxHWwXPoZvlmxVbNPAgFhBn9TasIam5DGiGZRTQuLXIxC7Do ItA6LpUGhoujYpSzPZv4OdZ8pBWRhuk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WwOpWuV55ttk34xYcb1itv2pXV6N2/L1ZVzPXCDpyeQ=; b=H6U4LrpOIcLlnxGaP+ICfOph+/ 67LZWB1HlA/0l84tIudHNVmWaiG9IoA/dx8X7gT6kapc0itYO4wafCoI409mmqgnZ+r8jMbyf/JJo 5Mlg0P+KsXL9VCF4SSZ5bWDmV+u3S13TrzRYeSqSo3ZfpADwfxqyz0pu4FljjG1XKKgB7UMQQTpY5 AfzpMXJ3LXnt0Gp3c518vw/eLAlnL20YCJNw+szUqe2D5IynUHM5VQK8Reb05tkqgQvwOb0ovZ3k8 ch+uCqGzeA0bg9uoVLrVQ2GQLZek+zx7J1jd50JWGsQQ9leCPqWsNPoADGMb40KQyLBUbLJcAE2d1 3jGNzUOQ==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tNJ8L-00000004wzD-1zLy; Mon, 16 Dec 2024 22:00:10 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 2BD4230031E; Mon, 16 Dec 2024 23:00:08 +0100 (CET) Date: Mon, 16 Dec 2024 23:00:07 +0100 From: Peter Zijlstra To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v6 10/16] mm: replace vm_lock and detached flag with a reference count Message-ID: <20241216220007.GE9803@noisy.programming.kicks-ass.net> References: <20241216192419.2970941-1-surenb@google.com> <20241216192419.2970941-11-surenb@google.com> <20241216211520.GB9803@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 78DC61A0023 X-Stat-Signature: 8sey7u4d77d8wb18qs5qz4gztn11dsdx X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1734386397-236381 X-HE-Meta: U2FsdGVkX18UjrFKicfUwRQk/XISUvgVAU0AqQIwjcw89y67xLMQqm/saj75udIA1bmuKUE2UUL4clNohIgElmBbTl6eSwyuLpXdNghJ5eVBFZaaE4R8FPRVKEvXL5w0Pb5IFltJJHvwR9m5D1maWXUTMsoF0WnvNWTGb0pjAi1rcwhuDF11GyuagAZ2QlNrObCjc0h86rT4lXgiyWxAAxRC/WZVgbbQh4SL9+QzGm0iOgCtLjUxW4y9kQrGDoWfHSxH5nUh6BZ1KFo7VQ2i0pHyBoi459G9cR1wDLXnQvQHUKNHNXq5TOLib8FfMP0rVjIjwY/K3Rj9nFNSNQB6gUX8YYXfBKHGImRqT5vWHsNx0gAxDWnNpTMiWOBh9iup3QLeLDDhcilZWRmn2hIuNkSCGAfRmdTrNrlHeKkXg8n+T67j7PZ8DtYldd+B/kGRyLaZNfkSe9in3O3YPSOmF9Rx1mjipMUsvEPgi1djFs1Xo4Xr9AL7arscIeuYzJzClWO5ed5aaah9CkZ+dWwgkUOnYAaMfKsTrMb+5O+B7w7oFFIZeR1t/7boX4X9sEgPhNeDL7uVel6vYm/jr1OayyZxCstCmnNwklDBP++VoXRczxpF1fpM7+fVCgBaYuwxfQJPrdNEFz2djhm3I8ajX9l+WvTb60grdY+jrdWxx+e0RD5Pz2yCXrygFYE90RotcVVfU/5+1umQi069CILnaH7w+aMvTLABsC1XjkwZEepFsAyqWVN91IDwBEaHd/oVLmTPw8IYUHRKWybrqu8jSz6P0Z+TbmWA3hlDi5vgirEbgyH/zjsC+ALS2wnwtO1QjxVZ6WiqWCVU7zhGvYJrIx6ZMCX9ANPh7Zh1qT9Ia3rOle1tLuYsYqYbHqm7t9TyxBK1Z9pvBD5ZxR4/HlxesqLl3XIODFZSas9eP8q2djx7Ri1VJahTAfprVGOvTRxj7YpEfdbRAxKI3HaKBm/ 3/WQAR9i wRBrZ0GzYb8sjq7k6veqMaYvKkncNq7lGUXvJtehiYeZOQNQMW69jXrkftuNWCxDq4bdIiQcbnbp0BgjRj/ZWTuxdZv7qsAH/VYB/Yf5gIy4CKCaEvMADw9kp5xHBSfRyHBgPE9HxEpgKOcBjaHJxkH/9ckO1RMVmak5ya4kJ0f/bw9VZjHZNSTOaJWt4ZxVx6BiDlt+L5oL+aYizq5RhNpbqECJoZjlufaoctbmdw4EHLWHLEzcPxcC6wSvQnPgxJzcY44cR04m0ic9mOyCEc+eg9Y2WreTH6okrVWu7ieVPaAAaHeTvMWEjxKxSNtfH3goGOzD6l/nYhnd2ui+PbLMLVVuJeRbKcgod5xJtcCTMTnQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 16, 2024 at 01:53:06PM -0800, Suren Baghdasaryan wrote: > > That is, should this not live in vma_iter_store*(), right before > > mas_store_gfp() ? > > Currently it's done right *after* mas_store_gfp() but I was debating > with myself if it indeed should be *before* insertion into the tree... The moment it goes into the tree it becomes visible to RCU lookups, it's a bit weird to have them with !refcnt at that point, but I don't suppose it harms.