From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDEBFE7717F for ; Mon, 16 Dec 2024 18:12:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 411E36B00AF; Mon, 16 Dec 2024 13:12:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C1F86B00B2; Mon, 16 Dec 2024 13:12:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 289906B00B3; Mon, 16 Dec 2024 13:12:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 09F396B00AF for ; Mon, 16 Dec 2024 13:12:38 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 94FF016133D for ; Mon, 16 Dec 2024 18:12:37 +0000 (UTC) X-FDA: 82901616378.25.67111CC Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf13.hostedemail.com (Postfix) with ESMTP id 622C320016 for ; Mon, 16 Dec 2024 18:12:04 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=RbDgqQhO; dmarc=none; spf=none (imf13.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734372741; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dFpvSUWFeW3zR72pUQLwloomfFaQnTy1YdSxpYqv4Vk=; b=xEO9Ej2hVXlPdKqZ/HYWWwtlVoaT+WI1Z+xuOv6dJkl7q308D9FlaRj9f3wR9YTkjNWgp3 ErfCKggieVFuk+j9FKnMPB4YfM9fXOIJ6Sye5lw6FHMlWZfOHKkHsof53j8N80tXKetOCo zUBrdP4gPyB7fqkji6QNccg/DoyzkXc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734372741; a=rsa-sha256; cv=none; b=GhIVmum926aioLxK08CskliMKCzQ0Mq1K4zboytx7XzuKXZC3Sz/tuBfB8vUKSHHARPkWd boLvlU1h2loZD1gEZ+INFGQHdFlVJRS7wDbO7QuWen7666e7P3lr/kkvaTnyEtcQZv1K2X m1Cx4nRA4rcpIlz/TxyzwhBsXCNF0OI= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=RbDgqQhO; dmarc=none; spf=none (imf13.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dFpvSUWFeW3zR72pUQLwloomfFaQnTy1YdSxpYqv4Vk=; b=RbDgqQhOfL2hVF8rgIkkTvqvuv t6Vem3NMUmy8fAODof7J2j8Z6Z8fQ4gknaSC0Fny4PqOYwhehmMiT3G2V6Mqb53q4QhKsQWX8H9dV lALF8ojtyB842+z1akKWFrcjO5StlahY1TAi/ysdRiCDMKAuxrxicAiw1htikifXldHPKRhGxZFLz yoBiIO0zm726l62HEWO3SZxDVGsgucBmsxjqjB+CmYoY4cmtQYGwP8t08urqi1Zc4H8dGAdANRV1f uvgjGli2pLtDcL116wQi+pdRVfSYHYIZgf7VK7IFRxAUpO8z2BscPLLfGxPr8o4tpOdJrlI73s0Kd Y8ZfHz5A==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tNFZy-00000004vB6-0fQn; Mon, 16 Dec 2024 18:12:26 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 5709E30031E; Mon, 16 Dec 2024 19:12:25 +0100 (CET) Date: Mon, 16 Dec 2024 19:12:25 +0100 From: Peter Zijlstra To: Qi Zheng Cc: tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/12] mm: pgtable: introduce generic __tlb_remove_table() Message-ID: <20241216181225.GB11133@noisy.programming.kicks-ass.net> References: <271e58cd4ab808c4f402539b76d5916924e2bc6f.1734164094.git.zhengqi.arch@bytedance.com> <20241216120043.GA11133@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: t91kofb4rg7g3ehtzb79w176wrhqzcn5 X-Rspamd-Queue-Id: 622C320016 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1734372724-227984 X-HE-Meta: U2FsdGVkX19O3GR8dKi3sy3NPP5kMCCRI6IuVNJFaVsTRii51cW+4uP8lmMBdbxVzv7cjKSntgk8Kz1XQMvrrphKIELUHY3CV0yIkqL3FpAYjuurZXXEku7Z9ENShjmMioPc+A7hOKS7bEDpoQujlTlc9uGERKJVswfUsSyNyF/eZFrQvHjHey6J772PO+PJdaY3/xV2ubryV1bhp5Jt1PlrjwQdgZC8Tdm1waRGqrsWb3uSbyWuHkZftVso2jVuQHtF/LL/Ubr3qNWVW+rVGwYx0N1shdTZQgDo3sHL3pDQY1/nf7ca4nvC09+MZwGRvFHqC2SJ8wW9IXJlbVBX+qpLTXH+8S6jSYGQa9GTPrilbZE9pV+Rx34rAGyQ8v7zqMp/SL+Me1ArQ96FzCHZljcJhpENP6EteT9WGCLYVH1K3FF2xHgYUIvUDa6mn0dMeiHKVNboAvPw6Y0HFT6WI2illfjm0xleZ15fv73RDqTn0AGoUrWLV5Ei9H2EL5gl58RtbhNauTVvFDxuBxozPUwN7Kx+f76qfRMPThCgbTNCw9pcj3k283yXgm2Va+CpkNht2qmQkQrebyTzyBWfjA6rs0W+r2g4/Fn9fOG+tSAY6aqR2iW9nhY/qsjUFmgNRT/ztJVX4JWOkob9axF+jxpyuNmggbciEwByil/cG4ftYQ236gKvUl3t0NcdVXLkllBnxNzcQiPdLu+bsK8jFT/SmPs8jj7ELMMD3FNMPWerHJqIXW76tD9vYGH/Dc+2ptundFLd+B5Drh+U18iaEF0MOB96oaZ9HPywcVavNc7W6kuAdRanLGCQDmdv3zB/j3sQvmwwchqfa3o8UdFmzZ/FyIm1c+Fdcyl//LyxZ1l6AVacV/RRz6mFynmUGCTCqgqtz9kG3ld3T+WtslE+27zSQL8OgpAwetyi6ocYHcufA3qY5qLjQP2Hl9/mh4HK9vnNnTb3p0zD863///2 2WI4b1Sd Ki+94X+BHiCKXZU3VBo08NfzJIiaMfW68JPuxxojLS4wddhLRk5a/3ryPaovnm11wi+M6CzHVyVmAE2HeIc1tDnVw8fiY1qpT7A6AMYMTdLQv9M0MXBQ3qCaEts10VhPopFN+9j/79F6vnThl1walMq+BTv5ncLzZxvqaAUT21oAsbgVBeuzhLbYAKXObPj9gpJYLEkEik4o9m+v72HMSBiv4HlDd67LQx/cx5Cbng+ehs5prRAzF0Y0uXjQlt3imLw73CTm2LASNhvWEeaLrETAq66gn6Q6AeKxu9peAcsvAqOpu4mhAp4V/cDfaN6d/7qp3gHx4IUKmvkntyUfOH/kAwUzzO243A1KIw30c7CwxiWEpLX36vfiAuphvyhIHDAeat2FkZMEEfi6p4wrt5fj+8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 16, 2024 at 08:52:06PM +0800, Qi Zheng wrote: > > > On 2024/12/16 20:00, Peter Zijlstra wrote: > > On Sat, Dec 14, 2024 at 05:02:57PM +0800, Qi Zheng wrote: > > [...] > > > > +#ifndef __HAVE_ARCH_TLB_REMOVE_TABLE > > > +static inline void __tlb_remove_table(void *_table) > > > +{ > > > + struct ptdesc *ptdesc = (struct ptdesc *)_table; > > > + > > > + pagetable_dtor(ptdesc); > > > + pagetable_free(ptdesc); > > > +} > > > +#endif > > > > > > Spot the fail... > > > > That said, all this ptdesc stuff is another giant trainwreck. Let me > > clean that up for you. > > It looks like you want to revert what was done in this patch series: > > https://lore.kernel.org/all/20230807230513.102486-1-vishal.moola@gmail.com/ > > But why? It seems that splitting ptdesc from struct page is a good > thing? Because we're explicitly allocating pages for the page-tables, and also, code like: tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); static inline void tlb_remove_page_ptdesc(struct mmu_gather *tlb, struct ptdesc *pt) { tlb_remove_page(tlb, ptdesc_page(pt)); } Just makes me upset. Just bloody write tlb_remove_page() and call it a day. All that nonsense is just obfuscation at this point.