From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87E39E7716A for ; Sun, 15 Dec 2024 05:33:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C174C6B007B; Sun, 15 Dec 2024 00:33:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC5596B0083; Sun, 15 Dec 2024 00:33:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8D5C6B0085; Sun, 15 Dec 2024 00:33:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8ADE26B007B for ; Sun, 15 Dec 2024 00:33:12 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 00C7014309D for ; Sun, 15 Dec 2024 05:33:11 +0000 (UTC) X-FDA: 82896073722.08.FBAA4EA Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by imf09.hostedemail.com (Postfix) with ESMTP id 62DC2140008 for ; Sun, 15 Dec 2024 05:32:50 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LkUhiZC4; spf=pass (imf09.hostedemail.com: domain of lkp@intel.com designates 192.198.163.16 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734240769; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M923iz1lI7RWorI+O+l3AQWRiC9qUWCVbOUoX/84M8c=; b=YoT/NxY0nSxu3d1zThxHLEhKpsEKXa+gl0bRN/qBDgpJaOOC+ubW15oNcugs/z1uXLswUr fAvW4UMSrRdmETnp+Y2aWZr/Md3x9Nb9oVIHm+W2u5rdg7HLAL6wdBGrcku8MqYtsdUEG9 /ufhVJk17kBxEIXpSAirhNjx26ukMY0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LkUhiZC4; spf=pass (imf09.hostedemail.com: domain of lkp@intel.com designates 192.198.163.16 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734240769; a=rsa-sha256; cv=none; b=KO5zomfxJE4f2nMWajvpjH9EHp+sDDU/scRrsLNaBkiDSok4TSyH64Pq/bM2I3ZQariZjz AUqnBodeNpaJfO+QfWdb1PhxPH45guhZDra2YQiJoCPM+bOxw5Tbv1x9dk0QsiWOkNxitV ENhjyTFjDsAkG7ZzeDlVl87TQuwfYwg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734240789; x=1765776789; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+fY9hEPSKJmOpv8MMFl4MGi9GJjNk1kJJuxIOhFcZ+s=; b=LkUhiZC4B6Fe6c21lYSoXtQSfHZLzlT6FyCxTX62c9pa0fbdwCseZlh6 mo16p/Tv4KcGQUhifs3yweVJ7joi1yrOwmDue4oFSMYi/jsBl4wTqiOqo 5Cc89UF1acMCuyb37wY3WklFHKAbQIITBV1FHrtvQ5GNohbFc4x5pJTwR FGMd1NeC+nRf5ET8llHE3jTqOG1YOTWcMOuClrOxNS14I+BhnRb+WS1e9 hEsDIl1nRM8Kqfzyk3hGZpt32TfkBZATOg6nCOw5bG8JNZTvSMT6BdgTF 2PkzXOP4JEAT1k4PNw08Nid2nEaxmu7caNOoUqETMzF0XrvNZrz4mroes A==; X-CSE-ConnectionGUID: SYNtmvlyRuW6WBOtkjQ5Xg== X-CSE-MsgGUID: xF5NRxBVTCS2p5cfBtdCWg== X-IronPort-AV: E=McAfee;i="6700,10204,11286"; a="22236790" X-IronPort-AV: E=Sophos;i="6.12,235,1728975600"; d="scan'208";a="22236790" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2024 21:33:07 -0800 X-CSE-ConnectionGUID: jx8Wunj5QrGej9qdFuAyEw== X-CSE-MsgGUID: arxHAJamRTuuU+XVW7hbIA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="127889575" Received: from lkp-server01.sh.intel.com (HELO 82a3f569d0cb) ([10.239.97.150]) by fmviesa001.fm.intel.com with ESMTP; 14 Dec 2024 21:33:05 -0800 Received: from kbuild by 82a3f569d0cb with local (Exim 4.96) (envelope-from ) id 1tMhFW-000DSU-2o; Sun, 15 Dec 2024 05:33:02 +0000 Date: Sun, 15 Dec 2024 13:32:25 +0800 From: kernel test robot To: yangge1116@126.com, akpm@linux-foundation.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, 21cnbao@gmail.com, david@redhat.com, baolin.wang@linux.alibaba.com, vbabka@suse.cz, liuzixing@hygon.cn, yangge Subject: Re: [PATCH V2] mm, compaction: don't use ALLOC_CMA in long term GUP flow Message-ID: <202412151325.svvh8EAB-lkp@intel.com> References: <1734157420-31110-1-git-send-email-yangge1116@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1734157420-31110-1-git-send-email-yangge1116@126.com> X-Rspamd-Queue-Id: 62DC2140008 X-Rspamd-Server: rspam12 X-Stat-Signature: unzjrxzebbj8ohoxecbpchgs19uqryr4 X-Rspam-User: X-HE-Tag: 1734240770-956442 X-HE-Meta: U2FsdGVkX18QaSzRfLkFWnFi3gQJHk4h0XRmVYPL/e9oe4oSiIzXpjf6yL8G3WbvXzvoQIY67uvx4ADJF4Mvp9JfWqTxBLMiF38uFQOXStY/UmJjMaH1EYyEh0G+FDK0VRwfmegiy3YLtq6REolYzqKjHYWkQoDyzChA8NaGXWid7Yi4RTbPomxq/a3Q8y40iMzT2hBfEWBBdmumySVsTB7S1YFgIGkwA9JppWVleqpDTPL3ZcGAVClAFTiZUJLiWWTz1JYqMwqKTJDu7XQeydNZruS2SWPkygWJVBqcwrfkBx4fYIsAQ+HYErYsMEjPXWF7XQQhT2tCXYtXCk9n7SNsB+aExqVbodtdGsYWN59nrnwaSQeQ5AR/cwpSN4U4pYwCxvAJ0OvmzzycMstO78uQIBXubvOnVQyIVnhDficVunZweQn3gYQzDDNpBknBqo5P+IO1p80RIP/TbCc9fa8yMANyDI1hO57RGzfUozHB3z3AQwT68oTNBuyLvf9wrNzQ8mxGVSmc50E+WRxt+R2DfZ/U9H3wIlWftTg7jDfwXK/PKoNo35flH4Y2chiV6GHMAu6SOntVwuojf7VdXCNIsamRtcl0EcLwvzPsS59uj6+CDouYOt4pdP9b6pN4+9PSNnsyn9gSJL4EQRuXzMS4nB7zzFAg11/YBX2YKWIFotAyBpSCDxfLChlKHjz2ByCsMNdnLCmzOkKxZ4z27KEjwVXmDP+HIBPZcoVsq1UpIFbLgz8KXNRpI/yHUlu/Qz8mAkdTAKPmdDIRvt3Xw8hrCVPSIGTnr8v/CMVbYRXjNhRUPe+mn/O2kKFTcw53y6O0QPj/19qZG+tuzbt4mDk97QyN2n83TmhM9ePlddMdyiQKjK4AlecbNiMbio6yojbYWsoBuI/Pamw+jS49OipBmmIyHVzsw/sHN5BKo0dwc5qt/YZnn7d0jA281HS0lwKBv/mBH+Eu6xDNc2P JvfVYRF0 QOCcFYZ/eg8iR0bzWQZEf7rbOvb4zpAy/15AO702WV0LDFRaHLLcQTBWL42SvtAn/WFN5JzQNnacqWqD1IUCykPDrD2AQe9VQJOtxIt0M7srQ9Dvxuhwrs0Zojtr86o76VqL/Bhqnu3qQ2ug6LeOVA9DyiRj0ZVxYOD+9ljCtXt6QlFqQlP9SVyUgOlgLozfHGyGfDgfUE68/GcU1YB/ktyH/pdwIs0DQH5mYJko9lIKvWs17xSEt+t7v88DnvwC09QpP1a66P1vyZJcYX7VptkPmB4l9I/35wSpAkXu0dTYmKgMwL87A7XlUVYeXssqkT8/O9PC0hnyDs+GdI/kTIQopPM7CZAf+SSY1O6mZ8OtuZ6jV3kVoRXtXHgHF31yitgOsQ54oIGjOm4RacFumrh6VTfMWjhFeEie2YrHA+KnrqUi1psc90AjfWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/yangge1116-126-com/mm-compaction-don-t-use-ALLOC_CMA-in-long-term-GUP-flow/20241214-142453 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/1734157420-31110-1-git-send-email-yangge1116%40126.com patch subject: [PATCH V2] mm, compaction: don't use ALLOC_CMA in long term GUP flow config: arm-randconfig-001-20241215 (https://download.01.org/0day-ci/archive/20241215/202412151325.svvh8EAB-lkp@intel.com/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 2dc22615fd46ab2566d0f26d5ba234ab12dc4bf8) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241215/202412151325.svvh8EAB-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202412151325.svvh8EAB-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from mm/vmscan.c:30: include/linux/mm_inline.h:47:41: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 47 | __mod_lruvec_state(lruvec, NR_LRU_BASE + lru, nr_pages); | ~~~~~~~~~~~ ^ ~~~ include/linux/mm_inline.h:49:22: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 49 | NR_ZONE_LRU_BASE + lru, nr_pages); | ~~~~~~~~~~~~~~~~ ^ ~~~ mm/vmscan.c:409:51: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 409 | size += zone_page_state(zone, NR_ZONE_LRU_BASE + lru); | ~~~~~~~~~~~~~~~~ ^ ~~~ mm/vmscan.c:1773:4: warning: arithmetic between different enumeration types ('enum vm_event_item' and 'enum zone_type') [-Wenum-enum-conversion] 1773 | __count_zid_vm_events(PGSCAN_SKIP, zid, nr_skipped[zid]); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:139:34: note: expanded from macro '__count_zid_vm_events' 139 | __count_vm_events(item##_NORMAL - ZONE_NORMAL + zid, delta) | ~~~~~~~~~~~~~ ^ ~~~~~~~~~~~ mm/vmscan.c:2279:51: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 2279 | inactive = lruvec_page_state(lruvec, NR_LRU_BASE + inactive_lru); | ~~~~~~~~~~~ ^ ~~~~~~~~~~~~ mm/vmscan.c:2280:49: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 2280 | active = lruvec_page_state(lruvec, NR_LRU_BASE + active_lru); | ~~~~~~~~~~~ ^ ~~~~~~~~~~ >> mm/vmscan.c:5822:61: error: too many arguments to function call, expected 3, have 4 5822 | if (compaction_suitable(zone, sc->order, sc->reclaim_idx, 0)) | ~~~~~~~~~~~~~~~~~~~ ^ include/linux/compaction.h:111:20: note: 'compaction_suitable' declared here 111 | static inline bool compaction_suitable(struct zone *zone, int order, | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 112 | int highest_zoneidx) | ~~~~~~~~~~~~~~~~~~~ mm/vmscan.c:6050:61: error: too many arguments to function call, expected 3, have 4 6050 | if (!compaction_suitable(zone, sc->order, sc->reclaim_idx, 0)) | ~~~~~~~~~~~~~~~~~~~ ^ include/linux/compaction.h:111:20: note: 'compaction_suitable' declared here 111 | static inline bool compaction_suitable(struct zone *zone, int order, | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 112 | int highest_zoneidx) | ~~~~~~~~~~~~~~~~~~~ mm/vmscan.c:6239:3: warning: arithmetic between different enumeration types ('enum vm_event_item' and 'enum zone_type') [-Wenum-enum-conversion] 6239 | __count_zid_vm_events(ALLOCSTALL, sc->reclaim_idx, 1); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:139:34: note: expanded from macro '__count_zid_vm_events' 139 | __count_vm_events(item##_NORMAL - ZONE_NORMAL + zid, delta) | ~~~~~~~~~~~~~ ^ ~~~~~~~~~~~ 7 warnings and 2 errors generated. vim +5822 mm/vmscan.c 5778 5779 /* 5780 * Reclaim/compaction is used for high-order allocation requests. It reclaims 5781 * order-0 pages before compacting the zone. should_continue_reclaim() returns 5782 * true if more pages should be reclaimed such that when the page allocator 5783 * calls try_to_compact_pages() that it will have enough free pages to succeed. 5784 * It will give up earlier than that if there is difficulty reclaiming pages. 5785 */ 5786 static inline bool should_continue_reclaim(struct pglist_data *pgdat, 5787 unsigned long nr_reclaimed, 5788 struct scan_control *sc) 5789 { 5790 unsigned long pages_for_compaction; 5791 unsigned long inactive_lru_pages; 5792 int z; 5793 5794 /* If not in reclaim/compaction mode, stop */ 5795 if (!in_reclaim_compaction(sc)) 5796 return false; 5797 5798 /* 5799 * Stop if we failed to reclaim any pages from the last SWAP_CLUSTER_MAX 5800 * number of pages that were scanned. This will return to the caller 5801 * with the risk reclaim/compaction and the resulting allocation attempt 5802 * fails. In the past we have tried harder for __GFP_RETRY_MAYFAIL 5803 * allocations through requiring that the full LRU list has been scanned 5804 * first, by assuming that zero delta of sc->nr_scanned means full LRU 5805 * scan, but that approximation was wrong, and there were corner cases 5806 * where always a non-zero amount of pages were scanned. 5807 */ 5808 if (!nr_reclaimed) 5809 return false; 5810 5811 /* If compaction would go ahead or the allocation would succeed, stop */ 5812 for (z = 0; z <= sc->reclaim_idx; z++) { 5813 struct zone *zone = &pgdat->node_zones[z]; 5814 if (!managed_zone(zone)) 5815 continue; 5816 5817 /* Allocation can already succeed, nothing to do */ 5818 if (zone_watermark_ok(zone, sc->order, min_wmark_pages(zone), 5819 sc->reclaim_idx, 0)) 5820 return false; 5821 > 5822 if (compaction_suitable(zone, sc->order, sc->reclaim_idx, 0)) 5823 return false; 5824 } 5825 5826 /* 5827 * If we have not reclaimed enough pages for compaction and the 5828 * inactive lists are large enough, continue reclaiming 5829 */ 5830 pages_for_compaction = compact_gap(sc->order); 5831 inactive_lru_pages = node_page_state(pgdat, NR_INACTIVE_FILE); 5832 if (can_reclaim_anon_pages(NULL, pgdat->node_id, sc)) 5833 inactive_lru_pages += node_page_state(pgdat, NR_INACTIVE_ANON); 5834 5835 return inactive_lru_pages > pages_for_compaction; 5836 } 5837 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki