From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0D1EE7716A for ; Sun, 15 Dec 2024 03:30:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C1EA6B007B; Sat, 14 Dec 2024 22:30:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 571926B0083; Sat, 14 Dec 2024 22:30:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 439446B0085; Sat, 14 Dec 2024 22:30:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 252D06B007B for ; Sat, 14 Dec 2024 22:30:01 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9805D1A2E27 for ; Sun, 15 Dec 2024 03:30:00 +0000 (UTC) X-FDA: 82895763930.05.4973B86 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by imf18.hostedemail.com (Postfix) with ESMTP id 684A21C000A for ; Sun, 15 Dec 2024 03:29:45 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IAWvkjZ+; spf=pass (imf18.hostedemail.com: domain of lkp@intel.com designates 198.175.65.12 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734233385; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=odfysS7zMomrVl8ZvKihV6xcVaVNjf/FxdpEpUHsOD4=; b=gqpQGa/3hCjMC50eYFnSJrPSp1svhJ4Gea/DGNCAIqGV+PNTnp0bgKEM+Gr+/WKkQm6ol7 7eooHKCGdX7xGkbtQvnYIoL9JXik9QE7bYEdM/lF1apR1vKwuKr4a5eOADsG/AZqqU9ZRY YxaSK1foPWInhjFQhMYl3X4l0nMJmWk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734233385; a=rsa-sha256; cv=none; b=1UfFt17CxeoRo/q6bRRdOSS5iR8jBKXVPfii8TME56sKFoiKX9QIUVBJLpfAyq/VeZzE2F suMcWXKys2Vges7u83Gt+6pkhPPnA082GdMGtjTV+sx2JNW9/r5HqOQNbIcRYRxYKWPDNW 4JIol9EzKPsKq1rBG8uyqNcI9xgHDms= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IAWvkjZ+; spf=pass (imf18.hostedemail.com: domain of lkp@intel.com designates 198.175.65.12 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734233398; x=1765769398; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/NX2EoaKM0CshF8ayVfhRdRlhGgTbc6ZwoH2EXyMGFQ=; b=IAWvkjZ+VouZA7IYXFvLWrHfaI1wAXKa58lxX4cA6AxluIEQmnt8hP7k dkQUeK2enCKH2BR39CzD9Vsdeh3LjiBDm7x7G2XfVhq5RqlE9/iCC2eYC xcpbV00cGG1QpwyDf3ziAUiH5xKbwk5u+Ohlv0Vor/XGr2a+WoMC0T4Nw /pIW8z7Tmis5twuj2Be2dGnohqK92kHEE9SwFVUHx/lEj93/rpiYLUM7r M49/9MvOvdscM86oZq/U6F8S9ns9JX3EjkqIXiZe7v9Y1q9/OvNm+Jn+n 6k9cS8GvFLQPRThdwqBpfftg+cgrCpTq/upIXf3AEkGVMbwVrlfHKX0S5 A==; X-CSE-ConnectionGUID: 51/pBfZKRUy24He1gFRhvQ== X-CSE-MsgGUID: C0VHwJjDSh+2N5mE+a+f0g== X-IronPort-AV: E=McAfee;i="6700,10204,11278"; a="46040092" X-IronPort-AV: E=Sophos;i="6.12,214,1728975600"; d="scan'208";a="46040092" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2024 19:29:57 -0800 X-CSE-ConnectionGUID: JeaPkRPVQA2mB1GwWL2aeA== X-CSE-MsgGUID: BmK1I43cRvGQvhA3Xj2xXw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="97679538" Received: from lkp-server01.sh.intel.com (HELO 82a3f569d0cb) ([10.239.97.150]) by orviesa008.jf.intel.com with ESMTP; 14 Dec 2024 19:29:54 -0800 Received: from kbuild by 82a3f569d0cb with local (Exim 4.96) (envelope-from ) id 1tMfKJ-000DP2-1X; Sun, 15 Dec 2024 03:29:51 +0000 Date: Sun, 15 Dec 2024 11:29:07 +0800 From: kernel test robot To: yangge1116@126.com, akpm@linux-foundation.org Cc: oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, 21cnbao@gmail.com, david@redhat.com, baolin.wang@linux.alibaba.com, vbabka@suse.cz, liuzixing@hygon.cn, yangge Subject: Re: [PATCH V2] mm, compaction: don't use ALLOC_CMA in long term GUP flow Message-ID: <202412151139.n93obAio-lkp@intel.com> References: <1734157420-31110-1-git-send-email-yangge1116@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1734157420-31110-1-git-send-email-yangge1116@126.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 684A21C000A X-Stat-Signature: 8wiseq3shnrow9cow4577x5yd3n3xtga X-Rspam-User: X-HE-Tag: 1734233385-597081 X-HE-Meta: U2FsdGVkX19OmyDKhACPaWpftOll5SaKoOIP4JYn5rN4KrvuU32df4o5M/JtC0VQmOIXjhRCZ2j7BK4bPHEtXhlUjrykVZeN+1RHOBtyC8pVqthcIrwcBGPwfaFrDzKa/TsfDLRhM+F1zZEnHYbVABoeaU8LumG7cuy8YxgmS7QMSdl2y4e/gpWMmDQMiG/FF5vWZmD7/h4+jjI8cqgJhZz/YzlTTAno4MkDF/k1AjLcVYeUeJPzkPivU0PpZrS6BalGIEXfDayzUSu3qmCir2+290QrRcmvGDCXKZecWbTfaz89AWIBC/HB704dRC6reqIKB2zNDAP9dmZAZzIXz/7qOXaY2soCbjlPiF8jlIBpAhuU05/uEkRLQHXdYg5GCLFkhk1SZUESZdqahws5MmWD4/HlrmSGm0KqNvFNi+MJFj3BNev8NOT54zsmJYwhfsKrLS2V+IaNaFLVs6LeaYPlE0qASGi/dG4YAfLJ0kovAFcp+dbZFBsJJUPBXDFg0c/sh379cjWxzSiLc73aShJ25riVXXEmSrLoXcEBcUpTMqmpL/tvDAFUx5aKv2G+nU4W3K+jCEoKOiFvmeCwXDUqOk94WBjYaGxAEhKm+JrDTK8QTgwXwx3+lQkHElWwKCb8vALmrUFh1PJ13YwE6JBoeQU/X0SsgUe1zaY37vBMEbo4fgBlAzWslEeXdLk18lHRRdpKfJVvYrwZqXh5HFYD3aH2VUQ5wCGsDRl2lHhHlP5IL+B9ufOtcpfVmKECOzNLlD5zsqhvtqpqXLcmc4lJiivvedGv3OeQR5nwDB9qwRK1gzaLHfnA+qqXAYbV90uZ52vDQTFHryW2nc8i8LQLKU/RNFMtTjy2E6kGHwguq/ZqziW9uw6mYqEZbR5E02xZpfaislG9xfyAcHDZXLB0Af977Uv+ry+CDvlItr0IiZ1a/NQHaRFD8N0XLpgCS2mwMXcEQJmbbDYwuEM MZ9xyxAi 77P/LSe7d7JWaVRoAvDtApYENFhksQVu0JElcDBfMvhJnCQg87xIkvbtTRdVs4i+v01yGTd7NTSPdDBkgIduZ+VVeTiZyL2YzvL64sLBlLX50+7tXTAkn+yma3ePWNNBb0BqgMWE06DdJw8GU6MHdGv24Bk2qkGe2d7+8+vMvli9RByyB0zmM0hhL6bzfmH28tOqegBUKcRn5t8gK6ul4MxXaP2PF/Z6sdS8txS/IyvG4JrRiLtPNrE3MtSSxy5KWhKFW771VLzH03+9gDrgyl6+yuuc0h2id6XB0HI1wJumUZBE8exwbM4W3D9v5Jw+ac30mjZbK3aLj2Wn+ZLZPECcB7jaH2mfEOpi39qDQckew09dCoq85PVEEe+OnZUi82nOhD4yffHFA1CnTNtncJkXcU1SrCW95YoX2K/syAHc6M5pC1vjTsXZeIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/yangge1116-126-com/mm-compaction-don-t-use-ALLOC_CMA-in-long-term-GUP-flow/20241214-142453 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/1734157420-31110-1-git-send-email-yangge1116%40126.com patch subject: [PATCH V2] mm, compaction: don't use ALLOC_CMA in long term GUP flow config: i386-buildonly-randconfig-004-20241215 (https://download.01.org/0day-ci/archive/20241215/202412151139.n93obAio-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241215/202412151139.n93obAio-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202412151139.n93obAio-lkp@intel.com/ All errors (new ones prefixed by >>): mm/vmscan.c: In function 'should_continue_reclaim': >> mm/vmscan.c:5822:21: error: too many arguments to function 'compaction_suitable' 5822 | if (compaction_suitable(zone, sc->order, sc->reclaim_idx, 0)) | ^~~~~~~~~~~~~~~~~~~ In file included from mm/vmscan.c:36: include/linux/compaction.h:111:20: note: declared here 111 | static inline bool compaction_suitable(struct zone *zone, int order, | ^~~~~~~~~~~~~~~~~~~ mm/vmscan.c: In function 'compaction_ready': mm/vmscan.c:6050:14: error: too many arguments to function 'compaction_suitable' 6050 | if (!compaction_suitable(zone, sc->order, sc->reclaim_idx, 0)) | ^~~~~~~~~~~~~~~~~~~ include/linux/compaction.h:111:20: note: declared here 111 | static inline bool compaction_suitable(struct zone *zone, int order, | ^~~~~~~~~~~~~~~~~~~ vim +/compaction_suitable +5822 mm/vmscan.c 5778 5779 /* 5780 * Reclaim/compaction is used for high-order allocation requests. It reclaims 5781 * order-0 pages before compacting the zone. should_continue_reclaim() returns 5782 * true if more pages should be reclaimed such that when the page allocator 5783 * calls try_to_compact_pages() that it will have enough free pages to succeed. 5784 * It will give up earlier than that if there is difficulty reclaiming pages. 5785 */ 5786 static inline bool should_continue_reclaim(struct pglist_data *pgdat, 5787 unsigned long nr_reclaimed, 5788 struct scan_control *sc) 5789 { 5790 unsigned long pages_for_compaction; 5791 unsigned long inactive_lru_pages; 5792 int z; 5793 5794 /* If not in reclaim/compaction mode, stop */ 5795 if (!in_reclaim_compaction(sc)) 5796 return false; 5797 5798 /* 5799 * Stop if we failed to reclaim any pages from the last SWAP_CLUSTER_MAX 5800 * number of pages that were scanned. This will return to the caller 5801 * with the risk reclaim/compaction and the resulting allocation attempt 5802 * fails. In the past we have tried harder for __GFP_RETRY_MAYFAIL 5803 * allocations through requiring that the full LRU list has been scanned 5804 * first, by assuming that zero delta of sc->nr_scanned means full LRU 5805 * scan, but that approximation was wrong, and there were corner cases 5806 * where always a non-zero amount of pages were scanned. 5807 */ 5808 if (!nr_reclaimed) 5809 return false; 5810 5811 /* If compaction would go ahead or the allocation would succeed, stop */ 5812 for (z = 0; z <= sc->reclaim_idx; z++) { 5813 struct zone *zone = &pgdat->node_zones[z]; 5814 if (!managed_zone(zone)) 5815 continue; 5816 5817 /* Allocation can already succeed, nothing to do */ 5818 if (zone_watermark_ok(zone, sc->order, min_wmark_pages(zone), 5819 sc->reclaim_idx, 0)) 5820 return false; 5821 > 5822 if (compaction_suitable(zone, sc->order, sc->reclaim_idx, 0)) 5823 return false; 5824 } 5825 5826 /* 5827 * If we have not reclaimed enough pages for compaction and the 5828 * inactive lists are large enough, continue reclaiming 5829 */ 5830 pages_for_compaction = compact_gap(sc->order); 5831 inactive_lru_pages = node_page_state(pgdat, NR_INACTIVE_FILE); 5832 if (can_reclaim_anon_pages(NULL, pgdat->node_id, sc)) 5833 inactive_lru_pages += node_page_state(pgdat, NR_INACTIVE_ANON); 5834 5835 return inactive_lru_pages > pages_for_compaction; 5836 } 5837 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki