From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74030E7716A for ; Sat, 14 Dec 2024 19:59:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E2DC6B0085; Sat, 14 Dec 2024 14:59:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 96C6B6B0088; Sat, 14 Dec 2024 14:59:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80CD26B0089; Sat, 14 Dec 2024 14:59:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5E2D76B0085 for ; Sat, 14 Dec 2024 14:59:22 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CC74C4657C for ; Sat, 14 Dec 2024 19:59:21 +0000 (UTC) X-FDA: 82894628670.14.D88EC45 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf15.hostedemail.com (Postfix) with ESMTP id B2BF3A0004 for ; Sat, 14 Dec 2024 19:58:44 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=VLxKKRYe; spf=none (imf15.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734206341; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3A2mm7dIa+NUSpTRAKJq7wnU9GzP5+byLw5NhtUqJAk=; b=Y9dSsC746Iso641nTkE5rvFpX4zNUtd2DxIWRVOcqze4ZoDgTVY/xxxLXvIzfPFj74XFVe 0OcGVwBN+iJENrV4wd0rA+rZFMPf4RtjnFWfCgJcemiQXHeqHlN1DWKYyD/XiQda36EdTM X/c3DZ3U0NbgLPzwyidx5h/IrSp9i6g= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=VLxKKRYe; spf=none (imf15.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734206341; a=rsa-sha256; cv=none; b=3mY1dzo1xy6R+QMnQCLiXLA7QhKF8Clb0nqNdBJIQDS1aEVJMQKvxGL6q/6MoNP0+FfXj7 KZ/HXlbMh1sgDZQTGJJpap0FaL5akLhRAZ6BVAdLBQ02bSI2sq/RKQVn8Xe70A0Annkuqm TXbQ2R0gPvql+zOkvWRc1/D7o3KOVOY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=3A2mm7dIa+NUSpTRAKJq7wnU9GzP5+byLw5NhtUqJAk=; b=VLxKKRYexoPCOwSdgHRWDu/eiT wOUexwEvxnKdbVSDnMgYRX3bB7n2rhmVJnOX//RxsSRzXABGODIQsaDJK2OxHS/1wAp7S829B9Mfw xLF9HApEq9Pp0NMqvAcjDnFUWmSUQymcSRvrCXzyzpbC/bF9tJusl6djjCi22V6XsJc9JFcWx5lSH r+pjLBUyhYwubcEa8QnlD/qUPqZDoSNecXDD34pbrf51ycPxmGxD1DpYGQONzKgO4AqGcfi/kuBMV kj/feRdRextoFUr1NT0SqLv1GGwcrcKcHdnYzdeePIpo7fzVxg2bmgUCar/1ly2s2q9Dl8gQUZ75e +gaaIrzA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98 #2 (Red Hat Linux)) id 1tMYIE-00000008Jth-00EN; Sat, 14 Dec 2024 19:59:14 +0000 Date: Sat, 14 Dec 2024 19:59:13 +0000 From: Al Viro To: Chuck Lever Cc: Hugh Dickens , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, yukuai3@huawei.com, yangerkun@huaweicloud.com Subject: Re: [PATCH v4 5/5] libfs: Use d_children list to iterate simple_offset directories Message-ID: <20241214195913.GB1977892@ZenIV> References: <20241204155257.1110338-1-cel@kernel.org> <20241204155257.1110338-6-cel@kernel.org> <5eb7bbdb-0928-4c80-bf03-9de27d6f3f89@oracle.com> <8c716ca1-84f9-4644-95cf-9965e8a30284@oracle.com> <20241214174949.GA1977892@ZenIV> <99addf69-4757-4eb9-b6d1-e554a72070c3@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <99addf69-4757-4eb9-b6d1-e554a72070c3@oracle.com> X-Rspamd-Server: rspam05 X-Stat-Signature: iguhxaabqza3i648anca89onw19yz4oi X-Rspamd-Queue-Id: B2BF3A0004 X-Rspam-User: X-HE-Tag: 1734206324-727437 X-HE-Meta: U2FsdGVkX197tLvHAb8CJtcLWdkTCzYlcg7IckhCu1E4zI4GxAbF/o14Yl6wyt5YswCU1GpUn0LGknDjKF0YI4xKgSwWJfxLDUQ83g8RD7QvKRhaAOgczdksvcEvZA3VzP6v9E7rmSwmuGMZyi9jKC3Xg6J2ormDmWTlzLgHGZRYo90PHtyUBt9mjna/ERLw+yhD/dLw7bQcJPuR3iFBzResOgrtAZgw4sgLtHqSJ7yTZ6W5FMIoL2kLUQEbexiLQxFg9yG/NZdd+IUeFbbFuGmM2rl/vjWwYJ/q93qyV77O9dMPQKJWCzKV6j4Mfk+b1QEwaGUUAEw9/Fx3LHrEZZFOzahnjC4JiwQETtZwiw8/2khjJ7bKuzHaqL9flxVaeyBaRT2e8B+MnebRs2TPgHjgli7hSezCu1jS0Ye77TciQWBkLzbqYZo/yylCmGFuD/0hXPxuNQKjqRqrcJfZM984WbvRcRiQidTkLF8XUQ834ar6XJUM+xwamxRBJf5OoWkEhvM3IslT35qbAQxn8KTj/aRxjE/hOwMW+VUwEjjsmD+AJHJZqwwR8vaTWHozzuZVQDkN7Tu20Q384e7yV4EOK2i1gu9plDG/8NWQ5LiunBZOag+vp5lhlvR/EvrIm0FaKr2DwFTKmnlHCH2JJTFJtor6v2rm2/cvGi6in/5FO0tP/jKikmQkHJIWLgTcp63h7/rDX18oZggyoSgNreO89NcYd2BycqP68vDTeFkLmMsRD/JJgrBNSQrSQlZ1jFy0Rin0HHcTKtOXXaUo7vKsvf0HJtnaSmMBWZBpVfpIpwgh2y4XAslArFMjW7p/D6DQ+Ev9sYeMQAxNJiP86WfIIrJjif1nhMel9iIWDPQnrkM3J1n9PVT6UD7V4+XFX/p/4t+FxKCHsHXHh72lI3PNhFVZlRwJHg+00448nW+usJpASqUmwoluBb/7FT9Va2l7F96vmiFcBvP0lIB JEsIrikH gQdf312Jmxtnh49LotPqkjf6vpUzAJgrKktwiAo+2uh2Di3lzyfjQhcsXtHhvwsWI1J48xr7qAiB0NzgRWpfDgYN4XHAEFANFFCSFsqzoZOiYAwpCWF1bEvkdwEmLPcfVkYPzBXUJ6j2WFGUdcS2RxCw3vlqdsozH+L9tWljjhZxJwR8lOSYjya322c1sfB9LjzeFFKX+4gdgaTEV+21BYyIDSNs+a7rFm+tuHGhK3ZgOaa80XvdY+zHZn5BlOMqJQhSt2OeUPMPnMspeAxgrdj+pytGvoARTdL65hw711EgXaJNX+HOPYrPLyntuO3ByxsDhkDBhf7Pm6K1RhrTjN0PCW2TllmifN4mc/91W5KlmZOZmMhwoOHy96O05rYOa0wjr7T+zikMaFqrxNLp8rrdhIwh5SjiHyxQlBse73z2s/4QFychPtP2qfYrMZ/sdNWJyJVy6iEfyYCq5P9g8tv6tnp9O1RpOXzRy/Ivf8Z+4Dd4sjcHzNrH0oqdyA+RLyQNKxVo+aOdtdcCNkLmTFNpLyJClXaplZD48BLPQTctMTUeJAnMCAvNtQogtgzQpjn3WpU0Z96T02wbKODfz8kwRxG5K5EeGqzSLZ38xNrO1k6r+P1oZJO7t7Nn8KTZIdOSettRHbGtleFhw18Ted/HDPA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 14, 2024 at 02:22:41PM -0500, Chuck Lever wrote: > On 12/14/24 12:49 PM, Al Viro wrote: > > On Sat, Dec 14, 2024 at 12:13:30PM -0500, Chuck Lever wrote: > > > > > +/* Cf. find_next_child() */ > > > > > +static struct dentry *find_next_sibling_locked(struct dentry *parent, > > > > > +                           struct dentry *dentry) > > > > > > > > There might be a better name for this function. > > > > There might be better calling conventions for it, TBH. > > AFAICS, all callers are directly surrounded by grabbing/releasing > > ->d_lock on parent. Why not fold that in, and to hell with any > > mentionings of "locked" in the name... > > I've tried it both ways, couldn't make up my mind. I'll try it again. Single return there, so it's just a single spin_lock() on entry and spin_unlock() on exit... No idea if it'll make coverity any happier, but it would be easier on human readers.