From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1BB3E77183 for ; Sat, 14 Dec 2024 18:55:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DD876B007B; Sat, 14 Dec 2024 13:55:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0669A6B0083; Sat, 14 Dec 2024 13:55:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E70046B0085; Sat, 14 Dec 2024 13:55:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C93106B007B for ; Sat, 14 Dec 2024 13:55:20 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 59BB4A26C6 for ; Sat, 14 Dec 2024 18:55:20 +0000 (UTC) X-FDA: 82894465668.17.6275BC7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id BAAB44000F for ; Sat, 14 Dec 2024 18:54:47 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lUswMLbK; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734202500; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tGBNbcCRq0sbUN85ytraPXFhmCcq6mIVLV079/flAmM=; b=cE/UqmxMhUlWCergCjPwtVkVgmiE5EnkxJWYRWCKB65J3vn9lUd6z8Lf/w2OGH9FwBwAHj n5EnZgVqTz2H8Nu1ek/sKqgtyi4zlrEZ2bHw87vcQJ2f5Vk34jAYkDwKtp5LKEnryBYq7R h9Ctp+bFssQXtneDuYGpuBK9NhQOQPs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734202500; a=rsa-sha256; cv=none; b=6W94wVNQ7w26nGwqZI5+iTlzYlNeWuDfcqKc6u1UlaFbDBF9Ck1DChdwB2RPQ1OXRJTONl p4hXv1PrQ+rMahziHyG46ZGJMABW5wkFQDO3NPaDjhDgRAZiwamX/eT8bFOlSB4NIatwR8 ps9nhhNhXvip9T7l1LNM/fs4jSihTHo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lUswMLbK; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tGBNbcCRq0sbUN85ytraPXFhmCcq6mIVLV079/flAmM=; b=lUswMLbKvhDYlp6Un/Esx8qMhf uu5XC/0VQIO2P9g72uKhJZHBKqXAt9W0xLpRe4g6rMyBdFnAyZgLMcq9nZ9Uz2t7goaC/TU0S8mua 1RhCcdGtH+bYM/i1GvB2x6aYZP2KzO5nwCUZXlQnDf7Noajv6/pAKGo5964HbSS1TEMeQt5cpTqb3 fFJDXiVL2AHX+t2kuxIagwP5JpYWhO3Uv1P0tD8qsAFI0MQ8Zor4Eb+qTPAWTYBA54Tw5moZdLpX5 FlsUmQuwyqHjJtlVAtnMniL2FgNgjktr/h49MBRcuoZS6mviLJ4SdMWHYLOa/Z3y0BtlX56HZwWO6 ckgR+IDQ==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tMXIG-00000004U40-2aC8; Sat, 14 Dec 2024 18:55:12 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 0767B30035F; Sat, 14 Dec 2024 19:55:12 +0100 (CET) Date: Sat, 14 Dec 2024 19:55:11 +0100 From: Peter Zijlstra To: Qi Zheng Cc: tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/12] move pagetable_*_dtor() to __tlb_remove_table() Message-ID: <20241214185511.GF10560@noisy.programming.kicks-ass.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BAAB44000F X-Stat-Signature: iba5bou85gean66k5ythshdkhf8nhh5t X-Rspam-User: X-HE-Tag: 1734202487-797262 X-HE-Meta: U2FsdGVkX19gMJUn+GUzteOhQgnCOXgW3wIkaf5H8OKG6jk6iQcROz66xs/UUQ2JjoedvYrsb5NpcvqdUWxjA5S8eVyCXfqCikhMqK7IDXeZFa4yhjJx6Q8AC3TE4dlgksakV62301HvG76sXbKtYLOsgpAkAiF/Ub2+e/n2vYjHWMWyrX1VZCmYpmMQSNFzBt9ozBWnjLQ/RVoORqlQLEFdHr166NSz4Ed2bJ4z/7yx10pHoFNG0aDuXIfPdxVBuZU362r2Hs7z8BrHoOKueW2ZbmoA2P7mAcNEFVb4SBYi2A6likKgqFr1CtGs3LRMhBDRPSB0sMI+b7avD8urnMWDpB4EQiWFp87B1+8t1TszMlKnO1omswlvkab7J6w6p2kUn4wmRT4X4jBEI+o5Q412CV5X8AysWloRGMYQqJnrvuF+cjOeCmMdJhFjG7MrmN+cycC6JKfAMVBeIYICJ/iNfTin/eMCx5Bfg8PX9dphWG2yWI5+ojHFjtH6W7k9sAKS5vHXyQOnIfJsTLqeT3hqAyYvddXcuacJeH73PIPNO/TKcy1ABbN7Bv5EAK1akyywOdWfDFFiUGQANZ1QCvfZNm2aQcjCSWQDNhNuHIFWJrfVsBwilHBJVDP44POZDoPqlzyYs0NzfiFien3mVcHMPl08/LwAWZb2B97ycvwrtM9Q/99n+Avp2kSAVt2ecGulxWukN7Cr3aTmSoZSCyKvjWar1AdFHUcbmEp1bS5IYdZfv1U0yl6WhXrTX5pUj3jViT+OG6OP3qg0YvxT+H9ybsvmSwQURZxdJ6x6KdSBrLk0nUMmyOauZ+/ikWTHimENdbifSdAeXQMnNuaHgSeQb/Zb7bwCjcW27T/2P23bhJCbsVyOcwutupLBqN09QPnIfSDYtfuVnxyw9vSyuZ14jKJ6y19LHFujzAXkt3j9QlGD+sscspc5V4LTOrNQbc1eEzvfVPun7JV8yYL 4DDXhp+V jIMA5Y9Z76XFHe8dJ+XA5/zjuLE20VSZM0Fm4RqUhAa4kP3i22rXc1LkIt3t/gxa+0+D80OFcFHiK5D+NlQMmr7dXhyOFgeEqr46wePUMTe1YhAvNlG/e8aMiEQxqaeEEFT61kvH+twaKJlZ1RH56nYH+vvZd+ak3MJOMmSTGI7w2orWomM7J2pJUIz3c5HPBpby8G/TmKognldt399ILIyj9/RbnBLcMyEycT+SoD7jLDIsodcfQvl/R3TB7hGLvLuTO2Eh685QKai3+yJX9yAbksTNJbcDQcN/P0SjAmnr3L94= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 14, 2024 at 05:02:46PM +0800, Qi Zheng wrote: > As proposed [1] by Peter Zijlstra below, this patch series aims to move > pagetable_*_dtor() into __tlb_remove_table(). This will cleanup pagetable_*_dtor() > a bit and more gracefully fix the UAF issue [2] reported by syzbot. I'll go over the patches in more detail on Monday, but at least the first few patches should probably carry something like: Originally-by: Peter Zijlstra (Intel) Since you extracted it from my half-baked patch, the rest could probably do with: Suggested-by: Peter Zijlstra (Intel) Anyway, thanks for doing this, and so quicky! As said, I'll read more on Monday.