From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D84DE7716A for ; Sat, 14 Dec 2024 17:49:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6E756B007B; Sat, 14 Dec 2024 12:49:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C1E156B0083; Sat, 14 Dec 2024 12:49:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0D5D6B0085; Sat, 14 Dec 2024 12:49:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 92C156B007B for ; Sat, 14 Dec 2024 12:49:57 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4748B16254A for ; Sat, 14 Dec 2024 17:49:57 +0000 (UTC) X-FDA: 82894301952.21.5817C2F Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf25.hostedemail.com (Postfix) with ESMTP id DFF60A0002 for ; Sat, 14 Dec 2024 17:49:35 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=ED0aco91; spf=none (imf25.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734198583; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5qJ6pG6YzsM9FaFvriP/CCcesATZyZIlxpd9+19kmAA=; b=7NKgAxTKC+8AZtQWCQayKzrWu/XthpTjIUOfsT7w48CZ1QzJlZ41hF/1l8ZdgSfbpsYAOd jAmjjQGXiRLF+x1w6sgjyEoi6sdZsNwg1+c8NFw/8aqebmCHR6I1g5IvaM4zOC/FRjchmz zdVQi6x9HzQtDF+/3kr808w7ykVt5qc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=ED0aco91; spf=none (imf25.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734198583; a=rsa-sha256; cv=none; b=Gg5IOYU4JGe9Mfk6yJOqwCKx0pMA8AMJcJPJ4yJj6STmCRnYXJKZa+juOsy+s5SmbIKPq+ eW+lM4UvnbXZdeHNeMHSpulLxtUU44qJWPznf1u8+ci4XGDVBhwjcygrP+nJ/j/elrwNUK PV/3huf/tXsPyy7Xv1O5CrTP9FV03+I= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=5qJ6pG6YzsM9FaFvriP/CCcesATZyZIlxpd9+19kmAA=; b=ED0aco916p6UHV4RcY6M3wTRfQ lV6wiAj7T+iNMnKEHV0MW0wcXNgW9AJQr/dRo7Bed4tkmyyoLLD92bOpYc1sVyCPeIODTq7i2M02n MQazzoE/TIQEyGL2EUQ388KbzrCE9y5gekGl/6Mhs2cMiFCcg8vKe6bqeyzHlbxVzyvn5SHJvsGOl hg4CpCwLfrD1eVj0UFoZ4tUfkavHCL5ckDbDFEduN1W697Z9JYDvayeOr9mZjJc+sV6NWqRDZNwWH lF6poXLJcUz7yb9w25kZexGD/Syl2sl9Ed36JFCYFrgxRVhFGyk1qR+eMqbaC6BHLFEyh3mXXwojZ aP0MfwJg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98 #2 (Red Hat Linux)) id 1tMWGz-00000008Ibq-1Zbp; Sat, 14 Dec 2024 17:49:49 +0000 Date: Sat, 14 Dec 2024 17:49:49 +0000 From: Al Viro To: Chuck Lever Cc: Hugh Dickens , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, yukuai3@huawei.com, yangerkun@huaweicloud.com Subject: Re: [PATCH v4 5/5] libfs: Use d_children list to iterate simple_offset directories Message-ID: <20241214174949.GA1977892@ZenIV> References: <20241204155257.1110338-1-cel@kernel.org> <20241204155257.1110338-6-cel@kernel.org> <5eb7bbdb-0928-4c80-bf03-9de27d6f3f89@oracle.com> <8c716ca1-84f9-4644-95cf-9965e8a30284@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8c716ca1-84f9-4644-95cf-9965e8a30284@oracle.com> X-Rspamd-Queue-Id: DFF60A0002 X-Stat-Signature: n1eisq1i6shojmfk4s94j34deaduaeyu X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1734198575-797252 X-HE-Meta: U2FsdGVkX19AQkV3ed7SdIjDekrI3FZLfWOcPS0tLPOEPSsKO4lQORzVlEMZW+aCOqvp3bKGqhLAM0eFIuebjG6JM4BXxuM9E1zvbiLWY3pgVlZPLUgsAiNdhjgfc3JL6vU77vzPi8K01EOd+RuqjNXvvgxaZbFcHMLGu29yCXoytFYsLvdWA+Tg2WYqZlBIlaRMZvPS2BzEQ0LLOo5L9FjCQxjRrXpjDsjtxwkQ87HjWtdnYT7oiIrf+BAB2d4jbYcPgHTgVvPRRffnPgTLd9gZC02MDgHjKJAVlxw2YgXByGRgxPyoYYfn08XVhOWaTsvZFQ7PwvrbG59O9USRiRTVJsbVnjH17JF8VbajV1a7NspIKmS/iFUKC/13om8fSg029bizUzFAOBayC5Mfv4HcVU6MK4ItHi78TrN0NgSF/zEs+RcgKkcgoZUN3ZBWt4SLrgHCCCYGGAKKEeeJ3ds+PmrlE0jENGwxqYcgGKpjMauYMlnjqEcT986yTlvMw1j9u3xJkTar/cj+quvVJHCKFQi89GIrQtwxRLxKG0SbuFaegIIagnoh1c82WXhbK8HBUx3mUWMERpvZFCbxECC+JWXV0B+y9oZYDHJjAna6b/NdTyk2SLQB8WjqGAuLOguLUcHE4knXJaGYDwwhw9iqgr9hjpwbufyWE4gIglrrIZno7p3M2ziqX7qoZP1NttOLEyUr+pw5rLVxNXDJbrQq4ZUZpimbGuvUrZ9py1Kgd+1/sw8Hv1G2q02p0BqMuAEV4guTMg4cl6OpYGejK27h6ZZ1w0F6JHKSD++1AXSQGDHCWGNfRrgC04pSPbpcB7iZ3Zh/A3KmFLcQfMTjapHVd06cxS9rGxDTg6l+lpUQq0p3J6mljoW10AsRQp0pR+ZZNPimcxGUshNotZ9FGk+0/INs0xGYKQiEHXs3uDRPQEwnGWIPCwR5l7pOavO7GnhPQKAfYEQn3YiPrVm HobgDsv7 Y02Ba76kQtwvbMDs2oBp5ns/MclTLIWHK5QLigqf34bVwDoNhOmd1EYLeHQOaG5gPe5JnHavzIxfpgV1Xcym6rMEWD9kJ2CDLzURTXSAUxYGBYVrE1wgmt3d0bxgNt2iHNsBEBXGdFeqVCUgpA8xefcIelh/EHXpIVWTLu0wn1bIGwbjp0DCYjlXe38DFWQwyuOA5VLWqzI2ErncM5AEIXh4NV5dKeHoD74xGS9u7+7kHGtIGW/9l/Hwjr3bp/x/mdIWOybfV8zpWtDCY6eyWFeTTzXEdrHIh0Nq3MJVYDk8TFXHTQPBVzNb7TpXHBBTaznoRYYq2cb/yGIgJ1zJPi6sun3uVgsNYxvxQHRgv9o4PpbZkXuog7akaYVx60RPG8ufP9xM2z28pAxGC2BHnSImg2yce0oIuBNKzSFxasmv5ifhD9946GiiG32c7w/z7ZcPH7+MuKs/Gri+AwVIiSh2Hd50X/iA4WK286WFUu0v9UrxkKKpI6NI4K3KfXC/dBGgKG7yEnOPQKR0XOcbp1s+fvJZjp0BK757nOv9BUgjxW1ApwlFUPWvAzlW/EDsIlp/sfuAS6b+Tzxjv132Yj86DhL8pFtgnTKOg4yucP+Hn5fu1X6MFKUd4H+jFRjXvHo4ZOIXhngiq9tkd4Lx7M9nKUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000566, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 14, 2024 at 12:13:30PM -0500, Chuck Lever wrote: > > > +/* Cf. find_next_child() */ > > > +static struct dentry *find_next_sibling_locked(struct dentry *parent, > > > +                           struct dentry *dentry) > > > > There might be a better name for this function. There might be better calling conventions for it, TBH. AFAICS, all callers are directly surrounded by grabbing/releasing ->d_lock on parent. Why not fold that in, and to hell with any mentionings of "locked" in the name...