From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7083CE7717F for ; Sat, 14 Dec 2024 02:53:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BA9C6B0083; Fri, 13 Dec 2024 21:53:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 56A436B0085; Fri, 13 Dec 2024 21:53:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 431BA6B0089; Fri, 13 Dec 2024 21:53:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2753A6B0083 for ; Fri, 13 Dec 2024 21:53:07 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C25C41A14A4 for ; Sat, 14 Dec 2024 02:53:06 +0000 (UTC) X-FDA: 82892042562.29.6061CDC Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf02.hostedemail.com (Postfix) with ESMTP id A4FC880007 for ; Sat, 14 Dec 2024 02:52:14 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=b3SZCIzC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of alexjlzheng@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=alexjlzheng@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734144773; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DoSCsOBB1zMFBPFMyed5n425wAfTXjv1eFmj2Y6uIoA=; b=6haCMxfdTLNFxcCnQvRR44oKRtwT6qLM+kvVt1wJtJPtZlSZFYDeMP62lsBHX2W6b8PeDb uMplD5WzcjW9pe557mYDOyUVeXU/G/clArNevX7xyQ1+3TrECLb8PeLPYGOXJPvXDaYYGD nvYnTJWzl96rNm2aBDiWqA0wRuBYu7w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734144773; a=rsa-sha256; cv=none; b=2OiJSiEYUStTFN3QTJp6UTtNQ1r80zpHeoWBzJlkZ+1qCywbk7Tj93HulUWgprZ47MwKV9 j/pEoGMfrSw1emfhI9vO7P+N8JL70YgL7CEig+40uG+Gfo79fI8i8ewi6bQQN0qWnTYX0/ NE3MZuHiWF8XgQVEf8V0YRXlJbJMW64= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=b3SZCIzC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of alexjlzheng@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=alexjlzheng@gmail.com Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-728f1525565so2821929b3a.1 for ; Fri, 13 Dec 2024 18:53:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734144783; x=1734749583; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DoSCsOBB1zMFBPFMyed5n425wAfTXjv1eFmj2Y6uIoA=; b=b3SZCIzCdAiclBbXAabmYiCaYjOU4hdDSJK6St8qeM319NMLSUjjyzA67bPCtNbpeK X2mrnIFY6ERqsEA4lnZQshBv7jy2z5+Z93fasqcmLuPnQzX/8TejNJ4mHRgqX/5FXrNf MOlkVVng1RjNwlHIy0N1WF1lyBENrizFoF/kW2N+5+rtH3Sc/Xi+7dK9oUR+H3lR6yoF XFg3Cuobv6zZZg+U+w8n6tXj9iAdmeLydUQWTsyEdvFaxuLcQ3Sl4DU8IuCZt1hxqb8S 48D55w5a+r+sVubf1p5O2UEsEUTjdqXkyOqLlmzYNCcbRnM5OnRvVSNn1kv3CXtb4FGf KTYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734144783; x=1734749583; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DoSCsOBB1zMFBPFMyed5n425wAfTXjv1eFmj2Y6uIoA=; b=ChoZijD8K100oID+BI7djTE5FDWHP+Lc5jIFgWiVc85BHPYz/rzbvT4MUYhbcvTM+n 5uh0GiK8EkylWmtJoEh9iYrMMQBA+lO7HRvOsGTKQO/r7Fe/fpoWdWQRjPnoXGVvtmqm N5PEHcXHNd1v3LPOWOwao7FDOZv8Nb71pAnrMa7rWkR2KQGh0CG9zV6fe7STlK8GOzDF snLR+Or5EjGFJgOAHVIupocfnvSXWza9kYNwEnrHM0ssBAE/ryRasiFjyw0oDUj0MPR/ Skvt9WMPcfEjgzzfIwvBmHApRZUOSRfYaXXsYEyXPf3VyPjwa+qAVakaBCIBA8ukWsue du5A== X-Forwarded-Encrypted: i=1; AJvYcCWc4yA13c41xGeMJEKQjN2wDaJ2dhDDjHhZGTZq/Il7wzWGGTEBKQLsrQqGNrAF7O/LeNQRoOLFPw==@kvack.org X-Gm-Message-State: AOJu0YwjHElV+4L5RQYi04ARGiunbs7Xjom2oaLJ77XLoTq75yrVqaHn kg+rfGeNNOqoNuJdUAAr/6fs9w9km4CFWegMsbXz3LSd6ZRkS1ZT X-Gm-Gg: ASbGnct1K4CkaD3rCbbE4JV8mgKjpR5kr9j+ChNJt3uxGnj0FT3Rt4vEMLeTTVhzCwv gig7MwavZppfepH3gyYaF63qOIQ1qAd2foaq8scnyksXYRucaiYN6kmvH310RIRJSU9lxjzlvxK DUMt40gERm9kJRISw6CYOY9plRPZK0aPw4zxzEk6U1vA5zFt5tL9G6pCg8cOVsjwwvZBvxbChB9 rdndSuq8PbGwjyFc5tx49uJ98RaiMCelc7SiZ83kC5fyLivSYpkUwYGWnJ7OH/34VlQ+7Vw X-Google-Smtp-Source: AGHT+IE9yqKil16UkLMMa1KH51Cvs9G0UBDPnpq9LgjvcrdnNNDNXHdmMKrSw03O3bDV/dXgA7bc/g== X-Received: by 2002:a05:6a00:181d:b0:714:15ff:a2a4 with SMTP id d2e1a72fcca58-7290c184ea9mr6904515b3a.13.1734144783480; Fri, 13 Dec 2024 18:53:03 -0800 (PST) Received: from localhost.localdomain ([119.28.17.178]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72918ac53f3sm525391b3a.27.2024.12.13.18.53.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2024 18:53:03 -0800 (PST) From: Jinliang Zheng X-Google-Original-From: Jinliang Zheng To: liam.howlett@oracle.com Cc: akpm@linux-foundation.org, alexjlzheng@gmail.com, alexjlzheng@tencent.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: fix outdated incorrect code comments for handle_mm_fault() Date: Sat, 14 Dec 2024 10:53:00 +0800 Message-ID: <20241214025300.1697300-1-alexjlzheng@tencent.com> X-Mailer: git-send-email 2.41.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 5zubiamderkkxizst39habgk1315983r X-Rspamd-Queue-Id: A4FC880007 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1734144734-522260 X-HE-Meta: U2FsdGVkX1/PR9Y65sCa9KuADN8ydocHKeUyru9mr7sUUD0VIXi7MaKBzED0oCvwTUIkWmKfcl2XpjkuEuDepzXg8HoxfhIBCqaEf+Zr5ITOfzXAbpkMl/47P3yMpWx1Ki9sZLzcZ4YTT1Zlj3A9bVjJt1/+i7/veOMMC/TghMPHUTe4qwPDdkv3D2JwT1inJjzL2bL8pBCw78LvFFWpMEM/3gVmRKu9yfv1GcN9GnVyanw7zPjptRmRJZune3MLNXCsxyoXpLLqxqUHeYtj9noihEVYMLUn3e/zLyEGAUVpLoNO/Ao02o+/zNZ0FzBSHzO1ctH1pWqEWEcY9Xaaoz3CiqFl9m8XMGUJZYa9lAl3z0Y+9qL0KZemRH/wZXNzn2RNC+PeB9zsdmDD7q+UFDsJHjuypuwyzwMnsMSCvpHJB1GlnkKiKcO2j9F5KK5u4OWpBjwfcY16hKvEN6VRBWyIc9z/0XcBrjaEI0qiDFagfpe8zjb7HfRY841qzfzc5BFPg134ewqPCaCgoAQPs6UFb3I93H4bd3/UokqrLdg4N55R3ZTqmYmx2A6BmfuyYQWi7Lh5q/stKAhrgxsqMkWARSmcl4Pxi9yOxMAZeoQ1zy3c+WpTcutBm85deCGMb4AxFAYn2xnvB3U+cgjsPFSJwD0axezuuksaDSYWFIY6w8zmxR2Qv1hlZoHhpv12Vk17voASPlrZAtM0JlMuNWo8N83v6YVQtkl8nP1ZH1V+jJKZmSBDDJJ9ltBDRM0GtV0j0Dz56u0b5+pikQQz1QSrdp0yjFq5/vUUtTyxXmA+EAEHKeF5dtAhzXEcLKat1xRGHrH+CkT51XNz3X6Ld4cGoeFzHCKKk7PVX86FEA6G1rWuWWFC6YuY2Uvef8vfJ8yL4YuKPzUtSwBNjnqt0e2OVQHrDvDnHMIwdxNmam2iDZ70iIXEzTE2TGbgV9MCWBjzP44sq4aC3WyxxP0 od14iRUK 0zQU+PxhRaRoicMKWSZu3ovRS1qmiL+dzShFm6s7wcHOi9zFbG5hnbLoS3Ut+g/bZQaYUvIfmtyzLfC+cWjzEKe4xSNleS1AXpjfy54Admo878PB9hjRI5c2vybUONq+9pX2bKeK+Xcxe7HZNQ2k5g7W6rL7sxd9wU1UL6aQpFR8Liuul16pNtEQ5vI/ZSKsSceUztRduhrF/BtD1EWM4KtOXl+xqlAsh6mhJIGJmTYXmaxPQySV6xzfAqVQhkwtrbm+qZsMORHAhQ/6xlbLtRBRVW8nvCVIRbYERCRamEo46uiaYMl0tvShrK8ONplBZq8mpU3mVTXB8co8m2BFrOlah7r693/Gd2aRA56YVUQPZYPHxZiyxxRv67wF3jc53WAoAkdYogK7+4l637ZJEpCN7vJ8Hdj4bT87WJzsSAvlR5/Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.443736, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 13 Dec 2024 10:24:00 -0500, Liam R. Howlett wrote: > * Jinliang Zheng [241212 22:18]: > > Signed-off-by: Jinliang Zheng > > --- > > mm/memory.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mm/memory.c b/mm/memory.c > > index d9af83dd86bb..d7342a726845 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -6159,7 +6159,8 @@ static vm_fault_t sanitize_fault_flags(struct vm_area_struct *vma, > > } > > > > /* > > - * By the time we get here, we already hold the mm semaphore > > + * By the time we get here, we already hold either the VMA lock or the > > + * mmap_Lock (FAULT_FLAG_VMA_LOCK tells you which). > ^ lower case here please, otherwise looking for mmap_lock > could fail. ie: grep mmap_lock.. Thank you, I will send a v2 patch. Jinliang Zheng :) > > * > > * The mmap_lock may have been released depending on flags and our > > * return value. See filemap_fault() and __folio_lock_or_retry(). > > -- > > 2.41.1 > > > >