From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E776E7717F for ; Fri, 13 Dec 2024 18:36:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 003B36B0088; Fri, 13 Dec 2024 13:36:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ECF546B0089; Fri, 13 Dec 2024 13:36:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D70836B008A; Fri, 13 Dec 2024 13:36:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BA2C96B0088 for ; Fri, 13 Dec 2024 13:36:00 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3B031161028 for ; Fri, 13 Dec 2024 18:36:00 +0000 (UTC) X-FDA: 82890789324.24.26A962C Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf10.hostedemail.com (Postfix) with ESMTP id 88DFFC0002 for ; Fri, 13 Dec 2024 18:35:46 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=qKi7brVi; spf=none (imf10.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734114931; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QP0rLrZEOWtLvGAvpM2Dc2lFdgXH5FkqvO9qJJBzHq4=; b=zxkDQLhvPGrymc4hSloq8fsTaGspSbIqseatvu2hJ0TPaRsOFcezDLDSm4pDuwj1N8JgdU 4vdwvHR4qcZVaLmlxx8L3y93xI1tE1qRmvlFV5jU6Di7X5RX4BQQtjdHjvXWBgF6wFabsi kvph2ciQPzL3yegzonXHKJ2yq1pzIUY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734114931; a=rsa-sha256; cv=none; b=QSOudwMwA1xCAW+CmP2pXEvHHeiq3m7FE3kQdwmMB8KITxw27QqIak6B49qxywOMSp8Fja zZqpDHO0Bu6IYUl+GUAUot3EJeKcZJ9aqD6ejEfjud7P8LJ2qeZhwL90bozwq4sngY8aNc Lkivg/X/OYHv2pfZzd+zO2SZ5k3ET9M= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=qKi7brVi; spf=none (imf10.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=QP0rLrZEOWtLvGAvpM2Dc2lFdgXH5FkqvO9qJJBzHq4=; b=qKi7brVi6zL51rH4AXAGj4hZyq nzqxoZKVsx+/TMlDZdIKGvOFn/IxKZqNk0yTb+4DWTi87oJltg0ll3WpLTbfeTj76NBKqilVxjGW+ hlMt/ahJnK8/BV87QmxQLyhPrOdFbgDaEqEAE8+LJIw4UYkyZxGECyNCbKqiclsWqc9DTvxZbZT+J YI+QZRbzPqH4P2OIOYfWLu6uI9scjHZpxP7hN/K2o/6MECD3BeBxn/td2F+tE2pgLQUwouaHCvcho fmSNJD7F0GZyO2Y+uiRrkHun9hdZTYRtAH3gJ0lkw4A+suoe41dfi+P1QjfSx4lWQsi5CGT8pb5Fm zIDfmkTQ==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tMAVw-00000004K5m-0Hax; Fri, 13 Dec 2024 18:35:48 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 9984A30049D; Fri, 13 Dec 2024 19:35:46 +0100 (CET) Date: Fri, 13 Dec 2024 19:35:46 +0100 From: Peter Zijlstra To: Suren Baghdasaryan Cc: Matthew Wilcox , akpm@linux-foundation.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 3/4] mm: replace rw_semaphore with atomic_t in vma_lock Message-ID: <20241213183546.GB12338@noisy.programming.kicks-ass.net> References: <20241211082541.GQ21636@noisy.programming.kicks-ass.net> <20241212091659.GU21636@noisy.programming.kicks-ass.net> <20241213095729.GC2484@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 88DFFC0002 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: mjwuns4zowgyqgd5o1ajh5hqym1nkonc X-HE-Tag: 1734114946-164086 X-HE-Meta: U2FsdGVkX18wXK6YbCbgqQfIMZ/1ZBETz6ytPVrYxy8RqimO0+Op3eMDWsymfqHOExDrUr1LpkjO7qe4UtngeJjcyoULI5mt1IW+dFtsYuUQ55xM5tnAtSbFH6+ro+TB/W3fjtpRH3WQPYpqbzWe2su+pMsBpEVUlyhzbMtXMft/mog25hCfPxreB1JoPQvh5hRl8dBl0IUcb8loH53ynyCAndSk4RKzVYqWUMDbUONHnWWHnrAYu3JWJhjDU9LsjIWPHM+P/HJOlVreBB4qGRfX5NxVuUEij+4KJ7drgaUaZIK+ux723Y7W5TuEgyHZIC0S/wUvN4QQLIh699xsL8hRDBNVqJDtVzzaTT8JSc8wwZKeQlLp6aVQqcmb8SNki3AB0cZtI64SW3JPijJdZlVPnJiTH/AOJLAzYgU0/4h9fkVb9gLkLB6Ljw+5gZiPN4Ri0Qzv+xuITpeoF9iQ0NgtYf2Bb/CLkGoClrw0OOTRwh87UsTz40CZEYM0b93XtJkcyGvmvdB2jFtT+DqYc3Y4pHoAWGg9DVX5LhRXRlVsvvIdCNwrCBS0+SWuxeKU+MMq4MSYG9djQPOdwpODe9BIpe80LSklP4BRcBdw4Mv75zgWP1ClawwG0Jrppu/EFCRoXh5Ph9lAiPJrmH7HCsTP/OaPKprKMa9aUKzlVwMVoCDfiPhvA2SsXjNppbEXwGG2un3b8ojtn+Ha7PJwgKqiNZgy5EjGXDWv7UtJvadtTk04xZ6QX384snFTTGUietvZTIZfiLyRX2hx2vT5+nrJF4OILQiCWJzrLLr02dDJ+PGvpt9TIQVGrHNUOZBLSTOLRSmW+u6ayi0g7wRBvyY03r82QjvUDe+YeTW8l7cn1jMH2YUpMjZJlFJ22DEpavOQGjV6Urx8/svCYkBdPhK+hjGN3ZfaUL+mCCjr4n7Y4L6N+YJKS7tpwZHYavWOtILfcXhRWzeg9ObnDcJ UAiAZ8TE ixpUWythpCI4MoUPHmqwnYRabukqJ7V4pMfaNeFw6CR/p6TxcUqb+MibLPngujZw2FMOw2nDtetssCzlkYjOx/Sztv7CLjTlglhY1hEgaqy/h32incvci0ZwUnmLWHm9oK2LhKy21m6bduKqDlWQNRak8iWQtypgDZ3GbGu6lF7bMYr0UG4z1m6VTtPB2/mSy8/FmEa90v4pbq/cmduxSksULd7BhXRYsXxRkT7G3ye+Jz/OuvWDiz5TNnFj0H1mOQ1VfAwTEmTC6rGFxC0ONIoWjBk807FZSCbbIez2/1Rjg9MUcei9FT6x+5fMRyPj+4wB/q7mPQaNN9+k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 13, 2024 at 09:45:33AM -0800, Suren Baghdasaryan wrote: > On Fri, Dec 13, 2024 at 1:57 AM Peter Zijlstra wrote: > > > > On Thu, Dec 12, 2024 at 08:48:52PM -0800, Suren Baghdasaryan wrote: > > > > > I'm not sure if this is the best way to deal with this circular > > > dependency. Any other ideas? > > > > Move the waiting into an out-of-line slow-path? > > > > if (atomic_read(&vma->refcnt) != 2) > > __vma_write_start_wait(mm, vma); > > The problem is not a function but the addition of struct rcuwait into Durr, in my brain that was a struct task_struct pointer, totally forgot we had a type there. Yeah, as Willy says, move it to compiler_types.h or somesuch.