From: Jens Axboe <axboe@kernel.dk>
To: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Cc: hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org,
willy@infradead.org, kirill@shutemov.name, bfoster@redhat.com,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>
Subject: [PATCH 02/11] mm/filemap: use page_cache_sync_ra() to kick off read-ahead
Date: Fri, 13 Dec 2024 08:55:16 -0700 [thread overview]
Message-ID: <20241213155557.105419-3-axboe@kernel.dk> (raw)
In-Reply-To: <20241213155557.105419-1-axboe@kernel.dk>
Rather than use the page_cache_sync_readahead() helper, define our own
ractl and use page_cache_sync_ra() directly. In preparation for needing
to modify ractl inside filemap_get_pages().
No functional changes in this patch.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
mm/filemap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index 8b29323b15d7..220dc7c6e12f 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -2527,7 +2527,6 @@ static int filemap_get_pages(struct kiocb *iocb, size_t count,
{
struct file *filp = iocb->ki_filp;
struct address_space *mapping = filp->f_mapping;
- struct file_ra_state *ra = &filp->f_ra;
pgoff_t index = iocb->ki_pos >> PAGE_SHIFT;
pgoff_t last_index;
struct folio *folio;
@@ -2542,12 +2541,13 @@ static int filemap_get_pages(struct kiocb *iocb, size_t count,
filemap_get_read_batch(mapping, index, last_index - 1, fbatch);
if (!folio_batch_count(fbatch)) {
+ DEFINE_READAHEAD(ractl, filp, &filp->f_ra, mapping, index);
+
if (iocb->ki_flags & IOCB_NOIO)
return -EAGAIN;
if (iocb->ki_flags & IOCB_NOWAIT)
flags = memalloc_noio_save();
- page_cache_sync_readahead(mapping, ra, filp, index,
- last_index - index);
+ page_cache_sync_ra(&ractl, last_index - index);
if (iocb->ki_flags & IOCB_NOWAIT)
memalloc_noio_restore(flags);
filemap_get_read_batch(mapping, index, last_index - 1, fbatch);
--
2.45.2
next prev parent reply other threads:[~2024-12-13 15:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 15:55 [PATCHSET v7 0/11] Uncached buffered IO Jens Axboe
2024-12-13 15:55 ` [PATCH 01/11] mm/filemap: change filemap_create_folio() to take a struct kiocb Jens Axboe
2024-12-20 10:51 ` Kirill A. Shutemov
2024-12-13 15:55 ` Jens Axboe [this message]
2024-12-20 10:56 ` [PATCH 02/11] mm/filemap: use page_cache_sync_ra() to kick off read-ahead Kirill A. Shutemov
2024-12-13 15:55 ` [PATCH 03/11] mm/readahead: add folio allocation helper Jens Axboe
2024-12-20 10:59 ` Kirill A. Shutemov
2024-12-13 15:55 ` [PATCH 04/11] mm: add PG_dropbehind folio flag Jens Axboe
2024-12-20 11:08 ` Kirill A. Shutemov
2024-12-20 14:38 ` Matthew Wilcox
2024-12-20 15:11 ` Kirill A. Shutemov
2024-12-20 15:45 ` Matthew Wilcox
2024-12-20 15:03 ` David Hildenbrand
2024-12-20 15:12 ` Kirill A. Shutemov
2024-12-20 15:20 ` David Hildenbrand
2024-12-13 15:55 ` [PATCH 05/11] mm/readahead: add readahead_control->dropbehind member Jens Axboe
2024-12-20 11:09 ` Kirill A. Shutemov
2024-12-13 15:55 ` [PATCH 06/11] mm/truncate: add folio_unmap_invalidate() helper Jens Axboe
2024-12-20 11:13 ` Kirill A. Shutemov
2024-12-20 14:16 ` Jens Axboe
2024-12-13 15:55 ` [PATCH 07/11] fs: add RWF_DONTCACHE iocb and FOP_DONTCACHE file_operations flag Jens Axboe
2024-12-13 15:55 ` [PATCH 08/11] mm/filemap: add read support for RWF_DONTCACHE Jens Axboe
2024-12-13 15:55 ` [PATCH 09/11] mm/filemap: drop streaming/uncached pages when writeback completes Jens Axboe
2024-12-13 15:55 ` [PATCH 10/11] mm/filemap: add filemap_fdatawrite_range_kick() helper Jens Axboe
2024-12-13 15:55 ` [PATCH 11/11] mm: call filemap_fdatawrite_range_kick() after IOCB_DONTCACHE issue Jens Axboe
2024-12-17 15:58 ` [PATCHSET v7 0/11] Uncached buffered IO Jens Axboe
2024-12-18 17:16 ` [PATCH] nfs: flag as supporting FOP_DONTCACHE Mike Snitzer
2024-12-19 16:54 ` Jens Axboe
2024-12-20 11:25 ` [PATCHSET v7 0/11] Uncached buffered IO Kirill A. Shutemov
2024-12-20 14:21 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241213155557.105419-3-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=bfoster@redhat.com \
--cc=clm@meta.com \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox