From: Jens Axboe <axboe@kernel.dk>
To: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Cc: hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org,
willy@infradead.org, kirill@shutemov.name, bfoster@redhat.com,
Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 09/11] mm/filemap: drop streaming/uncached pages when writeback completes
Date: Fri, 13 Dec 2024 08:55:23 -0700 [thread overview]
Message-ID: <20241213155557.105419-10-axboe@kernel.dk> (raw)
In-Reply-To: <20241213155557.105419-1-axboe@kernel.dk>
If the folio is marked as streaming, drop pages when writeback completes.
Intended to be used with RWF_DONTCACHE, to avoid needing sync writes for
uncached IO.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
mm/filemap.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/mm/filemap.c b/mm/filemap.c
index 77290ac205dc..ec087bab1c97 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1599,6 +1599,27 @@ int folio_wait_private_2_killable(struct folio *folio)
}
EXPORT_SYMBOL(folio_wait_private_2_killable);
+/*
+ * If folio was marked as dropbehind, then pages should be dropped when writeback
+ * completes. Do that now. If we fail, it's likely because of a big folio -
+ * just reset dropbehind for that case and latter completions should invalidate.
+ */
+static void folio_end_dropbehind(struct folio *folio)
+{
+ /*
+ * Hitting !in_task() should not happen off RWF_DONTCACHE writeback,
+ * but can happen if normal writeback just happens to find dirty folios
+ * that were created as part of uncached writeback, and that writeback
+ * would otherwise not need non-IRQ handling. Just skip the
+ * invalidation in that case.
+ */
+ if (in_task() && folio_trylock(folio)) {
+ if (folio->mapping)
+ folio_unmap_invalidate(folio->mapping, folio, 0);
+ folio_unlock(folio);
+ }
+}
+
/**
* folio_end_writeback - End writeback against a folio.
* @folio: The folio.
@@ -1609,6 +1630,8 @@ EXPORT_SYMBOL(folio_wait_private_2_killable);
*/
void folio_end_writeback(struct folio *folio)
{
+ bool folio_dropbehind = false;
+
VM_BUG_ON_FOLIO(!folio_test_writeback(folio), folio);
/*
@@ -1630,9 +1653,14 @@ void folio_end_writeback(struct folio *folio)
* reused before the folio_wake_bit().
*/
folio_get(folio);
+ if (!folio_test_dirty(folio))
+ folio_dropbehind = folio_test_clear_dropbehind(folio);
if (__folio_end_writeback(folio))
folio_wake_bit(folio, PG_writeback);
acct_reclaim_writeback(folio);
+
+ if (folio_dropbehind)
+ folio_end_dropbehind(folio);
folio_put(folio);
}
EXPORT_SYMBOL(folio_end_writeback);
--
2.45.2
next prev parent reply other threads:[~2024-12-13 15:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 15:55 [PATCHSET v7 0/11] Uncached buffered IO Jens Axboe
2024-12-13 15:55 ` [PATCH 01/11] mm/filemap: change filemap_create_folio() to take a struct kiocb Jens Axboe
2024-12-20 10:51 ` Kirill A. Shutemov
2024-12-13 15:55 ` [PATCH 02/11] mm/filemap: use page_cache_sync_ra() to kick off read-ahead Jens Axboe
2024-12-20 10:56 ` Kirill A. Shutemov
2024-12-13 15:55 ` [PATCH 03/11] mm/readahead: add folio allocation helper Jens Axboe
2024-12-20 10:59 ` Kirill A. Shutemov
2024-12-13 15:55 ` [PATCH 04/11] mm: add PG_dropbehind folio flag Jens Axboe
2024-12-20 11:08 ` Kirill A. Shutemov
2024-12-20 14:38 ` Matthew Wilcox
2024-12-20 15:11 ` Kirill A. Shutemov
2024-12-20 15:45 ` Matthew Wilcox
2024-12-20 15:03 ` David Hildenbrand
2024-12-20 15:12 ` Kirill A. Shutemov
2024-12-20 15:20 ` David Hildenbrand
2024-12-13 15:55 ` [PATCH 05/11] mm/readahead: add readahead_control->dropbehind member Jens Axboe
2024-12-20 11:09 ` Kirill A. Shutemov
2024-12-13 15:55 ` [PATCH 06/11] mm/truncate: add folio_unmap_invalidate() helper Jens Axboe
2024-12-20 11:13 ` Kirill A. Shutemov
2024-12-20 14:16 ` Jens Axboe
2024-12-13 15:55 ` [PATCH 07/11] fs: add RWF_DONTCACHE iocb and FOP_DONTCACHE file_operations flag Jens Axboe
2024-12-13 15:55 ` [PATCH 08/11] mm/filemap: add read support for RWF_DONTCACHE Jens Axboe
2024-12-13 15:55 ` Jens Axboe [this message]
2024-12-13 15:55 ` [PATCH 10/11] mm/filemap: add filemap_fdatawrite_range_kick() helper Jens Axboe
2024-12-13 15:55 ` [PATCH 11/11] mm: call filemap_fdatawrite_range_kick() after IOCB_DONTCACHE issue Jens Axboe
2024-12-17 15:58 ` [PATCHSET v7 0/11] Uncached buffered IO Jens Axboe
2024-12-18 17:16 ` [PATCH] nfs: flag as supporting FOP_DONTCACHE Mike Snitzer
2024-12-19 16:54 ` Jens Axboe
2024-12-20 11:25 ` [PATCHSET v7 0/11] Uncached buffered IO Kirill A. Shutemov
2024-12-20 14:21 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241213155557.105419-10-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=bfoster@redhat.com \
--cc=clm@meta.com \
--cc=hannes@cmpxchg.org \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox