From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47917E7717D for ; Fri, 13 Dec 2024 09:57:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF4CE6B0095; Fri, 13 Dec 2024 04:57:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA4EF6B0096; Fri, 13 Dec 2024 04:57:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B46136B0098; Fri, 13 Dec 2024 04:57:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 975DB6B0095 for ; Fri, 13 Dec 2024 04:57:40 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 53FC5160C99 for ; Fri, 13 Dec 2024 09:57:40 +0000 (UTC) X-FDA: 82889483376.16.43FC9AD Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf05.hostedemail.com (Postfix) with ESMTP id E1E5B100013 for ; Fri, 13 Dec 2024 09:56:49 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=VIaV25qI; spf=none (imf05.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734083841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IKB16nwXnndSPN5V09g/4Cj7n9/Vu7tXt/HHKYJ74/w=; b=3FIRUg0OSu3lnAeK/hXD5GfR1d57iY88bMovqDhMd9gvdwDv2ARpdYy+yifrAn4tZB3xKR /w82Y1tl0HcAJFUdrQCy5Nx2/IQlI4ZeFOAeQhga+CIH74cIH7JN8cRnqwBfeA3s3DBcUH bwdwjDIzAtWF+iGDTKviJr8A6wNw8+I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734083841; a=rsa-sha256; cv=none; b=rhOcVRfTeWUa+yRTeletIDQTYNNkcHzxXuFEAQ1Rrgt0P0VnIo0lf1zA4dYmvItjfmZXL9 Ci+0HxBc9u1ItTEMgFK/Zng3RL+0Ex5kYPIVE1zrog+9IaofUZc4znjEmIy2rUFPuThaMr h8/Rih9OWKGYpwr5BCMmJvW4BNZRx3c= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=VIaV25qI; spf=none (imf05.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IKB16nwXnndSPN5V09g/4Cj7n9/Vu7tXt/HHKYJ74/w=; b=VIaV25qIJkuNeZU+avLzCBIhhZ zQ/ialzox4iSoBMzJuHmFicGSM5ya0ahP43v181jm9BEllIcULQVcCHkotTna6zQ88ap+UP81aJNA /OurAk7GbUhjM2wOPA8z0oDcRN6dCfG+1zv3oIDZIWKWaD61B+1yY7slg82rPy8raDg1zGpb5Tbqg cfk0vt8GyRrqfk4VygBHdZMRgy2d73hYpOEUihSjPFYRGJtjYJbbyXz4CdS+N9sVXSJHO3xk4IWdV htRplg+W0Ddf8sP/QP3XYEkBL3LR5d/1946ztVr5bH23zvolWJkY3VSApxQpEXJ0tGSnNe1Z/8oYT tL4vkEIw==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tM2QM-00000004FUL-1Fnr; Fri, 13 Dec 2024 09:57:30 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 5E91E30049D; Fri, 13 Dec 2024 10:57:29 +0100 (CET) Date: Fri, 13 Dec 2024 10:57:29 +0100 From: Peter Zijlstra To: Suren Baghdasaryan Cc: Matthew Wilcox , akpm@linux-foundation.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 3/4] mm: replace rw_semaphore with atomic_t in vma_lock Message-ID: <20241213095729.GC2484@noisy.programming.kicks-ass.net> References: <20241210223850.GA2484@noisy.programming.kicks-ass.net> <20241211082541.GQ21636@noisy.programming.kicks-ass.net> <20241212091659.GU21636@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E1E5B100013 X-Stat-Signature: qkuegjhwcmqpth6fj7w1bafgec7pc5c3 X-Rspam-User: X-HE-Tag: 1734083809-411379 X-HE-Meta: U2FsdGVkX18DPeTuBrx1xCBZB27hssLe6ednUUBuW8K1EbupFIe/THw0Rb3XqZkvwAwcsiX3e3FYhPBZe1iKL8Pr9WGSU7PM9F9fESlgQdA/7k1Buoj+mDEXJ7kbTPH1VJBbVw+1+ySa9oy7rV8yUVjIT7Y51KXk3M7EXYZ6UmBg4OKCbJMaKkaXi+4me1+mEN9F36y/LzO7s6sQd8OPwf6IZaRpNtyIXgfhq9PHx+9j+z8dcGsh5Z07Ou7/xyrEFlZFpavH8aVMYeztbdLD9/+spaQjHxvYWaM61Vq8322tNzPOi3/AOIci7kc4KBRDrXA2SyZN6SbBQUeZMDt8XHWIN8eQ8jO2r24jooFdwvOqDdvDx3a1xt+8eBOLogcxFNjDV7DHLUCvi0b1p8ldFNUBJPBYRGnqK6l2Edy1mc4d22qs2K0KBNn+Rna63duQfF24lpG9EBhv7xt0+zRFN/fVL6Fwo/eeRfCPqzEEjhmpLXo/0GADVbk3vye/abbc1tkeLoBsh0Ol/SnEAHgS888TO0Hi3jblA3A65oTifYJ7ldtbQXfW/R+0LCNCWDo2HhVurSQqj+kjurOqJP+uWx5eRILGPrXGb7p7xHQ6idmCIaiTjnyGwRCb5XBhQU75uOwhsQovKzmLszNv+H5DF29I0/+xL1f/UGj4rg24DlLPeUbjgB+A5x9uM/CULa0Yi/wvAZOmTd4UbrTMkdMlk9Qb0BaE45rkgOVTOypXpBKF++StqW+v5+eQYIMqNha8aPEGFuqErac5XJLB1utjwAkM8Z5WieTvmXiJtg/KHYHPxJu1X77ThxrVP1qL18CJYKFmseRYC+KPp9L2AAN1FcXNT2cDhHYppODDQSTG1SP0Avd/nVRxCT5jBDuE0hn+M6fG/BMosQk3LK4prxaWHr5xAq1Os43PAM/W+EK6aNaamWN7w2UPi53Dwsgqv9d/8fFrxy/oz5fLZ2ximBD Zgfq66oH xioIzd1qM1rR73pm524NiIBSVKd8irCcYIXicvJn/ILNo0EpgxTZdzD6y6HFmBFC3kIJkyL0bkdKUwgbf11/DkQ59Zs6jfPUgWG8WKE9FNBWsfG/bzxFmoe4S1VWLoos+CSIG512BJKvoo1NP8TWeKB53YQOx3KkQMT+0GOSYwvaCnVMWuzpLxFz3AFqzVvQrV3ysJvgprricihodNaqQiO37JC4S7WwuZ/q+SvLq0xIMU6vs+kBo2jXDjicKGJMN4CNxotlywJoG0LkbL6zkIhAKY1Tcur3YRUGmxrHYV5AyGhCiJfcBdnenPl6mcHineYVF6OQt3Sk74VCxsHs0Z3Cn5KfW2pAMiyQrYKpUhkTzPKs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 12, 2024 at 08:48:52PM -0800, Suren Baghdasaryan wrote: > I'm not sure if this is the best way to deal with this circular > dependency. Any other ideas? Move the waiting into an out-of-line slow-path? if (atomic_read(&vma->refcnt) != 2) __vma_write_start_wait(mm, vma); or somesuch..