From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C932CE77182 for ; Fri, 13 Dec 2024 13:07:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4816D6B0082; Fri, 13 Dec 2024 08:07:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 40AE06B0083; Fri, 13 Dec 2024 08:07:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AB886B0085; Fri, 13 Dec 2024 08:07:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 019006B0082 for ; Fri, 13 Dec 2024 08:07:52 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7FC421C6222 for ; Fri, 13 Dec 2024 13:07:52 +0000 (UTC) X-FDA: 82889962470.12.0BF89F6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 33ADA20011 for ; Fri, 13 Dec 2024 13:07:39 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=boBHWnff; spf=pass (imf03.hostedemail.com: domain of mripard@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mripard@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734095246; a=rsa-sha256; cv=none; b=YjmqhWecn4g2GTvKt3cc2HGQmJHQmOvDHYg4Tu0fpvzzQh7pRbGx6Gzvgt29QOE8PBZUzo ddopIxEskdBAUsIct5d6mbepMF+JJ9WwaEn0ZKzbZrxb6rTMe5BDcjX4FnQHzm6GK5xbti vJDIa4NPVlNUzCsVRh6rL722s7Qq9+c= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=boBHWnff; spf=pass (imf03.hostedemail.com: domain of mripard@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mripard@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734095246; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uMeScOuP+OJQ7++MVgDmQiNlrlV1cFBdw7c/2oZGj7M=; b=U/qoV44y0p6vTfo27DV+ZXutTyQdiv5TKwgFHoad84lDJ2zqHgas+6wnK4IrZSeQtnPIGa l7FkHbpxyAjAmD/9FjZ2Mv3TKg1LiymeKsfkKV2vJQwis5q4z4EFBYf+SR4yfbhsrbsWUG FB4yP3f20IOWMVEjpxsMmZ9awkSdeco= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4DAD95C6C45; Fri, 13 Dec 2024 13:07:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7CF5C4CED0; Fri, 13 Dec 2024 13:07:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734095269; bh=uMeScOuP+OJQ7++MVgDmQiNlrlV1cFBdw7c/2oZGj7M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=boBHWnff/hgF7FYpIcsbAdtTvCOOWyqgQsee2l9hMkLuPWV4IsqpqT/Zol8V/qD5f vcJ08nFVsJudxKOCrDLx9T1Y5+/XYlXgrAtLgSApA2Ww9+2K9uMW3ARAVPHr+A8eow p/9UANhuvy7QD6Ui1V9/9c2FRbbEEkUor1MFWxGq0yrd0hNDxlfYNH0aKfe7qDvLXq UIazpUkuxj8v0414ScUCdzRNaj2WA7GJUo0EeSs9coMoh5uZtOcX8AX329P+qdoFXz ja9Hbp47XFsAbR39aR7Bp2Mu4smGtkouBFVMarZKi7Sal39ezC2CggPXSeWaBFa1QK OPyLB2/6FvJWQ== Date: Fri, 13 Dec 2024 14:07:46 +0100 From: Maxime Ripard To: Friedrich Vock Cc: Maarten Lankhorst , linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Tejun Heo , Zefan Li , Johannes Weiner , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, Maarten Lankhorst Subject: Re: [PATCH v2 0/7] kernel/cgroups: Add "dmem" memory accounting cgroup. Message-ID: <20241213-sceptical-maize-gazelle-fadc34@houat> References: <20241204134410.1161769-1-dev@lankhorst.se> <29a71119-04de-4c76-a98a-d0fcb906390f@gmx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="xokrzpyhqued3d7l" Content-Disposition: inline In-Reply-To: <29a71119-04de-4c76-a98a-d0fcb906390f@gmx.de> X-Rspamd-Queue-Id: 33ADA20011 X-Stat-Signature: j4xowrdsfjd4azbfnft6o8n6dfmqbr47 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1734095259-266816 X-HE-Meta: U2FsdGVkX18iIBWK6CZ/5X0YMuA2VUkUjs3vJ6uTN69kY00CbI+13KXpgO0w2g12b6wxpk0YeIfW+6pvNRwn80QiSRtuP8zQCJQSzSSKIvS0aSiYspMtxDGgzArMg47qpkSpTm4lJ/Y0qAclbjv+BDVZzs9lzxDRCxmpzp9mSkwuWgbjmR/+Puke9flwSyg3ixsHybNQv85QQ+2rM62lZ8yBKRzze1CYED42cqCPtOEkZIn7EU4CeAgnTR1t6oYjXsWO3/XTQNAgQicIriOt/ta2rJyBqKu7Z+uYvARJmeRhAkRtmaBQtOjLsYbRiw7y4fe/jSg15+bahANl6nwmERoEukcMx4/4rPlWspX5OxQjqAGpZuag8+sDUm4t+Q588bKrPLOjQPJ/KuCQM5+WhqJCTz/s4D5os+N3ePeM4hxs4edDPFEZDJSP/ypyftxvxkAgDftlxJKh9/zqgHzD9swieIujU5oubA1Nf4bGIPaxGan5H6g8eQONs+MuaAAQ9pBUhenQmm70pz02DCPQlla7sMraki5b3ulpaZGWiAu/n1MWB7NDNoMngkyRmxOW6RIDCm3lf23Ck0ejRR8uomkuhvnYJEg50Ux27vEcBc6M2bqivJrkgpanyT03Njw8IUDTZZKONahFmOXOWdv9wEehnDTFxNh8Byh0D+SuXuheloQPST3borAWJ2JyJZikDfphYmLvsxlXTNIzhjXUtulRNQeB/xcDzPNjw/2D490V5JR72jY/Zzft4SswFmlDfjQGbGvkRlcXez+e3UX4osGZltWNsFS31j1WkCZ4jI6p3i8OVX6c7Q0umodmvstFu4V96U3bcN+7RPvGvx7t174d54tphFT/7NN2tlJF1cskocE9DHTP/kA42iD44iVO0G23jWirkeHjo6QBAI0dJx3k5ELdRoZfqCIRc+bTQTCRr2wFShYp1/I7jz4Lnn0BrStySv/WqJ3M5Utjdjw wFSSf0Ex 44jEP9eBE2kVBUiKJYaskBf2SyAx2NXKzo+ab43tVi81ogy88FvVvZI5SBN6oZEgkW8WzdQLCzUUYVUuukzIo7lR8k1ANL42T9J+ThIcVSW4FBectlnccrCwwJSUD0HxisAK36y+wWwYC3zPfsrgSqwmgU4Fbwup3JghXmn7RBwG22tPzCbMBx6giiYBp2KpY+cNlosvLPt+3KyRN2/2iP98L4ZfzVQssUusz/OJPRhMzT9UxUJYV2a2pNLrrEtejuYDWLQNcuL3kA9uluDmB9CAoXGAYFIqgzlHMKfB51YvnnK7SBEWedyvGe80nbV4fQMV6/AfF/NoB8Qay7VWdOqe8GRzSZvtLma2O X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --xokrzpyhqued3d7l Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 0/7] kernel/cgroups: Add "dmem" memory accounting cgroup. MIME-Version: 1.0 On Sun, Dec 08, 2024 at 01:15:34PM +0100, Friedrich Vock wrote: > Hi, >=20 > On 04.12.24 14:44, Maarten Lankhorst wrote: > > > Because it only deals with memory regions, the UAPI has been updated > > to use dmem.min/low/max/current, and to make the API cleaner, the > > names are changed too. > >=20 > > dmem.current could contain a line like: > > "drm/0000:03:00.0/vram0 1073741824" > >=20 > > But I think using "drm/card0/vram0" instead of PCIID would perhaps > > be good too. I'm open to changing it to that based on feedback. >=20 > Agree, allowing userspace to reference DRM devices via "cardN" syntax > sounds good. > > What about other subsystems potentially using dmem cgroups? > I'm not familiar with the media subsystem, but I imagine we might be > dealing with things like USB devices there? Is something like a > "deviceN" possible there as well, or would device IDs look completely > different? I have some patches to enable the cgroup in GEM-based drivers, media ones and dma-buf heaps. The dma-buf heaps are simple enough since the heaps names are supposed to be stable. I don't think using card0 vs card1 (or v4l0 vs v4l1 for example) will work because I don't think we have any sort of guarantee that these names will always point to the same devices across reboots or updates. If the module is loaded later than it used to for example, we could very well end up in a situation where card0 and card1 are swapped, while the constraints apply to the previous situation. Maxime --xokrzpyhqued3d7l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCZ1wxogAKCRAnX84Zoj2+ dq5iAX4rcVUShdPwwoe/RfA57qN/7Mx6+hgYbzJMWnzIBnKJz0dn+kbUlv3KGdwz hWlIPsoBgJvEzg91vZJBiGdsdYRPIlkVHTfuFH/UOtHiSzM1KliMd5zv+JdtITN3 VU2IF4OnZg== =efDB -----END PGP SIGNATURE----- --xokrzpyhqued3d7l--