From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6727E7717D for ; Fri, 13 Dec 2024 04:12:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 620E96B0088; Thu, 12 Dec 2024 23:12:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D0BA6B0089; Thu, 12 Dec 2024 23:12:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4987E6B008A; Thu, 12 Dec 2024 23:12:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 29ED06B0088 for ; Thu, 12 Dec 2024 23:12:16 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8A6691A0C90 for ; Fri, 13 Dec 2024 04:12:15 +0000 (UTC) X-FDA: 82888612632.23.FD8537B Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf19.hostedemail.com (Postfix) with ESMTP id 4F4911A000E for ; Fri, 13 Dec 2024 04:11:47 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=uUrqx2lt; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734063122; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eUST7hBYfBZi465izGK8dbnDoURVxiydmsWY1/28h20=; b=CyCWzHfrQQGZ5B6C0pO2UNDbEIEWHgPEimSTEqOm7zDmLv6VGENHfPElhK4uTCy3Uy5A3Q /1t6GKXr5tjVTnK2+hkws5L9GkwDc9VV/7//IGxeY9LCdY5T9qQnwWPcPUDYjh0uHFtx5f 5X2wvwRA3A1pbCnuDRE/5pmc/MKUl20= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734063122; a=rsa-sha256; cv=none; b=ZAFgswol4OwgXRnfne9jLWDrga2vlf/WmSh4vXHy60J+Rczk7QWu58I0VvwOzraWm4vMVH TXnkrVtipxbcDTydg/3kS0comSOEK7oH36elrzmCP7sNO6HgJqxcigTQ55yr8WO7RLRWUL Bx5ngvglN2S4gkU9dObBBLR7BRFRZCI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=uUrqx2lt; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 1DDEEA41D7D; Fri, 13 Dec 2024 04:10:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACC82C4CED2; Fri, 13 Dec 2024 04:12:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1734063133; bh=l7+0soeLZV6Tw88As9C8X85YyYlNicvO0yLGnHWSOIY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uUrqx2lt0ci4QISGJJyjYSwwnPMgN93yieOP/7gPivjxgfpBIIpI7WDM+Iqkf+HMb 71ZgyDAM0tHo4XDsuoS7Nxa1w2rKX78q+O/OSwMXUE7XCC2HuAHUE0JiCfl0j/mOTA icMhtwsYogA6BKeo60OBca4MMcoRjH7NpAAUVdGM= Date: Thu, 12 Dec 2024 20:12:12 -0800 From: Andrew Morton To: David Wang <00107082@163.com> Cc: surenb@google.com, kent.overstreet@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lkp@intel.com, oe-lkp@lists.linux.dev, oliver.sang@intel.com, yuzhao@google.com Subject: Re: [PATCH v3] mm/codetag: clear tags before swap Message-Id: <20241212201212.c61bfebbbdb51b3c8bfeed11@linux-foundation.org> In-Reply-To: <20241213013332.89910-1-00107082@163.com> References: <20241213013332.89910-1-00107082@163.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: mbd5fk7fntbdbo337733k4ycpbzehmwm X-Rspamd-Queue-Id: 4F4911A000E X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1734063107-205562 X-HE-Meta: U2FsdGVkX1+GTA0YJHxcxOXUaXHTLNCrH5t2v2g1qSW8EdI6c397M97UYJJV5HvYBCFiqlAOiSZmBSa5/JosNF41TcNs9GkWLZvZImnPTZrVgaC+9kAF95AN3W+mINi+HfAdFVlInVR5k7TQjaknBos75zQw3VZae0vjG5xIEAWH01tCRykSSh+X+99Jq0Jepy9M2rdI6AogIkJq5GDrjBGlPfF4+gk5IOD5rTxsqc57LGvIwkjn7ftCUt86NHibBWb7Rb6JUT/GL1HfTBktp+fgOmcWvfRr3IwcYM24Fj7Qo/FoB78bFOz7uL5w37rR9y+pB6TZYkVM81kRr7O6t9AR/eMKfqjIMaNFCmrophxZB+jL48NICxBgEqneSZgVkmi3O7yVDktOYme5/DYStyd3IJSFFB0durYZC1ihdPS6CVmbTBCH7AE9TYnrqC/serEoa15JZ6zYbiPLH9MFByZFQSsTiyySi+JcSd2fLgItjUW9snCXgJAHMHXqfrj4zYBQwgKl6fokK9y9ZGKqN7zwv86HQB4i4MXUEOik7Yeo0Z/GqkeRiXHCcOGgfgQV84EM+06m7k3A+P46XhI0iYrfokqJXArw1R3518gDUikQTBoEG7+MlSbVVX4DEhA6GN8TLNWYG1TKSDXi6bUPEkKqYIe7J9vD0X1XlCAgcfO0iaXT5JipSQMWKqTsESeNK1Bj4nVrYudUl3dSOtyrXp3Y49BWkik8Zq1EnI2qfPIaqLplns/iUN081eULpV9Ga/ABAm6FUWU7R93c9rcmO5ColQE7yB5PbhFCHcuw0W+6CaIqHM6Qib5h12bMMysvN/RX8VI3HfmTJzdCTTaEELOYSWv5IrMMqbM/NmE7U+euJyOxS+ObU37zILk/Oc4mCfY1pDOKYiUdRZAlI0lnnkxALlt3AuWyMyR+6KTbLXFJk+RkqXHuutP8p4ua0FOblThn8tZBY+FW6pxZPAf 4KeX6ze9 74moOSjyRDHMQ72bog8CNibnjBZafQh92EYfS0gJYtzWLVqhbCxY02iDlh6m9iXjk7Wx13AgyZlA01NR9nuYYDKBwv5+2IlzXGFuSA/4WafOyTaMtrojuCcoUCC/7GPF7+BkaMwL3Oa3d94zJIJg7ZMxyG6F5xjRUd/W4R4HqHaJLhcnh4tAA7bUsywIdfLgBkaI58RnZPrxA+5udxFwDCL/GOg5S0ADGRrEviAwv4QYG+3T0Gcrv/T/W7pJZ5FZcvjrbDzHCk9/CPhuLnWKG850iqbYFoBaqc3jQar8SsJZnDJckhuACYtgMhlsqD+exu8f690/Of7YlpNfN1L4YGswrP0NqryjpdJrQX9btvg5sfdl1bRtccZ5wPe7gNzbH/Gdssux39L+ZBRMCT2EhjK36Pw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 13 Dec 2024 09:33:32 +0800 David Wang <00107082@163.com> wrote: > When CONFIG_MEM_ALLOC_PROFILING_DEBUG is set, kernel WARN would be > triggered when calling __alloc_tag_ref_set() during swap: > > alloc_tag was not cleared (got tag for mm/filemap.c:1951) > WARNING: CPU: 0 PID: 816 at ./include/linux/alloc_tag.h... > > Clear code tags before swap can fix the warning. And this patch also fix > a potential invalid address dereference in alloc_tag_add_check() when > CONFIG_MEM_ALLOC_PROFILING_DEBUG is set and ref->ct is CODETAG_EMPTY, > which is defined as ((void *)1). > > Signed-off-by: David Wang <00107082@163.com> > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202412112227.df61ebb-lkp@intel.com This points at 51f43d5d82ed ("mm/codetag: swap tags when migrate pages"), which had Fixes: e0a955bf7f61 ("mm/codetag: add pgalloc_tag_copy()") e0a955bf7f61 ("mm/codetag: add pgalloc_tag_copy()") had Fixes: dcfe378c81f7 ("lib: introduce support for page allocation tagging") Cc: And I'm thinking that this fix should have Fixes: 51f43d5d82ed ("mm/codetag: swap tags when migrate pages") Cc: