From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B204E7717F for ; Fri, 13 Dec 2024 02:36:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E19026B0085; Thu, 12 Dec 2024 21:36:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC9536B0088; Thu, 12 Dec 2024 21:36:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB7646B0089; Thu, 12 Dec 2024 21:36:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AEF2E6B0085 for ; Thu, 12 Dec 2024 21:36:08 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 50B0012034A for ; Fri, 13 Dec 2024 02:36:08 +0000 (UTC) X-FDA: 82888370208.06.F0EF75A Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf25.hostedemail.com (Postfix) with ESMTP id A15F3A0004 for ; Fri, 13 Dec 2024 02:35:48 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=K4Hx8Xfk; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734057350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hCePYTl5clqCp4igS8slSdkf7tZXOXTC19QzMvedAw8=; b=oc1OTUrqmloq05vkSgOJtI6JJBpnQYmlHd/gb94cIXRnzizodyiuBKNr43KW6BVIFLX+4k ds+ZDuQCS0DFT+gzLumsbjeHFmGF40zsQRsHt/KkARxvJiCcxyz7B+kb+MdXZQ9C0DayMT ++oCeV4pHDnv2TS6/brjRUMQHCVZUaE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734057350; a=rsa-sha256; cv=none; b=G+M8okwQHaJH2uuqrhZ/cTLcAKXWXqVTbTdHCnbL9fcCw5ZZ5r8UBFt9mAnCAjupfViDPu FDcDMeLeSGkcB018w3rU0LPdIgbqbjKEPlhrKcKZTA7qCbytDl1bHtoX7Sp0/LLDreKIs1 toJ2ts79F5RRSXFqyl1qwkkKMz5TnDw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=K4Hx8Xfk; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B53C1A413B3; Fri, 13 Dec 2024 02:34:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 642ABC4CECE; Fri, 13 Dec 2024 02:36:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1734057365; bh=DjWZMTqJOcRGgdA+uiArB4Op70x1IL0Km0ID99UMobE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K4Hx8XfkpNfpyOC+b4i6l5IP4hXeIp3wFWmEt0HA18ybFM0TGTL1JJhvOkEcBHyu1 yW2wN2+b0b7Mr/hD47CUEfjp2pq8RZyAiqhP09TbWK5fpOv2RuTup1I7PacdYwDi2x /PE8yPS1/KAN8Zw9nMIr6JVzBoPJvQx0Swgl+Amw= Date: Thu, 12 Dec 2024 18:36:04 -0800 From: Andrew Morton To: Lorenzo Stoakes Cc: "Liam R . Howlett" , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: add comments to do_mmap(), mmap_region() and vm_mmap() Message-Id: <20241212183604.9da0c62eaa23770092798767@linux-foundation.org> In-Reply-To: <20241212113152.28849-1-lorenzo.stoakes@oracle.com> References: <20241212113152.28849-1-lorenzo.stoakes@oracle.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A15F3A0004 X-Stat-Signature: emhgge9msu8mn1r6e65qinrenujpgjqb X-Rspam-User: X-HE-Tag: 1734057348-821460 X-HE-Meta: U2FsdGVkX18bpLyCKDM9qKpIpnMoTdc8+hgrUBw5ubbi0k0sk3W7nnk3Eco5TM8bW5hurkEmWVe6HtDEKnAW/h9CB03rzMff9777bB9U+CXXxBbappL55Zytf/wPYhdthpFdk5WJPUqFGUxYFHScwRtijdE5+CLEKWYeJEFcy2IGemYmQOEiIoBX0c1kCwd7VFKmp6MZGA34EwHvGpVA3GpyAlj9DuAaPHG2lQmiBSWbrpoeV1BpO1RzDtDaTYhJqOat/gkgyyK8AKrMytRRfHySEg+/10JmVzvLvsJ3hqJtlE4S9fxyMtB/u3SMI1sRzZuSkcDALNVUEZg1Z+1/RjVMTkntJip5ZM/dGehDF0sPQjIXwvXb5850GZhUcbFr5oZ8Ku945+F0iqSI0HWbkgMjJBSLH43zuKfl2ACPyUXyHmnRwWUffP3Yjy/V8OLF/OegWD/AZUEPDBXxOs/3u4wCDkwqdWs+PtcTdpIrL6KP2AEoIsp2C+WrDNANHOK6ue04jK4fgWy6zWa9C6NjsddREe5SM+NmvmoHna9f7DNGqP99GUwVV6jlVOtw+iLGthIkPvw4lzTc67tlMjgHU+DNGHJSg9PFZLob8N0woV9PT8xnpD3YVESZPFtT5sP88IGM2ODCRiDRE1L2/0jtLnOjbb3TqDTzRAh64w0VtUeYJZXc6d+xc3ae+bb1JzneuyvhiFKEGne5gzbdSaUw3mfwirHX7CFRjprDR2p11AUWCnK3ozPm/F/BMPSxgBifEBB2CxHtFmRn+43ca9b00msWfKpGVKZ56fNcQq6qa3OvDz2LJ423aPX4qTrkVDTIq61eSL47vKUujE4isqLyqW4DT/QE4c5/yH41FGB4B1raolKmTl3i2JKg7yctsYG1HQslYjmlorROFRsPuXveuE7uGfkh04uW1ULCsvpKsuDVORR1stpfbnaaC/5i3oDD7tG9urm8a3PPYCDUisx yWzpXhC3 aRB6gvKrjfEaVbbOs+ICggIsbKW7uAro8IObpaOQIi8+9i7G7KNcwPY4SdTTfRjFWp3SmQdU3suZwRt29vZVSt2lYkXkFn02rPUZ5fR1kB/vdOlrG0yt0Ay0fLqpK9wkdXoCzs7TZyyvSdPbsCY8CoJnsHTcgCI9hex1JVk8iJ/Kf9jvDWmKFUeDDgnki/9rVGjTu5E0hzFfVlSRZ7ehATzDvlwzFQslcYIjwoKWrIayYG4Cla1Leqji7jh1gLVeeTE0CorpwVr5or2NyWAIh2BYR4WVgkFgq7+mp/xGmH8WCB+rirV+gY36DlampVpB2PPYN X-Bogosity: Ham, tests=bogofilter, spamicity=0.003847, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 12 Dec 2024 11:31:52 +0000 Lorenzo Stoakes wrote: > It isn't always entirely clear to users the difference between do_mmap(), > mmap_region() and vm_mmap(), so add comments to clarify what's going on in > each. > > This is compounded by the fact that we actually allow callers external to > mm to invoke both do_mmap() and mmap_region() (!), the latter of which is > really strictly speaking an internal memory mapping implementation detail. Thanks, the world just improved. These functions have pretty dumb names. Patches to give them more useful names would be small...