From: Andrew Morton <akpm@linux-foundation.org>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: "Liam R . Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: add comments to do_mmap(), mmap_region() and vm_mmap()
Date: Thu, 12 Dec 2024 18:36:04 -0800 [thread overview]
Message-ID: <20241212183604.9da0c62eaa23770092798767@linux-foundation.org> (raw)
In-Reply-To: <20241212113152.28849-1-lorenzo.stoakes@oracle.com>
On Thu, 12 Dec 2024 11:31:52 +0000 Lorenzo Stoakes <lorenzo.stoakes@oracle.com> wrote:
> It isn't always entirely clear to users the difference between do_mmap(),
> mmap_region() and vm_mmap(), so add comments to clarify what's going on in
> each.
>
> This is compounded by the fact that we actually allow callers external to
> mm to invoke both do_mmap() and mmap_region() (!), the latter of which is
> really strictly speaking an internal memory mapping implementation detail.
Thanks, the world just improved.
These functions have pretty dumb names. Patches to give them more
useful names would be small...
next prev parent reply other threads:[~2024-12-13 2:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 11:31 Lorenzo Stoakes
2024-12-13 2:36 ` Andrew Morton [this message]
2024-12-13 9:22 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241212183604.9da0c62eaa23770092798767@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox