From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96748E7717F for ; Fri, 13 Dec 2024 01:39:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0C6C6B0085; Thu, 12 Dec 2024 20:39:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ABC8F6B008A; Thu, 12 Dec 2024 20:39:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 984836B008C; Thu, 12 Dec 2024 20:39:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 76AC86B0085 for ; Thu, 12 Dec 2024 20:39:39 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1C66CAEFAA for ; Fri, 13 Dec 2024 01:39:39 +0000 (UTC) X-FDA: 82888228332.18.3D93A75 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf08.hostedemail.com (Postfix) with ESMTP id D862A160004 for ; Fri, 13 Dec 2024 01:39:20 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NOajGzF7; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734053951; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XDf95d9Uka+UIYv5wGQ9WydOISmAvXQAo6tglVHRDi0=; b=QTF4h00qho+kn05DxD95c2QF449ipgxgomkYoB5Ooi/3z99zRhDPDRW3huGiXQXrEygzjk QS1MBINtDPQeZzYAuphgq/qI06/hDmRU0reuEY8q1MWpRow6YWBh/+YPOYLssXPemyt0Et zYvS100/r2DUHwqFR3AFtje/c8JiOls= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NOajGzF7; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734053951; a=rsa-sha256; cv=none; b=cO/NwQX0VKB8mdedsfZWBfBQo/JCEANSNdPur60UunD43SBhb04rqvhllfQ8IWU67Fr1+M 1iJJ6bLp+NQn6FYaTNOs9QFwf7Iu7oKbuLjQQhcYGK0YcvmIywXFPHhWVNG9vRvteUOXqR pSUM4uJOOtbJKfYNEr9w9FDJ0atW02o= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 50A5DA40E72; Fri, 13 Dec 2024 01:37:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA84DC4CECE; Fri, 13 Dec 2024 01:39:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1734053976; bh=z6KasiqXW9OocT/gPdXD8wxFCgxz3hJU5rxa3NS7ujM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NOajGzF7Oghi2j823OVBOAGjMfDE2y8sqhBtABteyi+xNwCVBGrHLGBc4kP8k/ZzS nGpVqOiOxYmCXtpYVq8CDh3d/Emvq9T/1xFLC/6g4wNbedpjpYuIv/cuTxF0CeV0MY ibJbSfQIh1u6+D2zMIFRD+W8TWrIVtCfqGegBRio= Date: Thu, 12 Dec 2024 17:39:34 -0800 From: Andrew Morton To: "Liam R. Howlett" Cc: Kalesh Singh , lorenzo.stoakes@oracle.com, vbabka@suse.cz, yang@os.amperecomputing.com, riel@surriel.com, david@redhat.com, minchan@kernel.org, jyescas@google.com, linux@armlinux.org.uk, tsbogend@alpha.franken.de, James.Bottomley@hansenpartnership.com, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, davem@davemloft.net, andreas@gaisler.com, tglx@linutronix.de, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, chris@zankel.net, jcmvbkbc@gmail.com, bhelgaas@google.com, jason.andryuk@amd.com, leitao@debian.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, kernel-team@android.com, android-mm@google.com Subject: Re: [PATCH mm-unstable v2 06/16] mm: csky: Introduce arch_mmap_hint() Message-Id: <20241212173934.4dc429716acd4c71a76e15c2@linux-foundation.org> In-Reply-To: References: <20241211232754.1583023-1-kaleshsingh@google.com> <20241211232754.1583023-7-kaleshsingh@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D862A160004 X-Rspam-User: X-Stat-Signature: o6w9beg739tticwbddj6m8coafgfj7g4 X-HE-Tag: 1734053960-262865 X-HE-Meta: U2FsdGVkX19cM0RWinP2y++6kqKZmFRr8bnMLuGGbCBPjDc8fRDRBeoPK/aODMVjPKd5i3xHe2rATw6Xk+2b6oF2ENnjeCMMRoFXxwvw7y3DvtvqI1LPotTNlrLktOne3ifucOPqoer5bQN8qdfRn8ZEpwcBfrBjs2Z1yEmWvcdvHgI8IwKhwVySfLOBXjEh2j6/R6IPc0dMZnPCsVWyOwkEtGNwDeAs2hHfxHR3di0eGA7HaCy4XO5+pg/UtAACPb5JoKXAvXjBBWNRkM0M6ryd7cMYLnjdakHTT8Xzb1LUKAiy18vgMq9DV1+GBvuoExuiTEwL68ai7dRNsSZ0fRRM6szBdJ99ROdOiOM+F2+R5yxYr66fOMsHsVNPbLPolco23tUk2NukEcw1dnQtelpYakRKUgbufLYgWH5/WZvCYvCrW9NqOM7o5nNqoWRuu/T/iXkhYNhTPFF/kCC6kmxC4m2wDqri6+TAjEBFWJ2fBoPMLxt8uDZXAByRahbAeHrRmCMh+cDA479/5Bs+fZGsRa5ZHCsVxyJuOLFAmKIImtI0cC0FcXSt1GSnOFPzOFUGPxKMjPozFWCPprkiPgnvCoPWXyv1bVeVRvF7VO0XtlR2Ue1NQTy39jPgFD5U6O0rc7HZ32TAhCLtEOK2F9OSjB7gyKzdiSXdA/6eg8vCvNgAmdJ07x7IoJtTHLvO/N4rmi0NfGucb72vXcvbr6SHG07/g49LPpl8kL+mWsCzc6AfdM7MfyncxtcahflQxtZKtypo7bqElcLwlok0s/AsCClC4nczVUOaMjAWrPRLCEv2d9+ECTpfMyg2c+WBVhHRoXvrhf64RCVd1JGapcUMFlzOrERT6BpYtX/VLZnHWjRXzAPFLvP8PHUgdQy2DAsAQbtW7qTSIPrLX85lJHAq4BTpV1hZirPF00mLs+pYF2ZIH6RH2mSpmAVGsbRqfqXl0vTbOOmYVDj9j7D krE0F/mA YEWiez7Lo6J0z7TlfgY6DsxHqU0oM32bD7fUd/tYLksNMUHdRTQaj0iJKcMuLvte/PFs2f37YHxJWiLGofg8UddGpuhF1k6gHOz8Qf5QNRuHjIxI86NQLugvR9OtJbUyKqHnj4MSeussWxx+HE0kJ3Mp0VV+SQAz9lZd9x0H6yPD9e4WwbszxoztWbLMkIJ5zZNz6JT+D74BYBtjhruT8bEdmCRzdt4U2w+DVm09rfyv60I3aHrcIjOH6ChxAGMySTLXquXOdFrFzcqYNnEMYxJAz1gty2VP5u5uP2rMfo07INHQNtmFEW17PbEC4ls3mqQ24LktQWHIVPe93XMf2wz6Pjg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000089, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 12 Dec 2024 16:40:10 -0500 "Liam R. Howlett" wrote: > * Kalesh Singh [241211 18:28]: > > Introduce csky arch_mmap_hint() and define HAVE_ARCH_MMAP_HINT. > > This is a preparatory patch, no functional change is introduced. > > This also looks like it has changed the validation order and potentially > introduced functional changes? > > All these stem from the same cloned code (sparc32 iirc), but were not > updated when the cloned code was updated. This is why I am against > arch_* code. We should find a better way to unify the code so that > there is nothing different. You seem to have gotten some of the shared > code together, but some still exists. > > In the addresses, there are upper and lower limits, and sometimes > "colours". Could we not just define the upper/lower limits in each arch > and if colour is used? Maybe this is complicated with 32/64 handled > both in the 64 bit code. > > Is there any plan to unite this code further? > > We have had errors for many years in cloned but not updated code. I > really wish there was more information in the cover letter on what is > going on here. I'd like to try and reduce the arch_ code to, basically > nothing. > > I was also disappointed that I wasn't Cc'ed because I've spent a lot of > time in this code and this area. I am probably the last one to crawl > through and change any of this. Thanks, I removed this version of this series from mm-unstable.