* [PATCH] mm: include linux/pagemap.h where needed
@ 2024-12-12 15:39 Arnd Bergmann
2024-12-12 18:03 ` Junjie Fu
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2024-12-12 15:39 UTC (permalink / raw)
To: Vitaly Wool, Andrew Morton, Junjie Fu
Cc: Arnd Bergmann, Miaohe Lin, Uros Bizjak, Yosry Ahmed, Nhat Pham,
Zhongkun He, Johannes Weiner, linux-mm, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The pagemap header used to be included by accident here but is now
missing:
mm/z3fold.c: In function 'free_z3fold_page':
mm/z3fold.c:353:17: error: implicit declaration of function 'lock_page'; did you mean 'copy_page'? [-Wimplicit-function-declaration]
353 | lock_page(page);
| ^~~~~~~~~
| copy_page
Add the correct #include statement.
Fixes: a6c37165ca40 ("mempolicy.h: remove unnecessary header file inclusions with no test failure")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
mm/z3fold.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/z3fold.c b/mm/z3fold.c
index 379d24b4fef9..4ae93bb2e3ab 100644
--- a/mm/z3fold.c
+++ b/mm/z3fold.c
@@ -30,6 +30,7 @@
#include <linux/mm.h>
#include <linux/module.h>
#include <linux/page-flags.h>
+#include <linux/pagemap.h>
#include <linux/migrate.h>
#include <linux/node.h>
#include <linux/compaction.h>
--
2.39.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mm: include linux/pagemap.h where needed
2024-12-12 15:39 [PATCH] mm: include linux/pagemap.h where needed Arnd Bergmann
@ 2024-12-12 18:03 ` Junjie Fu
0 siblings, 0 replies; 2+ messages in thread
From: Junjie Fu @ 2024-12-12 18:03 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: akpm, linux-kernel, linux-mm, SeongJae Park
On December 12, 2024 at 23:39, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The pagemap header used to be included by accident here but is now
> missing:
>
> mm/z3fold.c: In function 'free_z3fold_page':
> mm/z3fold.c:353:17: error: implicit declaration of function 'lock_page'; did you mean 'copy_page'? [-Wimplicit-function-declaration]
> 353 | lock_page(page);
> | ^~~~~~~~~
> | copy_page
>
> Add the correct #include statement.
>
> Fixes: a6c37165ca40 ("mempolicy.h: remove unnecessary header file inclusions with no test failure")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> mm/z3fold.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/z3fold.c b/mm/z3fold.c
> index 379d24b4fef9..4ae93bb2e3ab 100644
> --- a/mm/z3fold.c
> +++ b/mm/z3fold.c
> @@ -30,6 +30,7 @@
> #include <linux/mm.h>
> #include <linux/module.h>
> #include <linux/page-flags.h>
> +#include <linux/pagemap.h>
> #include <linux/migrate.h>
> #include <linux/node.h>
> #include <linux/compaction.h>
Thank you for your fix!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-12 18:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-12 15:39 [PATCH] mm: include linux/pagemap.h where needed Arnd Bergmann
2024-12-12 18:03 ` Junjie Fu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox